{"thread":{"id":"22968","subject":"wishlist: git send-email improvement","startedAt":"2010-03-09T17:21:46Z","lastAt":"2010-03-13T13:06:54Z","messageCount":6,"participants":["Yann Droneaud","Junio C Hamano","L. Alberto Giménez"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"136458","messageId":"1268155306.4277.14.camel@localhost","threadId":"22968","inReplyTo":null,"subject":"wishlist: git send-email improvement","fromName":"Yann Droneaud","fromEmail":"yann@droneaud.fr","sentAt":"2010-03-09T17:21:46Z","receivedAt":"2010-03-09T17:21:46Z","isPatch":false,"sender":{"key":"yann@droneaud.fr","avatar":null},"body":"Hi,\n\nHere's a little wishlist for send-email\n\n- Use From: field extracted from patch:\n If there's no configuration for user.email and From: field is \n different than default auto generated From: address, \n git send-email should use the one in the patch as default.\n\n- Use To: field extracted from patch\n I've setup format-patch to add a default To: field with\n format.headers=\"To: xxx@yyy\". But git send-email did not use it and \n ask for a To: value.\n If there's no --to or sendmail.to, send-email should use To: value \n extracted from patch and ask for user confirmation.\n\nI've tried to add the later to git-send-email, but failed to fix it by\nnow in a reasonable time amount.\n\nRegards.\n\n-- \nYann Droneaud\n"},{"id":"136459","messageId":"7veijtz9kn.fsf@alter.siamese.dyndns.org","threadId":"22968","inReplyTo":"1268155306.4277.14.camel@localhost","subject":"Re: wishlist: git send-email improvement","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-03-09T17:30:48Z","receivedAt":"2010-03-09T17:30:48Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Yann Droneaud writes:\n\n> Here's a little wishlist for send-email\n>\n> - Use From: field extracted from patch:\n> If there's no configuration for user.email and From: field is \n> different than default auto generated From: address, \n> git send-email should use the one in the patch as default.\n\nI cannot judge how sensible this change is; please justify the motivation\nby adding \"it currently does _this_, which is not good for _such and such\nreasons_; instead\" between the third and the fourth line.\n\n> - Use To: field extracted from patch\n> I've setup format-patch to add a default To: field with\n> format.headers=\"To: xxx@yyy\". But git send-email did not use it and \n> ask for a To: value.\n> If there's no --to or sendmail.to, send-email should use To: value \n> extracted from patch and ask for user confirmation.\n\nWith the recent addition of format.to that is cooking somewhere, I think\nthis one is probably sensible.\n"},{"id":"136460","messageId":"1268156947.4277.26.camel@localhost","threadId":"22968","inReplyTo":"7veijtz9kn.fsf@alter.siamese.dyndns.org","subject":"Re: wishlist: git send-email improvement","fromName":"Yann Droneaud","fromEmail":"yann@droneaud.fr","sentAt":"2010-03-09T17:49:07Z","receivedAt":"2010-03-09T17:49:07Z","isPatch":false,"sender":{"key":"yann@droneaud.fr","avatar":null},"body":"Le mardi 09 mars 2010 à 09:30 -0800, Junio C Hamano a écrit :\n> Yann Droneaud writes:\n> \n> > Here's a little wishlist for send-email\n> >\n> > - Use From: field extracted from patch:\n> > If there's no configuration for user.email and From: field is \n> > different than default auto generated From: address, \n> > git send-email should use the one in the patch as default.\n> \n> I cannot judge how sensible this change is; please justify the motivation\n> by adding \"it currently does _this_, which is not good for _such and such\n> reasons_; instead\" between the third and the fourth line.\n> \n\nSometimes, i'm too lazy to setup a valid git config user.email, \nso i'm commiting with a default, broken author name which get used later\nby git format-patch to fill the From: field. \nEach time I'm doing this, I'm manually fixing the From: field in the\nmbox file, hoping it will be used by git send-email, and each time I'm\ndisappointing to see git send-email use the broken author name as\ndefault value.\nObviously, the proper fix would be for me to remember to set up git\nconfig user.email before issuing any command ... but the so-called human\nnature tells me it's definitely not my fault, the tool get it wrong and\nshould be fixed :) \nPerhaps I should learn to use git send-email --from instead.\n\n> > - Use To: field extracted from patch\n> > I've setup format-patch to add a default To: field with\n> > format.headers=\"To: xxx@yyy\". But git send-email did not use it and \n> > ask for a To: value.\n> > If there's no --to or sendmail.to, send-email should use To: value \n> > extracted from patch and ask for user confirmation.\n> \n> With the recent addition of format.to that is cooking somewhere, I think\n> this one is probably sensible.\n\nGreat.\n\nThanks for your time.\n\n-- \nYann Droneaud\n"},{"id":"136461","messageId":"1268157314.4277.30.camel@localhost","threadId":"22968","inReplyTo":"1268156947.4277.26.camel@localhost","subject":"Re: wishlist: git send-email improvement","fromName":"Yann Droneaud","fromEmail":"yann@droneaud.fr","sentAt":"2010-03-09T17:55:14Z","receivedAt":"2010-03-09T17:55:14Z","isPatch":false,"sender":{"key":"yann@droneaud.fr","avatar":null},"body":"Le mardi 09 mars 2010 à 18:49 +0100, Yann Droneaud a écrit :\n> Perhaps I should learn to use git send-email --from instead.\n\nSadly, it appends the From: field extracted from file to the Cc: list :/\n\nSo I still have to manually fix the mbox file before using git\nsend-email.\n\nRegards.\n\n-- \nYann Droneaud\n"},{"id":"136467","messageId":"4B96A1ED.3020809@sysvalve.homelinux.net","threadId":"22968","inReplyTo":"1268157314.4277.30.camel@localhost","subject":"Re: wishlist: git send-email improvement","fromName":"L. Alberto Giménez","fromEmail":"agimenez-git@sysvalve.homelinux.net","sentAt":"2010-03-09T19:30:53Z","receivedAt":"2010-03-09T19:30:53Z","isPatch":false,"sender":{"key":"agimenez-git@sysvalve.homelinux.net","avatar":null},"body":"On 03/09/2010 06:55 PM, Yann Droneaud wrote:\n> Le mardi 09 mars 2010 à 18:49 +0100, Yann Droneaud a écrit :\n>> Perhaps I should learn to use git send-email --from instead.\n> \n> Sadly, it appends the From: field extracted from file to the Cc: list :/\n> \n> So I still have to manually fix the mbox file before using git\n> send-email.\n\nHi,\n\nHave you tried --suppress-from?\n\n--[no-]suppress-from\n If this is set, do not add the From: address to the cc: list.\nDefault is the value of sendemail.suppressfrom configuration value; if\nthat is\n unspecified, default to --no-suppress-from.\n\nI'm not sure if it's what you need, but it seems to be.\n\n\nBest regards,\n-- \nL. Alberto Giménez\nGnuPG key ID 0x3BAABDE1\n\n-- \nL. Alberto Giménez\nGnuPG key ID 0x3BAABDE1\n"},{"id":"136720","messageId":"1268485614.7884.0.camel@localhost","threadId":"22968","inReplyTo":"4B96A1ED.3020809@sysvalve.homelinux.net","subject":"Re: wishlist: git send-email improvement","fromName":"Yann Droneaud","fromEmail":"yann@droneaud.fr","sentAt":"2010-03-13T13:06:54Z","receivedAt":"2010-03-13T13:06:54Z","isPatch":false,"sender":{"key":"yann@droneaud.fr","avatar":null},"body":"Le mardi 09 mars 2010 à 20:30 +0100, \"L. Alberto Giménez\" a écrit :\n> On 03/09/2010 06:55 PM, Yann Droneaud wrote:\n> > Le mardi 09 mars 2010 à 18:49 +0100, Yann Droneaud a écrit :\n> >> Perhaps I should learn to use git send-email --from instead.\n> > \n> > Sadly, it appends the From: field extracted from file to the Cc: list :/\n> > \n> > So I still have to manually fix the mbox file before using git\n> > send-email.\n> \n> Hi,\n> \n> Have you tried --suppress-from?\n> \n[...]\n> I'm not sure if it's what you need, but it seems to be.\n> \n\nTested and approved. \nThanks for the trick.\n\nRegards.\n\n-- \nYann Droneaud\n"}]}