{"thread":{"id":"22918","subject":"git stash save ","startedAt":"2010-03-05T12:16:54Z","lastAt":"2010-03-07T04:01:11Z","messageCount":7,"participants":["Thomas Singer","Johannes Sixt","Matthieu Moy","Jeff King","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"136202","messageId":"4B90F636.2030300@syntevo.com","threadId":"22918","inReplyTo":null,"subject":"git stash save ","fromName":"Thomas Singer","fromEmail":"thomas.singer@syntevo.com","sentAt":"2010-03-05T12:16:54Z","receivedAt":"2010-03-05T12:16:54Z","isPatch":false,"sender":{"key":"thomas.singer@syntevo.com","avatar":null},"body":"Where can I find information about what content in is (not)\nallowed? We've got a bug-report where a SmartGit user has simply entered a\nminus and Git refused to work. Of course, entering just a minus is quite\nuseless, but we have to be able to reliable detect allowed and disallowed\nmessages. Should every message with a leading minus be rejected? Maybe the\nbest would be to add a new command line option, e.g. --message before the\n, so one can provide anything as message?\n\n--\nBest regards,\nThomas Singer\n=============\nsyntevo GmbH\nhttp://www.syntevo.com\nhttp://blog.syntevo.com\n"},{"id":"136203","messageId":"4B90FF40.4020607@viscovery.net","threadId":"22918","inReplyTo":"4B90F636.2030300@syntevo.com","subject":"Re: git stash save ","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2010-03-05T12:55:28Z","receivedAt":"2010-03-05T12:55:28Z","isPatch":false,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Thomas Singer schrieb:\n> Where can I find information about what content in is (not)\n> allowed? We've got a bug-report where a SmartGit user has simply entered a\n> minus and Git refused to work. Of course, entering just a minus is quite\n> useless, but we have to be able to reliable detect allowed and disallowed\n> messages.\n\nDoes SmartGit call 'git stash save' behind the scenes with the\nuser-supplied message? Then it should run\n\n git stash save -- \"$msg\"\n\nand you don't need to forbid anything.\n\n-- Hannes\n"},{"id":"136204","messageId":"4B910736.7060604@syntevo.com","threadId":"22918","inReplyTo":"4B90FF40.4020607@viscovery.net","subject":"Re: git stash save ","fromName":"Thomas Singer","fromEmail":"thomas.singer@syntevo.com","sentAt":"2010-03-05T13:29:26Z","receivedAt":"2010-03-05T13:29:26Z","isPatch":false,"sender":{"key":"thomas.singer@syntevo.com","avatar":null},"body":"On 05.03.2010 13:55, Johannes Sixt wrote:\n> Does SmartGit call 'git stash save' behind the scenes with the\n> user-supplied message? Then it should run\n> \n> git stash save -- \"$msg\"\n> \n> and you don't need to forbid anything.\n\nThank you very much, this solved the problem.\n\nTom\n"},{"id":"136210","messageId":"1267805693-25206-1-git-send-email-Matthieu.Moy@imag.fr","threadId":"22918","inReplyTo":"4B910736.7060604@syntevo.com","subject":"[PATCH] stash: suggest the correct command line for unknown options.","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@imag.fr","sentAt":"2010-03-05T16:14:53Z","receivedAt":"2010-03-05T16:14:53Z","isPatch":true,"sender":{"key":"git@matthieu-moy.fr","avatar":"https://avatars.githubusercontent.com/u/14709?v=4"},"body":"\nSigned-off-by: Matthieu Moy \n---\n> > Does SmartGit call 'git stash save' behind the scenes with the\n> > user-supplied message? Then it should run\n> > \n> > git stash save -- \"$msg\"\n> > \n> > and you don't need to forbid anything.\n> \n> Thank you very much, this solved the problem.\n\n... unless one considers that the problem is that you had to ask.\nSomething like this should avoid others the problem.\n\n git-stash.sh | 1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/git-stash.sh b/git-stash.sh\nindex 2d69196..cf4e673 100755\n--- a/git-stash.sh\n+++ b/git-stash.sh\n@@ -151,6 +151,7 @@ save_stash () {\n \t\t\t;;\n \t\t-*)\n \t\t\techo \"error: unknown option for 'stash save': $1\"\n+\t\t\techo \" To provide a message, use 'git stash -- $1'.\"\n \t\t\tusage\n \t\t\t;;\n \t\t*)\n-- \n1.7.0.231.g9fa6.dirty\n"},{"id":"136213","messageId":"20100305170841.GA9325@coredump.intra.peff.net","threadId":"22918","inReplyTo":"1267805693-25206-1-git-send-email-Matthieu.Moy@imag.fr","subject":"Re: [PATCH] stash: suggest the correct command line for unknown options.","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2010-03-05T17:08:42Z","receivedAt":"2010-03-05T17:08:42Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Mar 05, 2010 at 05:14:53PM +0100, Matthieu Moy wrote:\n\n> diff --git a/git-stash.sh b/git-stash.sh\n> index 2d69196..cf4e673 100755\n> --- a/git-stash.sh\n> +++ b/git-stash.sh\n> @@ -151,6 +151,7 @@ save_stash () {\n> \t\t\t;;\n> \t\t-*)\n> \t\t\techo \"error: unknown option for 'stash save': $1\"\n> +\t\t\techo \" To provide a message, use 'git stash -- $1'.\"\n\nDon't you mean \"git stash save -- $1\"?\n\n-Peff\n"},{"id":"136218","messageId":"1267814603-26158-1-git-send-email-Matthieu.Moy@imag.fr","threadId":"22918","inReplyTo":"20100305170841.GA9325@coredump.intra.peff.net","subject":"[PATCH v2] stash: suggest the correct command line for unknown options.","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@imag.fr","sentAt":"2010-03-05T18:43:23Z","receivedAt":"2010-03-05T18:43:23Z","isPatch":true,"sender":{"key":"git@matthieu-moy.fr","avatar":"https://avatars.githubusercontent.com/u/14709?v=4"},"body":"\nSigned-off-by: Matthieu Moy \n---\nOups, as noticed by peff, my proposed command was wrong ...\n\n git-stash.sh | 1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/git-stash.sh b/git-stash.sh\nindex 2d69196..aa47e54 100755\n--- a/git-stash.sh\n+++ b/git-stash.sh\n@@ -151,6 +151,7 @@ save_stash () {\n \t\t\t;;\n \t\t-*)\n \t\t\techo \"error: unknown option for 'stash save': $1\"\n+\t\t\techo \" To provide a message, use git stash save -- '$1'\"\n \t\t\tusage\n \t\t\t;;\n \t\t*)\n-- \n1.7.0.231.g9fa6.dirty\n"},{"id":"136270","messageId":"7v1vfwbx14.fsf@alter.siamese.dyndns.org","threadId":"22918","inReplyTo":"1267814603-26158-1-git-send-email-Matthieu.Moy@imag.fr","subject":"Re: [PATCH v2] stash: suggest the correct command line for unknown options.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-03-07T04:01:11Z","receivedAt":"2010-03-07T04:01:11Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.\n"}]}