{"thread":{"id":"22901","subject":"[PATCH] Fix _XOPEN_SOURCE problem on DragonFly","startedAt":"2010-03-04T02:05:22Z","lastAt":"2010-04-02T08:02:04Z","messageCount":4,"participants":["YONETANI Tomokazu","Tay Ray Chuan"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"136131","messageId":"20100304020522.GA76036@les.ath.cx","threadId":"22901","inReplyTo":null,"subject":"[PATCH] Fix _XOPEN_SOURCE problem on DragonFly","fromName":"YONETANI Tomokazu","fromEmail":"qhwt+git@les.ath.cx","sentAt":"2010-03-04T02:05:22Z","receivedAt":"2010-03-04T02:05:22Z","isPatch":true,"sender":{"key":"y0n3t4n1@gmail.com","avatar":null},"body":"Hi.\nDragonFly has the same problem that FreeBSD used to have.  Since the\nreturn value of implicitly declared functions defaults to int, it can\ncause disasters on architectures where sizeof(int) < sizeof(void *).\nThe patch below should address this issue.\n\nBest regards,\nYONETANI Tomokazu.\n\ndiff --git a/git-compat-util.h b/git-compat-util.h\nindex a3c4537..e292926 100644\n--- a/git-compat-util.h\n+++ b/git-compat-util.h\n@@ -55,7 +55,8 @@\n # else\n # define _XOPEN_SOURCE 500\n # endif\n-#elif !defined(__APPLE__) && !defined(__FreeBSD__)  && !defined(__USLC__) && !defined(_M_UNIX) && !defined(sgi)\n+#elif !defined(__APPLE__) && !defined(__FreeBSD__) && !defined(__USLC__) && \\\n+      !defined(_M_UNIX) && !defined(sgi) && !defined(__DragonFly__)\n #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD needs 600 for S_ISLNK() */\n #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */\n #endif\n"},{"id":"138332","messageId":"20100401073742.GA52362@les.ath.cx","threadId":"22901","inReplyTo":"20100304020522.GA76036@les.ath.cx","subject":"Re: [PATCH] Fix _XOPEN_SOURCE problem on DragonFly","fromName":"YONETANI Tomokazu","fromEmail":"qhwt+git@les.ath.cx","sentAt":"2010-04-01T07:37:42Z","receivedAt":"2010-04-01T07:37:42Z","isPatch":true,"sender":{"key":"y0n3t4n1@gmail.com","avatar":null},"body":"Hello.\nIs there anything else I need to do to get this in?\n\nOn Thu, Mar 04, 2010 at 11:05:22AM +0900, YONETANI Tomokazu wrote:\n> Hi.\n> DragonFly has the same problem that FreeBSD used to have.  Since the\n> return value of implicitly declared functions defaults to int, it can\n> cause disasters on architectures where sizeof(int) < sizeof(void *).\n> The patch below should address this issue.\n> \n> Best regards,\n> YONETANI Tomokazu.\n> \n> diff --git a/git-compat-util.h b/git-compat-util.h\n> index a3c4537..e292926 100644\n> --- a/git-compat-util.h\n> +++ b/git-compat-util.h\n> @@ -55,7 +55,8 @@\n>  # else\n>  # define _XOPEN_SOURCE 500\n>  # endif\n> -#elif !defined(__APPLE__) && !defined(__FreeBSD__)  && !defined(__USLC__) && !defined(_M_UNIX) && !defined(sgi)\n> +#elif !defined(__APPLE__) && !defined(__FreeBSD__) && !defined(__USLC__) && \\\n> +      !defined(_M_UNIX) && !defined(sgi) && !defined(__DragonFly__)\n>  #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD needs 600 for S_ISLNK() */\n>  #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */\n>  #endif\n"},{"id":"138341","messageId":"h2ibe6fef0d1004010737n813b81dds438563ea81bf694f@mail.gmail.com","threadId":"22901","inReplyTo":"20100401073742.GA52362@les.ath.cx","subject":"Re: [PATCH] Fix _XOPEN_SOURCE problem on DragonFly","fromName":"Tay Ray Chuan","fromEmail":"rctay89@gmail.com","sentAt":"2010-04-01T14:37:48Z","receivedAt":"2010-04-01T14:37:48Z","isPatch":true,"sender":{"key":"rctay89@gmail.com","avatar":"https://avatars.githubusercontent.com/u/61553?v=4"},"body":"Hi,\n\nOn Thu, Apr 1, 2010 at 3:37 PM, YONETANI Tomokazu <qhwt+git@les.ath.cx> wrote:\n> Hello.\n> Is there anything else I need to do to get this in?\n\nyou should read Documentation/SubmittingPatches:\n\n  http://github.com/git/git/blob/HEAD/Documentation/SubmittingPatches\n\nBriefly,\n\n1. Generate your patch with git-format-patch.\n\n2. s-o-b.\n\n-- \nCheers,\nRay Chuan\n"},{"id":"138405","messageId":"20100402080204.GB53099@les.ath.cx","threadId":"22901","inReplyTo":"h2ibe6fef0d1004010737n813b81dds438563ea81bf694f@mail.gmail.com","subject":"Re: [PATCH] Fix _XOPEN_SOURCE problem on DragonFly","fromName":"YONETANI Tomokazu","fromEmail":"qhwt+git@les.ath.cx","sentAt":"2010-04-02T08:02:04Z","receivedAt":"2010-04-02T08:02:04Z","isPatch":true,"sender":{"key":"y0n3t4n1@gmail.com","avatar":null},"body":"On Thu, Apr 01, 2010 at 10:37:48PM +0800, Tay Ray Chuan wrote:\n> On Thu, Apr 1, 2010 at 3:37 PM, YONETANI Tomokazu <qhwt+git@les.ath.cx> wrote:\n> > Hello.\n> > Is there anything else I need to do to get this in?\n> \n> you should read Documentation/SubmittingPatches:\n> \n>   http://github.com/git/git/blob/HEAD/Documentation/SubmittingPatches\n> \n> Briefly,\n> \n> 1. Generate your patch with git-format-patch.\n> \n> 2. s-o-b.\n\nI *thought* having read something like that before :)  Thanks for the hint.\nI just re-submitted the patch to meet the requirement.  Hopefully the new\none won't annoy anyone.\n\nBest regards,\nYONETANI Tomokazu.\n"}]}