{"thread":{"id":"22792","subject":"[PATCH 2/3] git-core: Support retrieving passwords with GIT_ASKPASS","startedAt":"2010-02-24T15:14:45Z","lastAt":"2010-02-24T15:14:45Z","messageCount":1,"participants":["Frank Li"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"135572","messageId":"1267024485-4076-1-git-send-email-lznuaa@gmail.com","threadId":"22792","inReplyTo":null,"subject":"[PATCH 2/3] git-core: Support retrieving passwords with GIT_ASKPASS","fromName":"Frank Li","fromEmail":"lznuaa@gmail.com","sentAt":"2010-02-24T15:14:45Z","receivedAt":"2010-02-24T15:14:45Z","isPatch":true,"sender":{"key":"lznuaa@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40642?v=4"},"body":"imap-send and authority http connect reads passwords from an interactive\nterminal. This behavious cause GUIs to hang waiting for git complete.\n\nFix this problem by allowing a password-retrieving command\nto be specified in GIT_ASKPASS\n\nSigned-off-by: Frank Li <lznuaa@gmail.com>\n---\n connect.c   |   40 ++++++++++++++++++++++++++++++++++++++++\n http.c      |    4 ++--\n imap-send.c |    2 +-\n 3 files changed, 43 insertions(+), 3 deletions(-)\n\ndiff --git a/connect.c b/connect.c\nindex a37cf6a..6a8e3ab 100644\n--- a/connect.c\n+++ b/connect.c\n@@ -647,3 +647,43 @@ int finish_connect(struct child_process *conn)\n \tfree(conn);\n \treturn code;\n }\n+\n+char *git_getpass(char *prompt)\n+{\n+\tchar *askpass;\n+\tstruct child_process pass;\n+\tconst char *args[3];\n+\tstruct strbuf buffer = STRBUF_INIT;\n+\tint i = 0;\n+\n+\taskpass = getenv(\"GIT_ASKPASS\");\n+\tif (askpass && strlen(askpass) != 0) {\n+\t\targs[0] = getenv(\"GIT_ASKPASS\");\n+\t\targs[1]\t= prompt;\n+\t\targs[2] = NULL;\n+\n+\t\tmemset(&pass, 0, sizeof(pass));\n+\t\tpass.argv = args;\n+\t\tpass.out = -1;\n+\t\tpass.no_stdin = 1;\n+\t\tpass.no_stderr = 1;\n+\n+\t\tif (start_command(&pass)) {\n+\t\t\terror(\"could not run %s\\n\", askpass);\n+\t\t\treturn getpass(prompt);\n+\t\t}\n+\n+\t\tstrbuf_read(&buffer, pass.out, 20);\n+\t\tclose(pass.out);\n+\t\tfor (i = 0; i < buffer.len; i++)\n+\t\t\tif (buffer.buf[i] == '\\n' || buffer.buf[i] == '\\r') {\n+\t\t\t\tbuffer.buf[i] = '\\0';\n+\t\t\t\tbuffer.len = i;\n+\t\t}\n+\t\treturn strbuf_detach(&buffer, NULL);\n+\n+\t} else {\n+\t\treturn getpass(prompt);\n+\t}\n+\treturn NULL;\n+}\ndiff --git a/http.c b/http.c\nindex deab595..4814217 100644\n--- a/http.c\n+++ b/http.c\n@@ -204,7 +204,7 @@ static void init_curl_http_auth(CURL *result)\n \tif (user_name) {\n \t\tstruct strbuf up = STRBUF_INIT;\n \t\tif (!user_pass)\n-\t\t\tuser_pass = xstrdup(getpass(\"Password: \"));\n+\t\t\tuser_pass = xstrdup(git_getpass(\"Password: \"));\n \t\tstrbuf_addf(&up, \"%s:%s\", user_name, user_pass);\n \t\tcurl_easy_setopt(result, CURLOPT_USERPWD,\n \t\t\t\t strbuf_detach(&up, NULL));\n@@ -219,7 +219,7 @@ static int has_cert_password(void)\n \t\treturn 0;\n \t/* Only prompt the user once. */\n \tssl_cert_password_required = -1;\n-\tssl_cert_password = getpass(\"Certificate Password: \");\n+\tssl_cert_password = git_getpass(\"Certificate Password: \");\n \tif (ssl_cert_password != NULL) {\n \t\tssl_cert_password = xstrdup(ssl_cert_password);\n \t\treturn 1;\ndiff --git a/imap-send.c b/imap-send.c\nindex 5631930..5254b2a 100644\n--- a/imap-send.c\n+++ b/imap-send.c\n@@ -1107,7 +1107,7 @@ static struct store *imap_open_store(struct imap_server_conf *srvc)\n \t\tif (!srvc->pass) {\n \t\t\tchar prompt[80];\n \t\t\tsprintf(prompt, \"Password (%s@%s): \", srvc->user, srvc->host);\n-\t\t\targ = getpass(prompt);\n+\t\t\targ = git_getpass(prompt);\n \t\t\tif (!arg) {\n \t\t\t\tperror(\"getpass\");\n \t\t\t\texit(1);\n-- \n1.7.0.85.g37fda.dirty\n"}]}