{"thread":{"id":"22786","subject":"Re: [PATCH] commit: quote the user name in the example","startedAt":"2010-02-24T02:54:09Z","lastAt":"2010-02-24T14:19:35Z","messageCount":5,"participants":["Junio C Hamano","Matt Kraai","Johannes Sixt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"135519","messageId":"1266980049-5835-1-git-send-email-kraai@ftbfs.org","threadId":"22786","inReplyTo":null,"subject":"[PATCH] commit: quote the user name in the example","fromName":"Matt Kraai","fromEmail":"kraai@ftbfs.org","sentAt":"2010-02-24T02:54:09Z","receivedAt":"2010-02-24T02:54:09Z","isPatch":true,"sender":{"key":"kraai@ftbfs.org","avatar":null},"body":"If the user runs\n\n git config --global user.name Your Name\n\nas suggested, user.name will be set to \"Your\". With this patch, the\nsuggested command will be\n\n git config --global user.name 'Your Name'\n\nwhich will set user.name to \"Your Name\" and hopefully help users avoid\nthe former mistake.\n\nSigned-off-by: Matt Kraai \n---\n builtin-commit.c | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin-commit.c b/builtin-commit.c\nindex 55676fd..1ec89d1 100644\n--- a/builtin-commit.c\n+++ b/builtin-commit.c\n@@ -41,7 +41,7 @@ static const char implicit_ident_advice[] =\n \"on your username and hostname. Please check that they are accurate.\\n\"\n \"You can suppress this message by setting them explicitly:\\n\"\n \"\\n\"\n-\" git config --global user.name Your Name\\n\"\n+\" git config --global user.name 'Your Name'\\n\"\n \" git config --global user.email you@example.com\\n\"\n \"\\n\"\n \"If the identity used for this commit is wrong, you can fix it with:\\n\"\n-- \n1.7.0\n"},{"id":"135517","messageId":"7vwry3nxsd.fsf@alter.siamese.dyndns.org","threadId":"22786","inReplyTo":"1266980049-5835-1-git-send-email-kraai@ftbfs.org","subject":"Re: [PATCH] commit: quote the user name in the example","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-02-24T03:00:02Z","receivedAt":"2010-02-24T03:00:02Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks; will queue for 'maint'.\n"},{"id":"135542","messageId":"4B84DA03.1040809@viscovery.net","threadId":"22786","inReplyTo":"1266980049-5835-1-git-send-email-kraai@ftbfs.org","subject":"Re: [PATCH] commit: quote the user name in the example","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2010-02-24T07:49:23Z","receivedAt":"2010-02-24T07:49:23Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Matt Kraai schrieb:\n> If the user runs\n> \n> git config --global user.name Your Name\n> \n> as suggested, user.name will be set to \"Your\". With this patch, the\n> suggested command will be\n> \n> git config --global user.name 'Your Name'\n> \n> which will set user.name to \"Your Name\" and hopefully help users avoid\n> the former mistake.\n\nActually, I would prefer that the suggested command is\n\n git config --global user.name \"Your Name\"\n\ni.e., with double-quotes, because then the suggestion is also correct for\nWindows users who run git from CMD: in this environment, single-quotes do\nnot quote, but double-quotes do.\n\n-- Hannes\n"},{"id":"135569","messageId":"1267021105-25691-1-git-send-email-kraai@ftbfs.org","threadId":"22786","inReplyTo":"4B84DA03.1040809@viscovery.net","subject":"[PATCH] commit: quote the user name in the example","fromName":"Matt Kraai","fromEmail":"kraai@ftbfs.org","sentAt":"2010-02-24T14:18:25Z","receivedAt":"2010-02-24T14:18:25Z","isPatch":true,"sender":{"key":"kraai@ftbfs.org","avatar":null},"body":"If the user runs\n\n git config --global user.name Your Name\n\nas suggested, user.name will be set to \"Your\". With this patch, the\nsuggested command will be\n\n git config --global user.name \"Your Name\"\n\nwhich will set user.name to \"Your Name\" and hopefully help users avoid\nthe former mistake.\n\nSigned-off-by: Matt Kraai \n---\n builtin-commit.c | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin-commit.c b/builtin-commit.c\nindex 55676fd..46513bf 100644\n--- a/builtin-commit.c\n+++ b/builtin-commit.c\n@@ -41,7 +41,7 @@ static const char implicit_ident_advice[] =\n \"on your username and hostname. Please check that they are accurate.\\n\"\n \"You can suppress this message by setting them explicitly:\\n\"\n \"\\n\"\n-\" git config --global user.name Your Name\\n\"\n+\" git config --global user.name \\\"Your Name\\\"\\n\"\n \" git config --global user.email you@example.com\\n\"\n \"\\n\"\n \"If the identity used for this commit is wrong, you can fix it with:\\n\"\n-- \n1.7.0\n"},{"id":"135570","messageId":"20100224141935.GC2709@ftbfs.org","threadId":"22786","inReplyTo":"4B84DA03.1040809@viscovery.net","subject":"Re: [PATCH] commit: quote the user name in the example","fromName":"Matt Kraai","fromEmail":"kraai@ftbfs.org","sentAt":"2010-02-24T14:19:35Z","receivedAt":"2010-02-24T14:19:35Z","isPatch":true,"sender":{"key":"kraai@ftbfs.org","avatar":null},"body":"On Wed, Feb 24, 2010 at 08:49:23AM +0100, Johannes Sixt wrote:\n> Actually, I would prefer that the suggested command is\n> \n> git config --global user.name \"Your Name\"\n> \n> i.e., with double-quotes, because then the suggestion is also correct for\n> Windows users who run git from CMD: in this environment, single-quotes do\n> not quote, but double-quotes do.\n\nI've justed submitted a modified version of the patch that uses\ndouble-quotes. Thanks for the suggestion.\n\n-- \nMatt http://ftbfs.org/kraai\n"}]}