{"thread":{"id":"22779","subject":"[GIT GUI PATCH] git-gui: fix open explorer window on Windows 7","startedAt":"2010-02-23T22:52:45Z","lastAt":"2010-02-27T21:14:30Z","messageCount":13,"participants":["Heiko Voigt","Markus Heidelberg","Giuseppe Bilotta","Pat Thoyts","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"135486","messageId":"20100223225243.GC11271@book.hvoigt.net","threadId":"22779","inReplyTo":null,"subject":"[GIT GUI PATCH] git-gui: fix open explorer window on Windows 7","fromName":"Heiko Voigt","fromEmail":"hvoigt@hvoigt.net","sentAt":"2010-02-23T22:52:45Z","receivedAt":"2010-02-23T22:52:45Z","isPatch":true,"sender":{"key":"hvoigt@hvoigt.net","avatar":"https://avatars.githubusercontent.com/u/184958?v=4"},"body":"It seems that Windows 7's explorer is not capable to cope with paths\nthat contain forward slashes as path seperator. We thus substitute slash\nwith the platforms native backslash.\n\nSigned-off-by: Heiko Voigt \n---\n git-gui/git-gui.sh | 4 +++-\n 1 files changed, 3 insertions(+), 1 deletions(-)\n\ndiff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh\nindex 9a9525d..ae45a12 100644\n--- a/git-gui/git-gui.sh\n+++ b/git-gui/git-gui.sh\n@@ -2112,15 +2112,17 @@ proc do_git_gui {} {\n proc do_explore {} {\n \tglobal _gitworktree\n \tset explorer {}\n+\tset path $_gitworktree\n \tif {[is_Cygwin] || [is_Windows]} {\n \t\tset explorer \"explorer.exe\"\n+\t\tset path [list [string map {/ \\\\} $path]]\n \t} elseif {[is_MacOSX]} {\n \t\tset explorer \"open\"\n \t} else {\n \t\t# freedesktop.org-conforming system is our best shot\n \t\tset explorer \"xdg-open\"\n \t}\n-\teval exec $explorer $_gitworktree &\n+\teval exec $explorer $path &\n }\n \n set is_quitting 0\n-- \n1.7.0.m5.rc2.15.g8ba4c\n"},{"id":"135506","messageId":"201002240114.11634.markus.heidelberg@web.de","threadId":"22779","inReplyTo":"20100223225243.GC11271@book.hvoigt.net","subject":"Re: [GIT GUI PATCH] git-gui: fix open explorer window on Windows 7","fromName":"Markus Heidelberg","fromEmail":"markus.heidelberg@web.de","sentAt":"2010-02-24T00:14:11Z","receivedAt":"2010-02-24T00:14:11Z","isPatch":true,"sender":{"key":"markus.heidelberg@web.de","avatar":"https://avatars.githubusercontent.com/u/6334512?v=4"},"body":"Heiko Voigt, 2010-02-23 23:52:\n> It seems that Windows 7's explorer is not capable to cope with paths\n> that contain forward slashes as path seperator. We thus substitute slash\n> with the platforms native backslash.\n> \n> Signed-off-by: Heiko Voigt \n> ---\n> git-gui/git-gui.sh | 4 +++-\n> 1 files changed, 3 insertions(+), 1 deletions(-)\n> \n> diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh\n> index 9a9525d..ae45a12 100644\n> --- a/git-gui/git-gui.sh\n> +++ b/git-gui/git-gui.sh\n> @@ -2112,15 +2112,17 @@ proc do_git_gui {} {\n> proc do_explore {} {\n> \tglobal _gitworktree\n> \tset explorer {}\n> +\tset path $_gitworktree\n> \tif {[is_Cygwin] || [is_Windows]} {\n> \t\tset explorer \"explorer.exe\"\n> +\t\tset path [list [string map {/ \\\\} $path]]\n\nI remember having had the same problem, which I fixed with [file\nnativename]. See commit 454efb47b (git-gui (Win): make \"Explore Working\nCopy\" more robust). But that was on XP, shouldn't be Windows 7 specific.\nSo why does it fail now again, although I had fixed it? ...\n\n> \t} elseif {[is_MacOSX]} {\n> \t\tset explorer \"open\"\n> \t} else {\n> \t\t# freedesktop.org-conforming system is our best shot\n> \t\tset explorer \"xdg-open\"\n> \t}\n> -\teval exec $explorer $_gitworktree &\n> +\teval exec $explorer $path &\n\nAh, this doesn't look like what it looked like back then. Commit\n21985a113 (git-gui: handle non-standard worktree locations) changed it,\nremoving the [file nativename]. I don't know if this was by accident,\nbut there is another place, where it was changed in a different manner:\n\nCompare\n\n- eval exec $explorer [list [file nativename [file dirname [gitdir]]]] &\n+ eval exec $explorer $_gitworktree &\n\nwith\n\n-wm title . \"[appname] ([reponame]) [file normalize [file dirname [gitdir]]]\"\n+wm title . \"[appname] ([reponame]) [file normalize $_gitworktree]\"\n\nMaybe _gitworktree should be normalized or nativenamified when it is set\nand then will work everywhere it is used for every platform?\n\nMarkus\n"},{"id":"135528","messageId":"cb7bb73a1002232222r354a2ec7l9ea4cfd1c101e8c6@mail.gmail.com","threadId":"22779","inReplyTo":"201002240114.11634.markus.heidelberg@web.de","subject":"Re: [GIT GUI PATCH] git-gui: fix open explorer window on Windows 7","fromName":"Giuseppe Bilotta","fromEmail":"giuseppe.bilotta@gmail.com","sentAt":"2010-02-24T06:22:33Z","receivedAt":"2010-02-24T06:22:33Z","isPatch":true,"sender":{"key":"giuseppe.bilotta@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1464?v=4"},"body":"On Wed, Feb 24, 2010 at 1:14 AM, Markus Heidelberg\n wrote:\n>\n> Ah, this doesn't look like what it looked like back then. Commit\n> 21985a113 (git-gui: handle non-standard worktree locations) changed it,\n> removing the [file nativename]. I don't know if this was by accident,\n> but there is another place, where it was changed in a different manner:\n\nMy fault, and yes it was by accident.\n\n> Compare\n>\n> -       eval exec $explorer [list [file nativename [file dirname [gitdir]]]] &\n> +       eval exec $explorer $_gitworktree &\n>\n> with\n>\n> -wm title . \"[appname] ([reponame]) [file normalize [file dirname [gitdir]]]\"\n> +wm title . \"[appname] ([reponame]) [file normalize $_gitworktree]\"\n>\n> Maybe _gitworktree should be normalized or nativenamified when it is set\n> and then will work everywhere it is used for every platform?\n\nThe only issue with that would be that GIT_DIR and GIT_WORK_TREE are\n(re)inizialized\nfrom _gitdir and _gitworktree, so it would not be safe if git on\nWindows works better with unix-style rather than native paths. If git\non windows handles native paths fine, it should be no problem.\n\n-- \nGiuseppe \"Oblomov\" Bilotta\n"},{"id":"135554","messageId":"a5b261831002240412x30490e25wbec74cdbc1d0ebd2@mail.gmail.com","threadId":"22779","inReplyTo":"cb7bb73a1002232222r354a2ec7l9ea4cfd1c101e8c6@mail.gmail.com","subject":"Re: [msysGit] Re: [GIT GUI PATCH] git-gui: fix open explorer window on Windows 7","fromName":"Pat Thoyts","fromEmail":"patthoyts@googlemail.com","sentAt":"2010-02-24T12:12:24Z","receivedAt":"2010-02-24T12:12:24Z","isPatch":true,"sender":{"key":"patthoyts@googlemail.com","avatar":"https://gravatar.com/avatar/2300f94d9f59174a551dbc71278ac2cb2489f56afda920a57e189ad9de0a3f92?d=mp&s=160"},"body":"On 24 February 2010 06:22, Giuseppe Bilotta wrote:\n\n>+ set path [list [string map {/ \\\\} $path]]\n\nNo - Tcl provides [file nativename $path] for this purpose.\n\n>\n> The only issue with that would be that GIT_DIR and GIT_WORK_TREE are\n> (re)inizialized\n> from _gitdir and _gitworktree, so it would not be safe if git on\n> Windows works better with unix-style rather than native paths. If git\n> on windows handles native paths fine, it should be no problem.\n\nTcl internally uses unix type path separators but once you export this\npath to the operating system you may need to ensure it is a native\npath. Typically that means when calling [exec]. [open] is a tcl\ncommand and will deal with a path variable in either style. The Tcl\nexec man page has some notes on the compatibility issues.\n\nPat.\n"},{"id":"135555","messageId":"a5b261831002240415l5447ac94wd80c162fc9492fd5@mail.gmail.com","threadId":"22779","inReplyTo":"20100223225243.GC11271@book.hvoigt.net","subject":"Re: [msysGit] [GIT GUI PATCH] git-gui: fix open explorer window on Windows 7","fromName":"Pat Thoyts","fromEmail":"patthoyts@googlemail.com","sentAt":"2010-02-24T12:15:03Z","receivedAt":"2010-02-24T12:15:03Z","isPatch":true,"sender":{"key":"patthoyts@googlemail.com","avatar":"https://gravatar.com/avatar/2300f94d9f59174a551dbc71278ac2cb2489f56afda920a57e189ad9de0a3f92?d=mp&s=160"},"body":"On 23 February 2010 22:52, Heiko Voigt wrote:\n> It seems that Windows 7's explorer is not capable to cope with paths\n> that contain forward slashes as path seperator. We thus substitute slash\n> with the platforms native backslash.\n>\n\nWhat bug are you actually addressing here? How can I reproduce it? My\nexperience on Windows 7 is that there is no problem but I assume I'm\ndoing a different operation. If I use the git-gui \"Explore working\ncopy\" it opens the Windows explorer for me just fine.\n"},{"id":"135642","messageId":"201002250114.23322.markus.heidelberg@web.de","threadId":"22779","inReplyTo":"a5b261831002240412x30490e25wbec74cdbc1d0ebd2@mail.gmail.com","subject":"[PATCH] git-gui: fix \"Explore Working Copy\" for Windows again","fromName":"Markus Heidelberg","fromEmail":"markus.heidelberg@web.de","sentAt":"2010-02-25T00:14:22Z","receivedAt":"2010-02-25T00:14:22Z","isPatch":true,"sender":{"key":"markus.heidelberg@web.de","avatar":"https://avatars.githubusercontent.com/u/6334512?v=4"},"body":"It has already been fixed in commit 454efb47 (git-gui (Win): make\n\"Explore Working Copy\" more robust, 2009-04-01), but has been broken in\ncommit 21985a11 (git-gui: handle non-standard worktree locations,\n2010-01-23) by accidentally replacing too much with a new variable.\n\nThe problem can be reproduced when starting git-gui from within a\nsubdirectory. The solution is to convert the path name, explorer.exe is\ninvoked with, to a platform native name.\n\nSigned-off-by: Markus Heidelberg \n---\n\n> > > Maybe _gitworktree should be normalized or nativenamified when it is set\n> > > and then will work everywhere it is used for every platform?\n> > \n> > The only issue with that would be that GIT_DIR and GIT_WORK_TREE are\n> > (re)inizialized\n> > from _gitdir and _gitworktree, so it would not be safe if git on\n> > Windows works better with unix-style rather than native paths. If git\n> > on windows handles native paths fine, it should be no problem.\n> \n> Tcl internally uses unix type path separators but once you export this\n> path to the operating system you may need to ensure it is a native\n> path. Typically that means when calling [exec]. [open] is a tcl\n> command and will deal with a path variable in either style. The Tcl\n> exec man page has some notes on the compatibility issues.\n\nSo this should be the obvious solution.\n\n git-gui.sh | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-gui.sh b/git-gui.sh\nindex 8996d2d..7184afa 100755\n--- a/git-gui.sh\n+++ b/git-gui.sh\n@@ -2101,7 +2101,7 @@ proc do_explore {} {\n \t\t# freedesktop.org-conforming system is our best shot\n \t\tset explorer \"xdg-open\"\n \t}\n-\teval exec $explorer $_gitworktree &\n+\teval exec $explorer [list [file nativename $_gitworktree]] &\n }\n \n set is_quitting 0\n-- \n1.7.0.52.gb3f79\n"},{"id":"135693","messageId":"20100225202949.GA12637@book.hvoigt.net","threadId":"22779","inReplyTo":"a5b261831002240415l5447ac94wd80c162fc9492fd5@mail.gmail.com","subject":"Re: Re: [GIT GUI PATCH] git-gui: fix open explorer window on Windows 7","fromName":"Heiko Voigt","fromEmail":"hvoigt@hvoigt.net","sentAt":"2010-02-25T20:30:11Z","receivedAt":"2010-02-25T20:30:11Z","isPatch":true,"sender":{"key":"hvoigt@hvoigt.net","avatar":"https://avatars.githubusercontent.com/u/184958?v=4"},"body":"On Wed, Feb 24, 2010 at 12:15:03PM +0000, Pat Thoyts wrote:\n> On 23 February 2010 22:52, Heiko Voigt wrote:\n> > It seems that Windows 7's explorer is not capable to cope with paths\n> > that contain forward slashes as path seperator. We thus substitute slash\n> > with the platforms native backslash.\n> >\n> \n> What bug are you actually addressing here? How can I reproduce it? My\n> experience on Windows 7 is that there is no problem but I assume I'm\n> doing a different operation. If I use the git-gui \"Explore working\n> copy\" it opens the Windows explorer for me just fine.\n\nVery strange, again another inconsistency between Windowses? I can\nreproduce this even on Windows XP. I am using the current devel branches\nof msysgit (msysgit and git). It happens when using the\n\"Repository->Explore working copy\" menu item. The Windows 7 I tested\nthis on is 32-bit Professional. Which Windows 7 are you using?\n\ncheers Heiko\n"},{"id":"135695","messageId":"20100225204451.GB12637@book.hvoigt.net","threadId":"22779","inReplyTo":"201002250114.23322.markus.heidelberg@web.de","subject":"Re: [PATCH] git-gui: fix \"Explore Working Copy\" for Windows again","fromName":"Heiko Voigt","fromEmail":"hvoigt@hvoigt.net","sentAt":"2010-02-25T20:44:53Z","receivedAt":"2010-02-25T20:44:53Z","isPatch":true,"sender":{"key":"hvoigt@hvoigt.net","avatar":"https://avatars.githubusercontent.com/u/184958?v=4"},"body":"On Thu, Feb 25, 2010 at 01:14:22AM +0100, Markus Heidelberg wrote:\n> It has already been fixed in commit 454efb47 (git-gui (Win): make\n> \"Explore Working Copy\" more robust, 2009-04-01), but has been broken in\n> commit 21985a11 (git-gui: handle non-standard worktree locations,\n> 2010-01-23) by accidentally replacing too much with a new variable.\n> \n> The problem can be reproduced when starting git-gui from within a\n> subdirectory. The solution is to convert the path name, explorer.exe is\n> invoked with, to a platform native name.\n> \n> Signed-off-by: Markus Heidelberg \n> ---\n\nI can confirm that this does fix the issue which is actually also\napparent on Windows XP. If no objections occur I would apply this to the\ndevel branch for msysgit.\n\ncheers Heiko\n"},{"id":"135698","messageId":"201002252323.13240.markus.heidelberg@web.de","threadId":"22779","inReplyTo":"20100225202949.GA12637@book.hvoigt.net","subject":"Re: [msysGit] [GIT GUI PATCH] git-gui: fix open explorer window on Windows 7","fromName":"Markus Heidelberg","fromEmail":"markus.heidelberg@web.de","sentAt":"2010-02-25T22:23:12Z","receivedAt":"2010-02-25T22:23:12Z","isPatch":true,"sender":{"key":"markus.heidelberg@web.de","avatar":"https://avatars.githubusercontent.com/u/6334512?v=4"},"body":"Heiko Voigt, 2010-02-25 21:30:\n> On Wed, Feb 24, 2010 at 12:15:03PM +0000, Pat Thoyts wrote:\n> > On 23 February 2010 22:52, Heiko Voigt wrote:\n> > > It seems that Windows 7's explorer is not capable to cope with paths\n> > > that contain forward slashes as path seperator. We thus substitute slash\n> > > with the platforms native backslash.\n> > >\n> > \n> > What bug are you actually addressing here? How can I reproduce it? My\n> > experience on Windows 7 is that there is no problem but I assume I'm\n> > doing a different operation. If I use the git-gui \"Explore working\n> > copy\" it opens the Windows explorer for me just fine.\n> \n> Very strange, again another inconsistency between Windowses? I can\n> reproduce this even on Windows XP. I am using the current devel branches\n> of msysgit (msysgit and git). It happens when using the\n> \"Repository->Explore working copy\" menu item. The Windows 7 I tested\n> this on is 32-bit Professional. Which Windows 7 are you using?\n\nYou should tell, how exactly you start git-gui, because this makes the\ndifference in this bug.\n\nMarkus\n"},{"id":"135700","messageId":"a5b261831002251449r7ac437f3h478727764ac755eb@mail.gmail.com","threadId":"22779","inReplyTo":"201002252323.13240.markus.heidelberg@web.de","subject":"Re: [msysGit] [GIT GUI PATCH] git-gui: fix open explorer window on Windows 7","fromName":"Pat Thoyts","fromEmail":"patthoyts@googlemail.com","sentAt":"2010-02-25T22:49:47Z","receivedAt":"2010-02-25T22:49:47Z","isPatch":true,"sender":{"key":"patthoyts@googlemail.com","avatar":"https://gravatar.com/avatar/2300f94d9f59174a551dbc71278ac2cb2489f56afda920a57e189ad9de0a3f92?d=mp&s=160"},"body":"On 25 February 2010 22:23, Markus Heidelberg wrote:\n> Heiko Voigt, 2010-02-25 21:30:\n>> On Wed, Feb 24, 2010 at 12:15:03PM +0000, Pat Thoyts wrote:\n>> > On 23 February 2010 22:52, Heiko Voigt wrote:\n>> > > It seems that Windows 7's explorer is not capable to cope with paths\n>> > > that contain forward slashes as path seperator. We thus substitute slash\n>> > > with the platforms native backslash.\n>> > >\n>> >\n>> > What bug are you actually addressing here? How can I reproduce it? My\n>> > experience on Windows 7 is that there is no problem but I assume I'm\n>> > doing a different operation. If I use the git-gui  \"Explore working\n>> > copy\" it opens the Windows explorer for me just fine.\n>>\n>> Very strange, again another inconsistency between Windowses? I can\n>> reproduce this even on Windows XP. I am using the current devel branches\n>> of msysgit (msysgit and git). It happens when using the\n>> \"Repository->Explore working copy\" menu item. The Windows 7 I tested\n>> this on is 32-bit Professional. Which Windows 7 are you using?\n>\n> You should tell, how exactly you start git-gui, because this makes the\n> difference in this bug.\n\nI have Windows 7 64 bit Ultimate - but I doubt the version of Win7 is\ngoing to matter here.\n\nIn my case, using the current release of msysGit (1.6.5.1.1367.gcd48)\ncan launch the Windows explorer and so can the current devel branch of\nmsysgit. I launch these from the windows cmd shell using the scripts\nin msysgit\\cmd\\ for the devel version\n\nBut lets be real certain we are runing the script in the\nmsysgit\\git\\git-gui directory:\n\nC:\\src\\msysgit\\git\\git-gui>set\nPATH=c:\\src\\msysgit\\bin;c:\\src\\msysgit\\mingw\\bin;%PATH%\nC:\\src\\msysgit\\git\\git-gui>tclkit86 git-gui.sh\n\nThis is now guaranteed running the script mentioned and it uses the\n'lib' subfolder from this directory too. Help About says git-gui\nversion @@GITGUI_VERSION@@ and git version 1.7.0.rc2.1441.g8e037 as I\nbuilt and installed this a few days ago.\n\nHowever, I notice that it is not actually browsing the working folder\nwhen it launches the browser - it has actually opened \"My Documents\".\nI presume this is the bug you intend to fix -- and applying your patch\nconfirms that it solves this issue.\n\nCan you please give enough information in the commit message to let us\nknow what issue is being solved by the changes provided.\n\nTo avoid any confusion I confirm the following patch ensures that\nexploring the working folder on Windows correctly opens the working\nfolder of the current repository.\n\nTested-by: Pat Thoyts \n\ndiff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh\nindex cd8da37..82c352b 100755\n--- a/git-gui/git-gui.sh\n+++ b/git-gui/git-gui.sh\n@@ -2099,15 +2099,17 @@ proc do_git_gui {} {\n proc do_explore {} {\n global _gitworktree\n set explorer {}\n+ set path $_gitworktree\n if {[is_Cygwin] || [is_Windows]} {\n set explorer \"explorer.exe\"\n+ set path [list [file nativename $path]]\n } elseif {[is_MacOSX]} {\n set explorer \"open\"\n } else {\n # freedesktop.org-conforming system is our best shot\n set explorer \"xdg-open\"\n }\n- eval exec $explorer $_gitworktree &\n+ eval exec $explorer $path &\n }\n\n set is_quitting 0\n"},{"id":"135702","messageId":"a5b261831002251500i2628946fo1bc2f7070f682702@mail.gmail.com","threadId":"22779","inReplyTo":"20100225204451.GB12637@book.hvoigt.net","subject":"Re: [PATCH] git-gui: fix \"Explore Working Copy\" for Windows again","fromName":"Pat Thoyts","fromEmail":"patthoyts@googlemail.com","sentAt":"2010-02-25T23:00:17Z","receivedAt":"2010-02-25T23:00:17Z","isPatch":true,"sender":{"key":"patthoyts@googlemail.com","avatar":"https://gravatar.com/avatar/2300f94d9f59174a551dbc71278ac2cb2489f56afda920a57e189ad9de0a3f92?d=mp&s=160"},"body":"On 25 February 2010 20:44, Heiko Voigt wrote:\n> On Thu, Feb 25, 2010 at 01:14:22AM +0100, Markus Heidelberg wrote:\n>> It has already been fixed in commit 454efb47 (git-gui (Win): make\n>> \"Explore Working Copy\" more robust, 2009-04-01), but has been broken in\n>> commit 21985a11 (git-gui: handle non-standard worktree locations,\n>> 2010-01-23) by accidentally replacing too much with a new variable.\n>>\n>> The problem can be reproduced when starting git-gui from within a\n>> subdirectory. The solution is to convert the path name, explorer.exe is\n>> invoked with, to a platform native name.\n>>\n>> Signed-off-by: Markus Heidelberg \n>> ---\n>\n> I can confirm that this does fix the issue which is actually also\n> apparent on Windows XP. If no objections occur I would apply this to the\n> devel branch for msysgit.\n>\n> cheers Heiko\n\nAgreed - the loss of the [file nativename] around the path is the\nfault. Replacement with\neval exec $explorer [list [file nativename $_gitworktree]] &\nwill be sufficient for all platforms (the [list] protects any spaces\nin the path against the eval).\n\nPat Thoyts\n"},{"id":"135710","messageId":"alpine.DEB.1.00.1002260145510.20986@pacific.mpi-cbg.de","threadId":"22779","inReplyTo":"20100225204451.GB12637@book.hvoigt.net","subject":"Re: [PATCH] git-gui: fix \"Explore Working Copy\" for Windows again","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2010-02-26T00:46:05Z","receivedAt":"2010-02-26T00:46:05Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Thu, 25 Feb 2010, Heiko Voigt wrote:\n\n> On Thu, Feb 25, 2010 at 01:14:22AM +0100, Markus Heidelberg wrote:\n> > It has already been fixed in commit 454efb47 (git-gui (Win): make\n> > \"Explore Working Copy\" more robust, 2009-04-01), but has been broken in\n> > commit 21985a11 (git-gui: handle non-standard worktree locations,\n> > 2010-01-23) by accidentally replacing too much with a new variable.\n> > \n> > The problem can be reproduced when starting git-gui from within a\n> > subdirectory. The solution is to convert the path name, explorer.exe is\n> > invoked with, to a platform native name.\n> > \n> > Signed-off-by: Markus Heidelberg \n> > ---\n> \n> I can confirm that this does fix the issue which is actually also \n> apparent on Windows XP. If no objections occur I would apply this to the \n> devel branch for msysgit.\n\nNo objections from my side!\n\nThanks,\nDscho\n"},{"id":"135852","messageId":"20100227211428.GF33000@book.hvoigt.net","threadId":"22779","inReplyTo":"alpine.DEB.1.00.1002260145510.20986@pacific.mpi-cbg.de","subject":"Re: Re: [PATCH] git-gui: fix \"Explore Working Copy\" for Windows again","fromName":"Heiko Voigt","fromEmail":"hvoigt@hvoigt.net","sentAt":"2010-02-27T21:14:30Z","receivedAt":"2010-02-27T21:14:30Z","isPatch":true,"sender":{"key":"hvoigt@hvoigt.net","avatar":"https://avatars.githubusercontent.com/u/184958?v=4"},"body":"On Fri, Feb 26, 2010 at 01:46:05AM +0100, Johannes Schindelin wrote:\n> On Thu, 25 Feb 2010, Heiko Voigt wrote:\n> \n> > On Thu, Feb 25, 2010 at 01:14:22AM +0100, Markus Heidelberg wrote:\n> > > It has already been fixed in commit 454efb47 (git-gui (Win): make\n> > > \"Explore Working Copy\" more robust, 2009-04-01), but has been broken in\n> > > commit 21985a11 (git-gui: handle non-standard worktree locations,\n> > > 2010-01-23) by accidentally replacing too much with a new variable.\n> > > \n> > > The problem can be reproduced when starting git-gui from within a\n> > > subdirectory. The solution is to convert the path name, explorer.exe is\n> > > invoked with, to a platform native name.\n> > > \n> > > Signed-off-by: Markus Heidelberg \n> > > ---\n> > \n> > I can confirm that this does fix the issue which is actually also \n> > apparent on Windows XP. If no objections occur I would apply this to the \n> > devel branch for msysgit.\n> \n> No objections from my side!\n\nDone.\n\ncheers Heiko\n"}]}