{"thread":{"id":"22778","subject":"git gui create desktop icon currently does not work","startedAt":"2010-02-23T22:49:57Z","lastAt":"2010-03-08T11:17:39Z","messageCount":12,"participants":["Heiko Voigt","Giuseppe Bilotta","Pat Thoyts","Johannes Schindelin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"135485","messageId":"20100223224955.GB11271@book.hvoigt.net","threadId":"22778","inReplyTo":null,"subject":"git gui create desktop icon currently does not work","fromName":"Heiko Voigt","fromEmail":"hvoigt@hvoigt.net","sentAt":"2010-02-23T22:49:57Z","receivedAt":"2010-02-23T22:49:57Z","isPatch":false,"sender":{"key":"hvoigt@hvoigt.net","avatar":"https://avatars.githubusercontent.com/u/184958?v=4"},"body":"Hi,\n\nI have a patch (further down) to this issue but I only tested this on\nWindows 7 and my virtual machine (XP) did not like it for some reason (it\ncreated the shortcut but the shortcut did not work). If anyone else can\nconfirm that this patch actually works we can include it.\n\nCommit 3748b0 git-gui: update shortcut tools to use _gitworktree\nfrom Guiseppe does break the creation of Desktop shortcuts on Windows.\n\nI do not know whether this has worked with any tcl interpreter as it\nattempts to execute $_gitworktree as a command.\n\nHere is my fix:\n\n>From 5c22c39d530ffb308826629d974048d30cd32e53 Mon Sep 17 00:00:00 2001\nFrom: Heiko Voigt \nDate: Tue, 23 Feb 2010 10:40:14 +0100\nSubject: [PATCH 1/2] git-gui: fix usage of _gitworktree when creating shortcut for windows\n\nSigned-off-by: Heiko Voigt \n---\n git-gui/lib/shortcut.tcl | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-gui/lib/shortcut.tcl b/git-gui/lib/shortcut.tcl\nindex 79c1888..8cad0e2 100644\n--- a/git-gui/lib/shortcut.tcl\n+++ b/git-gui/lib/shortcut.tcl\n@@ -16,7 +16,7 @@ proc do_windows_shortcut {} {\n \t\t\t\t\t[info nameofexecutable] \\\n \t\t\t\t\t[file normalize $::argv0] \\\n \t\t\t\t\t] \\\n-\t\t\t\t\t[file normalize [$_gitworktree]]\n+\t\t\t\t\t[file normalize $_gitworktree]\n \t\t\t} err]} {\n \t\t\terror_popup [strcat [mc \"Cannot write shortcut:\"] \"\\n\\n$err\"]\n \t\t}\n-- \n1.7.0.m5.rc2.15.g8ba4c\n"},{"id":"135489","messageId":"cb7bb73a1002231454j4720b28ei20c10de37e929fde@mail.gmail.com","threadId":"22778","inReplyTo":"20100223224955.GB11271@book.hvoigt.net","subject":"Re: git gui create desktop icon currently does not work","fromName":"Giuseppe Bilotta","fromEmail":"giuseppe.bilotta@gmail.com","sentAt":"2010-02-23T22:54:40Z","receivedAt":"2010-02-23T22:54:40Z","isPatch":false,"sender":{"key":"giuseppe.bilotta@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1464?v=4"},"body":"On Tue, Feb 23, 2010 at 11:49 PM, Heiko Voigt wrote:\n> Hi,\n>\n> I have a patch (further down) to this issue but I only tested this on\n> Windows 7 and my virtual machine (XP) did not like it for some reason (it\n> created the shortcut but the shortcut did not work). If anyone else can\n> confirm that this patch actually works we can include it.\n>\n> Commit 3748b0 git-gui: update shortcut tools to use _gitworktree\n> from Guiseppe does break the creation of Desktop shortcuts on Windows.\n>\n> I do not know whether this has worked with any tcl interpreter as it\n> attempts to execute $_gitworktree as a command.\n>\n> Here is my fix:\n>\n> From 5c22c39d530ffb308826629d974048d30cd32e53 Mon Sep 17 00:00:00 2001\n> From: Heiko Voigt \n> Date: Tue, 23 Feb 2010 10:40:14 +0100\n> Subject: [PATCH 1/2] git-gui: fix usage of _gitworktree when creating shortcut for windows\n>\n> Signed-off-by: Heiko Voigt \n> ---\n>  git-gui/lib/shortcut.tcl |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n>\n> diff --git a/git-gui/lib/shortcut.tcl b/git-gui/lib/shortcut.tcl\n> index 79c1888..8cad0e2 100644\n> --- a/git-gui/lib/shortcut.tcl\n> +++ b/git-gui/lib/shortcut.tcl\n> @@ -16,7 +16,7 @@ proc do_windows_shortcut {} {\n>                                        [info nameofexecutable] \\\n>                                        [file normalize $::argv0] \\\n>                                        ] \\\n> -                                       [file normalize [$_gitworktree]]\n> +                                       [file normalize $_gitworktree]\n>                        } err]} {\n>                        error_popup [strcat [mc \"Cannot write shortcut:\"] \"\\n\\n$err\"]\n>                }\n\nOuch. Yes, I think your patch is obviously correct.\n\n(I'll go sit in a corner with my 'TCL Dunce' cap on for a while ...)\n\n-- \nGiuseppe \"Oblomov\" Bilotta\n"},{"id":"135491","messageId":"20100223230238.GD11271@book.hvoigt.net","threadId":"22778","inReplyTo":"cb7bb73a1002231454j4720b28ei20c10de37e929fde@mail.gmail.com","subject":"Re: Re: git gui create desktop icon currently does not work","fromName":"Heiko Voigt","fromEmail":"hvoigt@hvoigt.net","sentAt":"2010-02-23T23:02:38Z","receivedAt":"2010-02-23T23:02:38Z","isPatch":false,"sender":{"key":"hvoigt@hvoigt.net","avatar":"https://avatars.githubusercontent.com/u/184958?v=4"},"body":"On Tue, Feb 23, 2010 at 11:54:40PM +0100, Giuseppe Bilotta wrote:\n> On Tue, Feb 23, 2010 at 11:49 PM, Heiko Voigt wrote:\n[...]\n> > From 5c22c39d530ffb308826629d974048d30cd32e53 Mon Sep 17 00:00:00 2001\n> > From: Heiko Voigt \n> > Date: Tue, 23 Feb 2010 10:40:14 +0100\n> > Subject: [PATCH 1/2] git-gui: fix usage of _gitworktree when creating shortcut for windows\n> >\n> > Signed-off-by: Heiko Voigt \n> > ---\n> >  git-gui/lib/shortcut.tcl |    2 +-\n> >  1 files changed, 1 insertions(+), 1 deletions(-)\n> >\n> > diff --git a/git-gui/lib/shortcut.tcl b/git-gui/lib/shortcut.tcl\n> > index 79c1888..8cad0e2 100644\n> > --- a/git-gui/lib/shortcut.tcl\n> > +++ b/git-gui/lib/shortcut.tcl\n> > @@ -16,7 +16,7 @@ proc do_windows_shortcut {} {\n> >                                        [info nameofexecutable] \\\n> >                                        [file normalize $::argv0] \\\n> >                                        ] \\\n> > -                                       [file normalize [$_gitworktree]]\n> > +                                       [file normalize $_gitworktree]\n> >                        } err]} {\n> >                        error_popup [strcat [mc \"Cannot write shortcut:\"] \"\\n\\n$err\"]\n> >                }\n> \n> Ouch. Yes, I think your patch is obviously correct.\n> \n> (I'll go sit in a corner with my 'TCL Dunce' cap on for a while ...)\n\nNo problem obviously nobody else saw this, but please test your patches\nin the future. That could have avoided this one.\n\nOne thing which is missing from my patch is the cygwin part which, as I\nsaw from your original patch, has the same problem.\n\ncheers Heiko\n"},{"id":"135658","messageId":"cb7bb73a1002242353h739786bdlb2c57df3438f5b7f@mail.gmail.com","threadId":"22778","inReplyTo":"20100223230238.GD11271@book.hvoigt.net","subject":"Re: Re: git gui create desktop icon currently does not work","fromName":"Giuseppe Bilotta","fromEmail":"giuseppe.bilotta@gmail.com","sentAt":"2010-02-25T07:53:57Z","receivedAt":"2010-02-25T07:53:57Z","isPatch":false,"sender":{"key":"giuseppe.bilotta@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1464?v=4"},"body":"On Wed, Feb 24, 2010 at 12:02 AM, Heiko Voigt wrote:\n> On Tue, Feb 23, 2010 at 11:54:40PM +0100, Giuseppe Bilotta wrote:\n>> On Tue, Feb 23, 2010 at 11:49 PM, Heiko Voigt wrote:\n> [...]\n>> > From 5c22c39d530ffb308826629d974048d30cd32e53 Mon Sep 17 00:00:00 2001\n>> > From: Heiko Voigt \n>> > Date: Tue, 23 Feb 2010 10:40:14 +0100\n>> > Subject: [PATCH 1/2] git-gui: fix usage of _gitworktree when creating shortcut for windows\n>> >\n>> > Signed-off-by: Heiko Voigt \n>> > ---\n>> >  git-gui/lib/shortcut.tcl |    2 +-\n>> >  1 files changed, 1 insertions(+), 1 deletions(-)\n>> >\n>> > diff --git a/git-gui/lib/shortcut.tcl b/git-gui/lib/shortcut.tcl\n>> > index 79c1888..8cad0e2 100644\n>> > --- a/git-gui/lib/shortcut.tcl\n>> > +++ b/git-gui/lib/shortcut.tcl\n>> > @@ -16,7 +16,7 @@ proc do_windows_shortcut {} {\n>> >                                        [info nameofexecutable] \\\n>> >                                        [file normalize $::argv0] \\\n>> >                                        ] \\\n>> > -                                       [file normalize [$_gitworktree]]\n>> > +                                       [file normalize $_gitworktree]\n>> >                        } err]} {\n>> >                        error_popup [strcat [mc \"Cannot write shortcut:\"] \"\\n\\n$err\"]\n>> >                }\n>>\n>> Ouch. Yes, I think your patch is obviously correct.\n>>\n>> (I'll go sit in a corner with my 'TCL Dunce' cap on for a while ...)\n>\n> No problem obviously nobody else saw this, but please test your patches\n> in the future. That could have avoided this one.\n\nYou're right, although finding a Windows installation on which to test\ngit is nontrivial for me. (I did mention this particular part was\nuntested when I submitted it.)\n\n> One thing which is missing from my patch is the cygwin part which, as I\n> saw from your original patch, has the same problem.\n\nAlso, I'm wondering: does the Windows part actually need a [file\nnativename $_gitworktree], or is this automatically handled by the\nshortcut creation code?\n\n\n-- \nGiuseppe \"Oblomov\" Bilotta\n"},{"id":"135846","messageId":"20100227204108.GA33000@book.hvoigt.net","threadId":"22778","inReplyTo":"cb7bb73a1002242353h739786bdlb2c57df3438f5b7f@mail.gmail.com","subject":"Re: Re: Re: git gui create desktop icon currently does not work","fromName":"Heiko Voigt","fromEmail":"hvoigt@hvoigt.net","sentAt":"2010-02-27T20:41:11Z","receivedAt":"2010-02-27T20:41:11Z","isPatch":false,"sender":{"key":"hvoigt@hvoigt.net","avatar":"https://avatars.githubusercontent.com/u/184958?v=4"},"body":"On Thu, Feb 25, 2010 at 08:53:57AM +0100, Giuseppe Bilotta wrote:\n> On Wed, Feb 24, 2010 at 12:02 AM, Heiko Voigt wrote:\n> > On Tue, Feb 23, 2010 at 11:54:40PM +0100, Giuseppe Bilotta wrote:\n> >> On Tue, Feb 23, 2010 at 11:49 PM, Heiko Voigt wrote:\n[...]\n> >> > -                                       [file normalize [$_gitworktree]]\n> >> > +                                       [file normalize $_gitworktree]\n> >> >                        } err]} {\n> >> >                        error_popup [strcat [mc \"Cannot write shortcut:\"] \"\\n\\n$err\"]\n> >> >                }\n> >>\n> >> Ouch. Yes, I think your patch is obviously correct.\n> >>\n> >> (I'll go sit in a corner with my 'TCL Dunce' cap on for a while ...)\n> >\n> > No problem obviously nobody else saw this, but please test your patches\n> > in the future. That could have avoided this one.\n> \n> You're right, although finding a Windows installation on which to test\n> git is nontrivial for me. (I did mention this particular part was\n> untested when I submitted it.)\n\nOk then we can not blame you. Maybe send such a patch to the msysgit\nmailinglist and me CC then we can test early.\n\n> > One thing which is missing from my patch is the cygwin part which, as I\n> > saw from your original patch, has the same problem.\n> \n> Also, I'm wondering: does the Windows part actually need a [file\n> nativename $_gitworktree], or is this automatically handled by the\n> shortcut creation code?\n\nI investigated further and it seems that the cygwin part needs it. I\nprepared a patchseries about this and some more issues I will send out\nshortly.\n\ncheers Heiko\n"},{"id":"135847","messageId":"20100227204549.GB33000@book.hvoigt.net","threadId":"22778","inReplyTo":"20100227204108.GA33000@book.hvoigt.net","subject":"[PATCH 1/3] git-gui: fix usage of _gitworktree when creating shortcut for windows","fromName":"Heiko Voigt","fromEmail":"hvoigt@hvoigt.net","sentAt":"2010-02-27T20:45:51Z","receivedAt":"2010-02-27T20:45:51Z","isPatch":true,"sender":{"key":"hvoigt@hvoigt.net","avatar":"https://avatars.githubusercontent.com/u/184958?v=4"},"body":"Signed-off-by: Heiko Voigt \n---\n git-gui/lib/shortcut.tcl | 4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/git-gui/lib/shortcut.tcl b/git-gui/lib/shortcut.tcl\nindex 79c1888..78878ef 100644\n--- a/git-gui/lib/shortcut.tcl\n+++ b/git-gui/lib/shortcut.tcl\n@@ -16,7 +16,7 @@ proc do_windows_shortcut {} {\n \t\t\t\t\t[info nameofexecutable] \\\n \t\t\t\t\t[file normalize $::argv0] \\\n \t\t\t\t\t] \\\n-\t\t\t\t\t[file normalize [$_gitworktree]]\n+\t\t\t\t\t[file normalize $_gitworktree]\n \t\t\t} err]} {\n \t\t\terror_popup [strcat [mc \"Cannot write shortcut:\"] \"\\n\\n$err\"]\n \t\t}\n@@ -57,7 +57,7 @@ proc do_cygwin_shortcut {} {\n \t\t\t\t\t$sh -c \\\n \t\t\t\t\t\"CHERE_INVOKING=1 source /etc/profile;[sq $me] &\" \\\n \t\t\t\t\t] \\\n-\t\t\t\t\t[file normalize [$_gitworktree]]\n+\t\t\t\t\t[file normalize $_gitworktree]\n \t\t\t} err]} {\n \t\t\terror_popup [strcat [mc \"Cannot write shortcut:\"] \"\\n\\n$err\"]\n \t\t}\n-- \n1.7.0.m5.rc3.5.g38df2\n"},{"id":"135848","messageId":"20100227204741.GC33000@book.hvoigt.net","threadId":"22778","inReplyTo":"20100227204549.GB33000@book.hvoigt.net","subject":"[PATCH 2/3] git-gui: fix PATH environment for mingw development environment","fromName":"Heiko Voigt","fromEmail":"hvoigt@hvoigt.net","sentAt":"2010-02-27T20:47:42Z","receivedAt":"2010-02-27T20:47:42Z","isPatch":true,"sender":{"key":"hvoigt@hvoigt.net","avatar":"https://avatars.githubusercontent.com/u/184958?v=4"},"body":"When creating a desktop shortcut from the gui the shortcut directly\nstarts wish with the git-gui script. In the msysgit development\nenvironment some dll's reside in the mingw/bin directory which causes\nthat git can not start because libiconv2.dll is not found.\n\nWhen using such a link the error is even more cryptic stating:\n\"child killed: unknown signal\"\n\nSigned-off-by: Heiko Voigt \n---\nI am not sure whether this is the most elegant solution, but making this\nwork would definitely ease the development workflow.\n\n git-gui/windows/git-gui.sh | 5 +++--\n 1 files changed, 3 insertions(+), 2 deletions(-)\n\ndiff --git a/git-gui/windows/git-gui.sh b/git-gui/windows/git-gui.sh\nindex 66bbb2f..b1845c5 100644\n--- a/git-gui/windows/git-gui.sh\n+++ b/git-gui/windows/git-gui.sh\n@@ -13,10 +13,11 @@ if { $argc >=2 && [lindex $argv 0] == \"--working-dir\" } {\n \tincr argc -2\n }\n \n-set bindir [file dirname \\\n+set basedir [file dirname \\\n [file dirname \\\n [file dirname [info script]]]]\n-set bindir [file join $bindir bin]\n+set bindir [file join $basedir bin]\n+set bindir \"$bindir;[file join $basedir mingw bin]\"\n regsub -all \";\" $bindir \"\\\\;\" bindir\n set env(PATH) \"$bindir;$env(PATH)\"\n unset bindir\n-- \n1.7.0.m5.rc3.5.g38df2\n"},{"id":"135849","messageId":"20100227204848.GD33000@book.hvoigt.net","threadId":"22778","inReplyTo":"20100227204549.GB33000@book.hvoigt.net","subject":"[PATCH 3/3] git-gui: fix shortcut creation on cygwin","fromName":"Heiko Voigt","fromEmail":"hvoigt@hvoigt.net","sentAt":"2010-02-27T20:48:48Z","receivedAt":"2010-02-27T20:48:48Z","isPatch":true,"sender":{"key":"hvoigt@hvoigt.net","avatar":"https://avatars.githubusercontent.com/u/184958?v=4"},"body":"When the user tried to create a desktop icon with git gui on cygwin\nwscript was complaining about an unknown option and displaying the\nnon-native path as such.\n\nSigned-off-by: Heiko Voigt \n---\n git-gui/lib/win32.tcl | 4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/git-gui/lib/win32.tcl b/git-gui/lib/win32.tcl\nindex d7f93d0..db91ab8 100644\n--- a/git-gui/lib/win32.tcl\n+++ b/git-gui/lib/win32.tcl\n@@ -18,9 +18,9 @@ proc win32_create_lnk {lnk_path lnk_exec lnk_dir} {\n \teval [list exec wscript.exe \\\n \t\t/E:jscript \\\n \t\t/nologo \\\n-\t\t[file join $oguilib win32_shortcut.js] \\\n+\t\t[file nativename [file join $oguilib win32_shortcut.js]] \\\n \t\t$lnk_path \\\n-\t\t[file join $oguilib git-gui.ico] \\\n+\t\t[file nativename [file join $oguilib git-gui.ico]] \\\n \t\t$lnk_dir \\\n \t\t$lnk_exec] $lnk_args\n }\n-- \n1.7.0.m5.rc3.5.g38df2\n"},{"id":"135858","messageId":"cb7bb73a1002271409n1968c771w6a39c5595a89a834@mail.gmail.com","threadId":"22778","inReplyTo":"20100227204108.GA33000@book.hvoigt.net","subject":"Re: Re: Re: git gui create desktop icon currently does not work","fromName":"Giuseppe Bilotta","fromEmail":"giuseppe.bilotta@gmail.com","sentAt":"2010-02-27T22:09:48Z","receivedAt":"2010-02-27T22:09:48Z","isPatch":false,"sender":{"key":"giuseppe.bilotta@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1464?v=4"},"body":"On Sat, Feb 27, 2010 at 9:41 PM, Heiko Voigt wrote:\n> On Thu, Feb 25, 2010 at 08:53:57AM +0100, Giuseppe Bilotta wrote:\n>> You're right, although finding a Windows installation on which to test\n>> git is nontrivial for me. (I did mention this particular part was\n>> untested when I submitted it.)\n>\n> Ok then we can not blame you. Maybe send such a patch to the msysgit\n> mailinglist and me CC then we can test early.\n\nI should have thought about posting to the msysgit mailing list\nmyself. I'll remember next time 8-)\n\n-- \nGiuseppe \"Oblomov\" Bilotta\n"},{"id":"135864","messageId":"a5b261831002271657n41ab0f37sc0af50d3a768bfd1@mail.gmail.com","threadId":"22778","inReplyTo":"20100227204741.GC33000@book.hvoigt.net","subject":"Re: [msysGit] [PATCH 2/3] git-gui: fix PATH environment for mingw development environment","fromName":"Pat Thoyts","fromEmail":"patthoyts@googlemail.com","sentAt":"2010-02-28T00:57:14Z","receivedAt":"2010-02-28T00:57:14Z","isPatch":true,"sender":{"key":"patthoyts@googlemail.com","avatar":"https://gravatar.com/avatar/2300f94d9f59174a551dbc71278ac2cb2489f56afda920a57e189ad9de0a3f92?d=mp&s=160"},"body":"On 27 February 2010 20:47, Heiko Voigt wrote:\n> When creating a desktop shortcut from the gui the shortcut directly\n> starts wish with the git-gui script. In the msysgit development\n> environment some dll's reside in the mingw/bin directory which causes\n> that git can not start because libiconv2.dll is not found.\n>\n> When using such a link the error is even more cryptic stating:\n> \"child killed: unknown signal\"\n>\n> Signed-off-by: Heiko Voigt \n> ---\n> I am not sure whether this is the most elegant solution, but making this\n> work would definitely ease the development workflow.\n>\n>  git-gui/windows/git-gui.sh |    5 +++--\n>  1 files changed, 3 insertions(+), 2 deletions(-)\n>\n> diff --git a/git-gui/windows/git-gui.sh b/git-gui/windows/git-gui.sh\n> index 66bbb2f..b1845c5 100644\n> --- a/git-gui/windows/git-gui.sh\n> +++ b/git-gui/windows/git-gui.sh\n> @@ -13,10 +13,11 @@ if { $argc >=2 && [lindex $argv 0] == \"--working-dir\" } {\n>        incr argc -2\n>  }\n>\n> -set bindir [file dirname \\\n> +set basedir [file dirname \\\n>             [file dirname \\\n>              [file dirname [info script]]]]\n> -set bindir [file join $bindir bin]\n> +set bindir [file join $basedir bin]\n> +set bindir \"$bindir;[file join $basedir mingw bin]\"\n>  regsub -all \";\" $bindir \"\\\\;\" bindir\n>  set env(PATH) \"$bindir;$env(PATH)\"\n>  unset bindir\n> --\n> 1.7.0.m5.rc3.5.g38df2\n\nI have not tried to test this - I use cmd shell all the time so I\nalways run this using 'git gui' which runs the git.cmd script in\nProgramFiles\\Git\\cmd or in the development environment in\nmsysgit\\cmd\\. It makes me wonder if the Windows shortcut shouldn;t be\npointing to the cmd script rather than to a tcl script like this as\nthe cmd script does some quite extensive environment setup. It assigns\nHOME if it is not set, extends the PATH to include the git\ninstallation locations, sets the PLINK_PROTOCOL and the codepages for\nthe console. Probably only the PATH and HOME fixups are necessary for\ngit-gui and in fact tcl's configuration of \"~\" in the path as HOME\nprobably deals with that too.\nThis is just for the development setup right? An installation of\nmsysGit doesn't have a mingw\\bin directory.\nPat Thoyts\n"},{"id":"135876","messageId":"20100228124645.GB35071@book.hvoigt.net","threadId":"22778","inReplyTo":"a5b261831002271657n41ab0f37sc0af50d3a768bfd1@mail.gmail.com","subject":"Re: Re: [PATCH 2/3] git-gui: fix PATH environment for mingw development environment","fromName":"Heiko Voigt","fromEmail":"hvoigt@hvoigt.net","sentAt":"2010-02-28T12:46:46Z","receivedAt":"2010-02-28T12:46:46Z","isPatch":true,"sender":{"key":"hvoigt@hvoigt.net","avatar":"https://avatars.githubusercontent.com/u/184958?v=4"},"body":"On Sun, Feb 28, 2010 at 12:57:14AM +0000, Pat Thoyts wrote:\n> On 27 February 2010 20:47, Heiko Voigt wrote:\n> > When creating a desktop shortcut from the gui the shortcut directly\n> > starts wish with the git-gui script. In the msysgit development\n> > environment some dll's reside in the mingw/bin directory which causes\n> > that git can not start because libiconv2.dll is not found.\n> >\n> > When using such a link the error is even more cryptic stating:\n> > \"child killed: unknown signal\"\n> >\n> > Signed-off-by: Heiko Voigt \n> > ---\n> > I am not sure whether this is the most elegant solution, but making this\n> > work would definitely ease the development workflow.\n[...]\n> > -set bindir [file dirname \\\n> > +set basedir [file dirname \\\n> >             [file dirname \\\n> >              [file dirname [info script]]]]\n> > -set bindir [file join $bindir bin]\n> > +set bindir [file join $basedir bin]\n> > +set bindir \"$bindir;[file join $basedir mingw bin]\"\n[...]\n\n> I have not tried to test this - I use cmd shell all the time so I\n> always run this using 'git gui' which runs the git.cmd script in\n> ProgramFiles\\Git\\cmd or in the development environment in\n> msysgit\\cmd\\. It makes me wonder if the Windows shortcut shouldn;t be\n> pointing to the cmd script rather than to a tcl script like this as\n> the cmd script does some quite extensive environment setup. It assigns\n> HOME if it is not set, extends the PATH to include the git\n> installation locations, sets the PLINK_PROTOCOL and the codepages for\n> the console.\n\nProblem here is that AFAIK the cmd script is part of msysgit and not\nupstream git which would break the desktop icon on cygwin. So this\nsolution seems to me the most unintrusive one because on cygwin (and\ninstalled msysgit) you just end up having one obsolete path in PATH.\nAnd the current heuristic does not always work. Depending on where you\nput your prefix variable in your make call you have to manually add to\nyour path. For example if you, like me, usually install git in your home\ndirectory.\n\nOf course if we had a way to tell where the dll's of git are stored that\nwould be a way nicer solution.\n\n> Probably only the PATH and HOME fixups are necessary for\n> git-gui and in fact tcl's configuration of \"~\" in the path as HOME\n> probably deals with that too.\n> This is just for the development setup right? An installation of\n> msysGit doesn't have a mingw\\bin directory.\n\nYes it is for development only. But we have this paths in other locations\nas well: For example I noticed that even the installation of msysgit has\n/mingw/bin in PATH (from etc/profile probably) when starting git bash.\n\nWe need something for the development setup. Otherwise testing bugfixes\nin this area becomes very tedious. And as stated above the error message\nyou get is way worse than my patch ;)\n\ncheers Heiko\n"},{"id":"136382","messageId":"alpine.DEB.1.00.1003081214410.7596@pacific.mpi-cbg.de","threadId":"22778","inReplyTo":"20100227204549.GB33000@book.hvoigt.net","subject":"Re: [PATCH 1/3] git-gui: fix usage of _gitworktree when creating shortcut for windows","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2010-03-08T11:17:39Z","receivedAt":"2010-03-08T11:17:39Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sat, 27 Feb 2010, Heiko Voigt wrote:\n\n> Signed-off-by: Heiko Voigt \n> ---\n\nI applied these three patches to 4msysgit.git (I was pretty surprised that \nthe faulty patch made it into 1.7.0.2, but then, even my comment about the \ncommit message style was met with unwillingness to change).\n\nThanks Heiko, for pre-emptively fixing msysGit issue 425!\n\nCiao,\nDscho\n"}]}