{"thread":{"id":"22728","subject":"[PATCH] documentation: update the \"Pushing changes to a public repository\" section","startedAt":"2010-02-19T16:45:09Z","lastAt":"2010-02-19T23:09:11Z","messageCount":2,"participants":["Elia Pinto","Santi Béjar"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"135094","messageId":"4df72b1a1002190845o2cbde92btb8804e2467ffda51@mail.gmail.com","threadId":"22728","inReplyTo":null,"subject":"[PATCH] documentation: update the \"Pushing changes to a public repository\" section","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2010-02-19T16:45:09Z","receivedAt":"2010-02-19T16:45:09Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"Extracted from git v1.7.0 Release Notes:\n\n* \"git push\" into a branch that is currently checked out (i.e. pointed at by\n   HEAD in a repository that is not bare) is refused by default.\n\nUpdate the user manual where necessary\n---\n Documentation/user-manual.txt |   12 ++++++++----\n 1 files changed, 8 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/user-manual.txt b/Documentation/user-manual.txt\nindex fe6fb72..0897839 100644\n--- a/Documentation/user-manual.txt\n+++ b/Documentation/user-manual.txt\n@@ -1963,10 +1963,14 @@ As with `git fetch`, `git push` will complain\nif this does not result in a\n handling this case.\n\n Note that the target of a \"push\" is normally a\n-<<def_bare_repository,bare>> repository.  You can also push to a\n-repository that has a checked-out working tree, but the working tree\n-will not be updated by the push.  This may lead to unexpected results if\n-the branch you push to is the currently checked-out branch!\n+<<def_bare_repository,bare>> repository.  Until the version 1.7 you could\n+also push to a repository that has a checked-out working tree,\n+but the working tree will not be updated by the push.  This might lead to\n+unexpected results if the branch you pushed to was the currently checked-out\n+branch! From 1.7.0 git push\" into a branch that is currently checked out\n+(i.e. pointed at by   HEAD in a repository that is not bare)\n+is refused by default.\n+\n\n As with `git fetch`, you may also set up configuration options to\n save typing; so, for example, after\n--\n1.6.6\n"},{"id":"135121","messageId":"adf1fd3d1002191509y60f4e411kfe2c0e8e580d4df9@mail.gmail.com","threadId":"22728","inReplyTo":"4df72b1a1002190845o2cbde92btb8804e2467ffda51@mail.gmail.com","subject":"Re: [PATCH] documentation: update the \"Pushing changes to a public repository\" section","fromName":"Santi Béjar","fromEmail":"santi@agolina.net","sentAt":"2010-02-19T23:09:11Z","receivedAt":"2010-02-19T23:09:11Z","isPatch":true,"sender":{"key":"santi@agolina.net","avatar":null},"body":"On Fri, Feb 19, 2010 at 5:45 PM, Elia Pinto <gitter.spiros@gmail.com> wrote:\n> Extracted from git v1.7.0 Release Notes:\n>\n> * \"git push\" into a branch that is currently checked out (i.e. pointed at by\n>   HEAD in a repository that is not bare) is refused by default.\n>\n> Update the user manual where necessary\n\nIt is a good change. I have some comments below, but I prefer when the\ndocs explain first the current behavior and afterwards, as a note or\nalike, the prior behavior. Like this?\n\n-repository that has a checked-out working tree, but the working tree\n-will not be updated by the push.  This may lead to unexpected results if\n-the branch you push to is the currently checked-out branch!\n+repository that has a checked-out working tree, but not into a branch that is\n+currently checked out (i.e. pointed at by HEAD in a repository that is not\n+bare), as it is refused by default. This is not allowed by default because\n+this may lead to unexpected results. Note that prior to the version 1.7 it was\n+allowed.\n\n> ---\n>  Documentation/user-manual.txt |   12 ++++++++----\n>  1 files changed, 8 insertions(+), 4 deletions(-)\n>\n> diff --git a/Documentation/user-manual.txt b/Documentation/user-manual.txt\n> index fe6fb72..0897839 100644\n> --- a/Documentation/user-manual.txt\n> +++ b/Documentation/user-manual.txt\n> @@ -1963,10 +1963,14 @@ As with `git fetch`, `git push` will complain\n> if this does not result in a\n>  handling this case.\n>\n>  Note that the target of a \"push\" is normally a\n> -<<def_bare_repository,bare>> repository.  You can also push to a\n> -repository that has a checked-out working tree, but the working tree\n> -will not be updated by the push.  This may lead to unexpected results if\n> -the branch you push to is the currently checked-out branch!\n> +<<def_bare_repository,bare>> repository.  Until the version 1.7 you could\n\nThis implies that in 1.7 you can.\n\n> +also push to a repository that has a checked-out working tree,\n> +but the working tree will not be updated by the push.  This might lead to\n> +unexpected results if the branch you pushed to was the currently checked-out\n> +branch! From 1.7.0 git push\" into a branch that is currently checked out\n\nMissing \".\n\n> +(i.e. pointed at by   HEAD in a repository that is not bare)\n> +is refused by default.\n> +\n\nThanks,\nSanti\n"}]}