{"thread":{"id":"22670","subject":"[PATCH] Skip t1300.70 and 71 on msysGit.","startedAt":"2010-02-15T23:14:28Z","lastAt":"2010-02-16T09:27:41Z","messageCount":2,"participants":["Pat Thoyts","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"134682","messageId":"87r5omghop.fsf@users.sourceforge.net","threadId":"22670","inReplyTo":null,"subject":"[PATCH] Skip t1300.70 and 71 on msysGit.","fromName":"Pat Thoyts","fromEmail":"patthoyts@users.sourceforge.net","sentAt":"2010-02-15T23:14:28Z","receivedAt":"2010-02-15T23:14:28Z","isPatch":true,"sender":{"key":"patthoyts@users.sourceforge.net","avatar":"https://avatars.githubusercontent.com/u/30739?v=4"},"body":"\nThese two tests fail on msysGit because /dev/null is an alias for nul on\nWindows and when reading the value back from git config the alias does\nnot match the real filename. Also the HOME environment variable has a\nunix-style path but git returns a native equivalent path for '~'.  As\nthese are platform-dependent equivalent results it seems simplest to\nskip the test entirely.\n\nSigned-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>\n---\n t/t1300-repo-config.sh |    6 +++---\n t/test-lib.sh          |    1 +\n 2 files changed, 4 insertions(+), 3 deletions(-)\n\ndiff --git a/t/t1300-repo-config.sh b/t/t1300-repo-config.sh\nindex f11f98c..90541a3 100755\n--- a/t/t1300-repo-config.sh\n+++ b/t/t1300-repo-config.sh\n@@ -701,7 +701,7 @@ cat >expect <<\\EOF\n \ttrailingtilde = foo~\n EOF\n \n-test_expect_success 'set --path' '\n+test_expect_success NONMINGW 'set --path' '\n \tgit config --path path.home \"~/\" &&\n \tgit config --path path.normal \"/dev/null\" &&\n \tgit config --path path.trailingtilde \"foo~\" &&\n@@ -713,14 +713,14 @@ $HOME/\n foo~\n EOF\n \n-test_expect_success 'get --path' '\n+test_expect_success NONMINGW 'get --path' '\n \tgit config --get --path path.home > result &&\n \tgit config --get --path path.normal >> result &&\n \tgit config --get --path path.trailingtilde >> result &&\n \ttest_cmp expect result\n '\n \n-rm .git/config\n+test_have_prereq NONMINGW && rm .git/config\n \n git config quote.leading \" test\"\n git config quote.ending \"test \"\ndiff --git a/t/test-lib.sh b/t/test-lib.sh\nindex afd3053..f6a1590 100644\n--- a/t/test-lib.sh\n+++ b/t/test-lib.sh\n@@ -776,6 +776,7 @@ case $(uname -s) in\n \ttest_set_prereq POSIXPERM\n \ttest_set_prereq BSLASHPSPEC\n \ttest_set_prereq EXECKEEPSPID\n+\ttest_set_prereq NONMINGW\n \t;;\n esac\n \n-- \n1.7.0.rc2.1438.gebbe6.dirty\n"},{"id":"134718","messageId":"alpine.DEB.1.00.1002161027040.20986@pacific.mpi-cbg.de","threadId":"22670","inReplyTo":"87r5omghop.fsf@users.sourceforge.net","subject":"Re: [msysGit] [PATCH] Skip t1300.70 and 71 on msysGit.","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2010-02-16T09:27:41Z","receivedAt":"2010-02-16T09:27:41Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Pat,\n\nOn Mon, 15 Feb 2010, Pat Thoyts wrote:\n\n> These two tests fail on msysGit because /dev/null is an alias for nul on \n> Windows and when reading the value back from git config the alias does \n> not match the real filename. Also the HOME environment variable has a \n> unix-style path but git returns a native equivalent path for '~'.  As \n> these are platform-dependent equivalent results it seems simplest to \n> skip the test entirely.\n> \n> Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>\n> ---\n\nCan you push this to 4msysgit's 'devel' branch?\n\nThank you,\nDscho\n"}]}