{"thread":{"id":"22553","subject":"Current stgit asks SMTP password for every patch","startedAt":"2010-02-07T02:18:30Z","lastAt":"2010-02-07T02:18:30Z","messageCount":1,"participants":["Pavel Roskin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"133845","messageId":"1265509110.10712.22.camel@mj","threadId":"22553","inReplyTo":null,"subject":"Current stgit asks SMTP password for every patch","fromName":"Pavel Roskin","fromEmail":"proski@gnu.org","sentAt":"2010-02-07T02:18:30Z","receivedAt":"2010-02-07T02:18:30Z","isPatch":false,"sender":{"key":"proski@gnu.org","avatar":null},"body":"Hello, Alex!\n\nI was unpleasantly surprised when the current STGit started asking me\nfor the SMTP password for every patch in the series:\n\n$ stg mail --to minicom ncurses-const..clobber\nChecking the validity of the patches ... done\nSending patch \"ncurses-const\" ... Please enter SMTP password: \ndone\nSending patch \"precision-int\" ... Please enter SMTP password: \ndone\nSending patch \"aliasing\" ... Please enter SMTP password: \ndone\nSending patch \"clobber\" ... Please enter SMTP password: \ndone\n\nThe code in __send_message_smtp() lacks any caching for the smtppassword\nvariable.  The code comes from your commit\n89d7ec43e0b25cc6cbc9feb044d7ce7048f224eb\nstg mail: Refactor __send_message and friends\n\nIdeally, asking for the password (as well as other verification of the\ne-mail credentials) should be done before \"Sending patch\" is shown, and\nbefore the cover letter if any.  That is, it should be in func() in\nstgit/commands/mail.py.\n\nBut I'll also be fine with a simple-minded password caching in\n__send_message_smtp().\n\n-- \nRegards,\nPavel Roskin\n"}]}