{"thread":{"id":"22452","subject":"[PATCH] rebase: don't invoke the pager for each commit summary","startedAt":"2010-01-30T16:23:37Z","lastAt":"2010-02-01T05:39:39Z","messageCount":5,"participants":["Markus Heidelberg","Johannes Schindelin","Stephen Boyd"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"133118","messageId":"1264868617-18547-1-git-send-email-markus.heidelberg@web.de","threadId":"22452","inReplyTo":null,"subject":"[PATCH] rebase: don't invoke the pager for each commit summary","fromName":"Markus Heidelberg","fromEmail":"markus.heidelberg@web.de","sentAt":"2010-01-30T16:23:37Z","receivedAt":"2010-01-30T16:23:37Z","isPatch":true,"sender":{"key":"markus.heidelberg@web.de","avatar":"https://avatars.githubusercontent.com/u/6334512?v=4"},"body":"This regression was introduced by commit 0aa958d (rebase: replace\nantiquated sed invocation, 2010-01-24), which changed the invocation of\n\"git rev-list | sed\" to \"git log\".\n\nIt can be reproduced by something like this:\n$ git rebase -s recursive origin/master\n\nSigned-off-by: Markus Heidelberg <markus.heidelberg@web.de>\n---\n git-rebase.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-rebase.sh b/git-rebase.sh\nindex b5d9178..fb4fef7 100755\n--- a/git-rebase.sh\n+++ b/git-rebase.sh\n@@ -86,7 +86,7 @@ continue_merge () {\n \t\tfi\n \tfi\n \ttest -z \"$GIT_QUIET\" &&\n-\tgit log --format=%s -1 \"$cmt\"\n+\tGIT_PAGER='' git log --format=%s -1 \"$cmt\"\n \n \tprev_head=`git rev-parse HEAD^0`\n \t# save the resulting commit so we can read-tree on it later\n-- \n1.7.0.rc0.71.g95b6e\n"},{"id":"133122","messageId":"201001301746.13620.markus.heidelberg@web.de","threadId":"22452","inReplyTo":"alpine.DEB.1.00.1001301746200.4985@pacific.mpi-cbg.de","subject":"Re: [PATCH] rebase: don't invoke the pager for each commit summary","fromName":"Markus Heidelberg","fromEmail":"markus.heidelberg@web.de","sentAt":"2010-01-30T16:46:13Z","receivedAt":"2010-01-30T16:46:13Z","isPatch":true,"sender":{"key":"markus.heidelberg@web.de","avatar":"https://avatars.githubusercontent.com/u/6334512?v=4"},"body":"Johannes Schindelin, 2010-01-30:\n> Hi,\n> \n> On Sat, 30 Jan 2010, Markus Heidelberg wrote:\n> \n> > diff --git a/git-rebase.sh b/git-rebase.sh\n> > index b5d9178..fb4fef7 100755\n> > --- a/git-rebase.sh\n> > +++ b/git-rebase.sh\n> > @@ -86,7 +86,7 @@ continue_merge () {\n> >  \t\tfi\n> >  \tfi\n> >  \ttest -z \"$GIT_QUIET\" &&\n> > -\tgit log --format=%s -1 \"$cmt\"\n> > +\tGIT_PAGER='' git log --format=%s -1 \"$cmt\"\n> \n> Would it not be better 'git --no-pager log [...]'?\n\nThat was my initial fix, but then I found this in line 519:\n\n        GIT_PAGER='' git diff --stat --summary \"$mb\" \"$onto\"\n\nand decided to keep consistency.\n\nDon't know.\n\nMarkus\n"},{"id":"133120","messageId":"alpine.DEB.1.00.1001301746200.4985@pacific.mpi-cbg.de","threadId":"22452","inReplyTo":"1264868617-18547-1-git-send-email-markus.heidelberg@web.de","subject":"Re: [PATCH] rebase: don't invoke the pager for each commit summary","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2010-01-30T16:47:11Z","receivedAt":"2010-01-30T16:47:11Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sat, 30 Jan 2010, Markus Heidelberg wrote:\n\n> diff --git a/git-rebase.sh b/git-rebase.sh\n> index b5d9178..fb4fef7 100755\n> --- a/git-rebase.sh\n> +++ b/git-rebase.sh\n> @@ -86,7 +86,7 @@ continue_merge () {\n>  \t\tfi\n>  \tfi\n>  \ttest -z \"$GIT_QUIET\" &&\n> -\tgit log --format=%s -1 \"$cmt\"\n> +\tGIT_PAGER='' git log --format=%s -1 \"$cmt\"\n\nWould it not be better 'git --no-pager log [...]'?\n\nCiao,\nDscho\n"},{"id":"133123","messageId":"201001301752.00804.markus.heidelberg@web.de","threadId":"22452","inReplyTo":"201001301746.13620.markus.heidelberg@web.de","subject":"Re: [PATCH] rebase: don't invoke the pager for each commit summary","fromName":"Markus Heidelberg","fromEmail":"markus.heidelberg@web.de","sentAt":"2010-01-30T16:52:00Z","receivedAt":"2010-01-30T16:52:00Z","isPatch":true,"sender":{"key":"markus.heidelberg@web.de","avatar":"https://avatars.githubusercontent.com/u/6334512?v=4"},"body":"Markus Heidelberg, 2010-01-30:\n> Johannes Schindelin, 2010-01-30:\n> > Date:\tSat, 30 Jan 2010 17:47:11 +0100 (CET)\n> Date:\tSat, 30 Jan 2010 17:46:13 +0100\n\nYou should adjust your clock :)\n\nMarkus\n"},{"id":"133221","messageId":"780e0a6b1001312139x1b91bed1q729766c4efde4060@mail.gmail.com","threadId":"22452","inReplyTo":"1264868617-18547-1-git-send-email-markus.heidelberg@web.de","subject":"Re: [PATCH] rebase: don't invoke the pager for each commit summary","fromName":"Stephen Boyd","fromEmail":"bebarino@gmail.com","sentAt":"2010-02-01T05:39:39Z","receivedAt":"2010-02-01T05:39:39Z","isPatch":true,"sender":{"key":"bebarino@gmail.com","avatar":"https://avatars.githubusercontent.com/u/38832?v=4"},"body":"On Sat, Jan 30, 2010 at 8:23 AM, Markus Heidelberg\n<markus.heidelberg@web.de> wrote:\n> This regression was introduced by commit 0aa958d (rebase: replace\n> antiquated sed invocation, 2010-01-24), which changed the invocation of\n> \"git rev-list | sed\" to \"git log\".\n>\n> It can be reproduced by something like this:\n> $ git rebase -s recursive origin/master\n>\n> Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>\n>\n\nThanks. Maybe you can use git show too instead of git log -1?\n"}]}