{"thread":{"id":"22447","subject":"[PATCH] builtin-name-rev.c: remove the remaining \"typedef struct rev_name\" from git.","startedAt":"2010-01-30T01:32:02Z","lastAt":"2010-01-30T07:53:16Z","messageCount":2,"participants":["Thiago Farina","Stephen Boyd"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"133061","messageId":"8678db190a73997c7bd757b9d78f0fa9e8721055.1264815015.git.tfransosi@gmail.com","threadId":"22447","inReplyTo":null,"subject":"[PATCH] builtin-name-rev.c: remove the remaining \"typedef struct rev_name\" from git.","fromName":"Thiago Farina","fromEmail":"tfransosi@gmail.com","sentAt":"2010-01-30T01:32:02Z","receivedAt":"2010-01-30T01:32:02Z","isPatch":true,"sender":{"key":"tfransosi@gmail.com","avatar":"https://avatars.githubusercontent.com/u/970071?v=4"},"body":"---\n builtin-name-rev.c |    6 +++---\n 1 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/builtin-name-rev.c b/builtin-name-rev.c\nindex 06a38ac..6416f72 100644\n--- a/builtin-name-rev.c\n+++ b/builtin-name-rev.c\n@@ -7,11 +7,11 @@\n \n #define CUTOFF_DATE_SLOP 86400 /* one day */\n \n-typedef struct rev_name {\n+struct rev_name {\n \tconst char *tip_name;\n \tint generation;\n \tint distance;\n-} rev_name;\n+};\n \n static long cutoff = LONG_MAX;\n \n@@ -43,7 +43,7 @@ static void name_rev(struct commit *commit,\n \t}\n \n \tif (name == NULL) {\n-\t\tname = xmalloc(sizeof(rev_name));\n+\t\tname = xmalloc(sizeof(struct rev_name));\n \t\tcommit->util = name;\n \t\tgoto copy_data;\n \t} else if (name->distance > distance) {\n-- \n1.6.6.1.436.gaba7d\n"},{"id":"133100","messageId":"4B63E56C.5000100@gmail.com","threadId":"22447","inReplyTo":"8678db190a73997c7bd757b9d78f0fa9e8721055.1264815015.git.tfransosi@gmail.com","subject":"Re: [PATCH] builtin-name-rev.c: remove the remaining \"typedef struct rev_name\" from git.","fromName":"Stephen Boyd","fromEmail":"bebarino@gmail.com","sentAt":"2010-01-30T07:53:16Z","receivedAt":"2010-01-30T07:53:16Z","isPatch":true,"sender":{"key":"bebarino@gmail.com","avatar":"https://avatars.githubusercontent.com/u/38832?v=4"},"body":"On 01/29/2010 05:32 PM, Thiago Farina wrote:\n> @@ -43,7 +43,7 @@ static void name_rev(struct commit *commit,\n>   \t}\n>\n>   \tif (name == NULL) {\n> -\t\tname = xmalloc(sizeof(rev_name));\n> +\t\tname = xmalloc(sizeof(struct rev_name));\n\nHow about sizeof(*name) instead? This way we don't have to change it \nwhen the type changes again.\n"}]}