{"thread":{"id":"22379","subject":"[PATCH] commit-tree: remove unused #define","startedAt":"2010-01-25T07:05:43Z","lastAt":"2010-01-25T09:17:50Z","messageCount":2,"participants":["Stephen Boyd","Daniel"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"132578","messageId":"1264403143-11320-1-git-send-email-bebarino@gmail.com","threadId":"22379","inReplyTo":null,"subject":"[PATCH] commit-tree: remove unused #define","fromName":"Stephen Boyd","fromEmail":"bebarino@gmail.com","sentAt":"2010-01-25T07:05:43Z","receivedAt":"2010-01-25T07:05:43Z","isPatch":true,"sender":{"key":"bebarino@gmail.com","avatar":"https://avatars.githubusercontent.com/u/38832?v=4"},"body":"---\n\nThe fixme looks very suspicious too...\n\n builtin-commit-tree.c |    2 --\n 1 files changed, 0 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin-commit-tree.c b/builtin-commit-tree.c\nindex ddcb7a4..90dac34 100644\n--- a/builtin-commit-tree.c\n+++ b/builtin-commit-tree.c\n@@ -9,8 +9,6 @@\n #include \"builtin.h\"\n #include \"utf8.h\"\n \n-#define BLOCKING (1ul << 14)\n-\n /*\n  * FIXME! Share the code with \"write-tree.c\"\n  */\n-- \n1.6.6.1.436.gaba7d\n"},{"id":"132582","messageId":"3b96b7e4.67f13727.4b5d61be.1391c@o2.pl","threadId":"22379","inReplyTo":"1264403143-11320-1-git-send-email-bebarino@gmail.com","subject":"Re: [PATCH] commit-tree: remove unused #define","fromName":"Daniel","fromEmail":"mjucde@o2.pl","sentAt":"2010-01-25T09:17:50Z","receivedAt":"2010-01-25T09:17:50Z","isPatch":true,"sender":{"key":"mjucde@o2.pl","avatar":null},"body":"> ---\n> \n> The fixme looks very suspicious too...\n\nAccording to git blame it belongs to the same revision as BLOCKING\n -- initial commit. So probably it can be removed with BLOCKING.\n\n> \n>  builtin-commit-tree.c |    2 --\n>  1 files changed, 0 insertions(+), 2 deletions(-)\n> \n> diff --git a/builtin-commit-tree.c b/builtin-commit-tree.c\n> index ddcb7a4..90dac34 100644\n> --- a/builtin-commit-tree.c\n> +++ b/builtin-commit-tree.c\n> @@ -9,8 +9,6 @@\n>  #include \"builtin.h\"\n>  #include \"utf8.h\"\n>  \n> -#define BLOCKING (1ul << 14)\n> -\n>  /*\n>   * FIXME! Share the code with \"write-tree.c\"\n>   */\n> -- \n> 1.6.6.1.436.gaba7d\n> \n\n-- Daniel\n"}]}