{"thread":{"id":"22366","subject":"[PATCH] Windows: Remove dependency on pthreadGC2.dll","startedAt":"2010-01-24T10:10:30Z","lastAt":"2010-01-24T19:03:33Z","messageCount":2,"participants":["Michael Lukashov","Johannes Sixt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"132529","messageId":"1264327830-4204-1-git-send-email-michael.lukashov@gmail.com","threadId":"22366","inReplyTo":null,"subject":"[PATCH] Windows: Remove dependency on pthreadGC2.dll","fromName":"Michael Lukashov","fromEmail":"michael.lukashov@gmail.com","sentAt":"2010-01-24T10:10:30Z","receivedAt":"2010-01-24T10:10:30Z","isPatch":true,"sender":{"key":"michael.lukashov@gmail.com","avatar":"https://avatars.githubusercontent.com/u/890439?v=4"},"body":"Commit 44626dc7 (MSVC: Windows-native implementation for subset\nof threads API, 2010-01-15) introduces builtin replacement of\npthreadGC2.dll functionality, thus we can completely drop\ndependency on this dll.\n\nSigned-off-by: Michael Lukashov <michael.lukashov@gmail.com>\n---\n Makefile |    4 +++-\n 1 files changed, 3 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex c0dbee2..af08c8f 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -994,6 +994,7 @@ ifeq ($(uname_S),Windows)\n \tCOMPAT_CFLAGS = -D__USE_MINGW_ACCESS -DNOGDI -DHAVE_STRING_H -DHAVE_ALLOCA_H -Icompat -Icompat/fnmatch -Icompat/regex -Icompat/fnmatch -Icompat/win32 -DSTRIP_EXTENSION=\\\".exe\\\"\n \tBASIC_LDFLAGS = -IGNORE:4217 -IGNORE:4049 -NOLOGO -SUBSYSTEM:CONSOLE -NODEFAULTLIB:MSVCRT.lib\n \tEXTLIBS = advapi32.lib shell32.lib wininet.lib ws2_32.lib\n+\tPTHREAD_LIBS =\n \tlib =\n ifndef DEBUG\n \tBASIC_CFLAGS += -GL -Os -MT\n@@ -1036,11 +1037,12 @@ ifneq (,$(findstring MINGW,$(uname_S)))\n \tNO_PYTHON = YesPlease\n \tBLK_SHA1 = YesPlease\n \tTHREADED_DELTA_SEARCH = YesPlease\n-\tCOMPAT_CFLAGS += -D__USE_MINGW_ACCESS -DNOGDI -Icompat -Icompat/fnmatch\n+\tCOMPAT_CFLAGS += -D__USE_MINGW_ACCESS -DNOGDI -Icompat -Icompat/fnmatch -Icompat/win32\n \tCOMPAT_CFLAGS += -DSTRIP_EXTENSION=\\\".exe\\\"\n \tCOMPAT_OBJS += compat/mingw.o compat/fnmatch/fnmatch.o compat/winansi.o \\\n \t\tcompat/win32/pthread.o\n \tEXTLIBS += -lws2_32\n+\tPTHREAD_LIBS =\n \tX = .exe\n ifneq (,$(wildcard ../THIS_IS_MSYSGIT))\n \thtmldir=doc/git/html/\n-- \n1.6.6.1599.gaed1a\n"},{"id":"132551","messageId":"201001242003.33703.j6t@kdbg.org","threadId":"22366","inReplyTo":"1264327830-4204-1-git-send-email-michael.lukashov@gmail.com","subject":"Re: [PATCH] Windows: Remove dependency on pthreadGC2.dll","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2010-01-24T19:03:33Z","receivedAt":"2010-01-24T19:03:33Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"On Sonntag, 24. Januar 2010, Michael Lukashov wrote:\n> Commit 44626dc7 (MSVC: Windows-native implementation for subset\n> of threads API, 2010-01-15) introduces builtin replacement of\n> pthreadGC2.dll functionality, thus we can completely drop\n> dependency on this dll.\n\nDuh! This means that when I tested above-mentioned patch, I actually was using \npthread.h from msysgit instead of compat/win32/pthread.h, and didn't test it \nat all (note: MinGW version; MSVC was fine because it had the right includes \nall the time). This patch passes the test suite and a 'git gc --aggressive':\n\nAcked-by: Johannes Sixt <j6t@kdbg.org>\n\n-- Hannes\n"}]}