{"thread":{"id":"22340","subject":"[PATCH] bash: don't offer remote transport helpers as subcommands","startedAt":"2010-01-22T10:54:51Z","lastAt":"2010-01-28T15:19:51Z","messageCount":2,"participants":["SZEDER Gábor","Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"132395","messageId":"1264157691-27187-1-git-send-email-szeder@ira.uka.de","threadId":"22340","inReplyTo":null,"subject":"[PATCH] bash: don't offer remote transport helpers as subcommands","fromName":"SZEDER Gábor","fromEmail":"szeder@ira.uka.de","sentAt":"2010-01-22T10:54:51Z","receivedAt":"2010-01-22T10:54:51Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"Since commits a2d725b7 (Use an external program to implement fetching\nwith curl, 2009-08-05) and c9e388bb (Make the\n\"traditionally-supported\" URLs a special case, 2009-09-03) remote\ntransport helpers like 'remote-ftp' and 'remote-curl' are offered by the\ncompletion script as available subcommands.  Not good, since they are\nhelpers, therefore should not be offered, so filter them out.\n\nSigned-off-by: SZEDER Gábor <szeder@ira.uka.de>\n---\n\nMaybe maint-worthy?  1.6.5 was the first release with this bug, but\nnobody complained since then.\n\n contrib/completion/git-completion.bash |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 9651720..7def62c 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -568,6 +568,7 @@ __git_list_porcelain_commands ()\n \t\tread-tree)        : plumbing;;\n \t\treceive-pack)     : plumbing;;\n \t\treflog)           : plumbing;;\n+\t\tremote-*)         : transport;;\n \t\trepo-config)      : deprecated;;\n \t\trerere)           : plumbing;;\n \t\trev-list)         : plumbing;;\n-- \n1.6.6.1.361.gc5121\n"},{"id":"132894","messageId":"20100128151951.GB20185@spearce.org","threadId":"22340","inReplyTo":"1264157691-27187-1-git-send-email-szeder@ira.uka.de","subject":"Re: [PATCH] bash: don't offer remote transport helpers as subcommands","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2010-01-28T15:19:51Z","receivedAt":"2010-01-28T15:19:51Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"SZEDER G??bor <szeder@ira.uka.de> wrote:\n> Since commits a2d725b7 (Use an external program to implement fetching\n> with curl, 2009-08-05) and c9e388bb (Make the\n> \"traditionally-supported\" URLs a special case, 2009-09-03) remote\n> transport helpers like 'remote-ftp' and 'remote-curl' are offered by the\n> completion script as available subcommands.  Not good, since they are\n> helpers, therefore should not be offered, so filter them out.\n> \n> Signed-off-by: SZEDER G??bor <szeder@ira.uka.de>\n> ---\n> \n> Maybe maint-worthy?  1.6.5 was the first release with this bug, but\n> nobody complained since then.\n\nYup, should be in maint.\n\nAcked-by: Shawn O. Pearce <spearce@spearce.org>\n \n>  contrib/completion/git-completion.bash |    1 +\n>  1 files changed, 1 insertions(+), 0 deletions(-)\n> \n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index 9651720..7def62c 100755\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -568,6 +568,7 @@ __git_list_porcelain_commands ()\n>  \t\tread-tree)        : plumbing;;\n>  \t\treceive-pack)     : plumbing;;\n>  \t\treflog)           : plumbing;;\n> +\t\tremote-*)         : transport;;\n>  \t\trepo-config)      : deprecated;;\n>  \t\trerere)           : plumbing;;\n>  \t\trev-list)         : plumbing;;\n> -- \n> 1.6.6.1.361.gc5121\n\n-- \nShawn.\n"}]}