{"thread":{"id":"22315","subject":"[PATCH 4/4] msvc: Add a definition of NORETURN compatible with msvc compiler","startedAt":"2010-01-20T19:45:12Z","lastAt":"2010-01-23T00:18:48Z","messageCount":4,"participants":["Ramsay Jones","Erik Faye-Lund","Sebastian Schuberth"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"132218","messageId":"4B575D48.9070508@ramsay1.demon.co.uk","threadId":"22315","inReplyTo":null,"subject":"[PATCH 4/4] msvc: Add a definition of NORETURN compatible with msvc compiler","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2010-01-20T19:45:12Z","receivedAt":"2010-01-20T19:45:12Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n\nI thought that Erik had already submitted this patch along with\nthose that resulted in commits a4f3131c and 18660bc9. However, I\ndon't seem to be able to find it anywhere! (maybe I only imagined\nit).\n\nIf you find Erik's patch, please apply that instead...\n\nATB,\nRamsay Jones\n\n git-compat-util.h |    3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)\n\ndiff --git a/git-compat-util.h b/git-compat-util.h\nindex 5c59687..6efea29 100644\n--- a/git-compat-util.h\n+++ b/git-compat-util.h\n@@ -177,6 +177,9 @@ extern char *gitbasename(char *);\n #ifdef __GNUC__\n #define NORETURN __attribute__((__noreturn__))\n #define NORETURN_PTR __attribute__((__noreturn__))\n+#elif defined(_MSC_VER)\n+#define NORETURN __declspec(noreturn)\n+#define NORETURN_PTR\n #else\n #define NORETURN\n #define NORETURN_PTR\n-- \n1.6.6\n"},{"id":"132232","messageId":"40aa078e1001201345p1cf9dfbbm651f1ba7244a340f@mail.gmail.com","threadId":"22315","inReplyTo":"4B575D48.9070508@ramsay1.demon.co.uk","subject":"Re: [PATCH 4/4] msvc: Add a definition of NORETURN compatible with msvc compiler","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@googlemail.com","sentAt":"2010-01-20T21:45:29Z","receivedAt":"2010-01-20T21:45:29Z","isPatch":true,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"On Wed, Jan 20, 2010 at 8:45 PM, Ramsay Jones\n<ramsay@ramsay1.demon.co.uk> wrote:\n>\n> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n> ---\n>\n> I thought that Erik had already submitted this patch along with\n> those that resulted in commits a4f3131c and 18660bc9. However, I\n> don't seem to be able to find it anywhere! (maybe I only imagined\n> it).\n>\n> If you find Erik's patch, please apply that instead...\n>\n\nI don't think I ever sent one - I haven't bothered to set up msvc for\ngit compilation, so I only did the preparation (and I think I sent a\ncomment about how it could be done).\n\nSo, thanks for following it up! :)\n\n-- \nErik \"kusma\" Faye-Lund\n"},{"id":"132420","messageId":"4B59FE06.5010506@ramsay1.demon.co.uk","threadId":"22315","inReplyTo":"40aa078e1001201345p1cf9dfbbm651f1ba7244a340f@mail.gmail.com","subject":"Re: [PATCH 4/4] msvc: Add a definition of NORETURN compatible with msvc compiler","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2010-01-22T19:35:34Z","receivedAt":"2010-01-22T19:35:34Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"Erik Faye-Lund wrote:\n> On Wed, Jan 20, 2010 at 8:45 PM, Ramsay Jones\n> <ramsay@ramsay1.demon.co.uk> wrote:\n>> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n>> ---\n>>\n>> I thought that Erik had already submitted this patch along with\n>> those that resulted in commits a4f3131c and 18660bc9. However, I\n>> don't seem to be able to find it anywhere! (maybe I only imagined\n>> it).\n>>\n>> If you find Erik's patch, please apply that instead...\n> \n> I don't think I ever sent one - I haven't bothered to set up msvc for\n> git compilation, so I only did the preparation (and I think I sent a\n> comment about how it could be done).\n\nAh, so maybe it's this comment that I (mis-)remembered then! (yeah, my\nmemory is not what it used to be ;-)). Thanks for doing the preparation\nwork!\n\nATB,\nRamsay Jones\n"},{"id":"132435","messageId":"4B5A4068.8010004@gmail.com","threadId":"22315","inReplyTo":"4B575D48.9070508@ramsay1.demon.co.uk","subject":"Re: [PATCH 4/4] msvc: Add a definition of NORETURN compatible with msvc compiler","fromName":"Sebastian Schuberth","fromEmail":"sschuberth@gmail.com","sentAt":"2010-01-23T00:18:48Z","receivedAt":"2010-01-23T00:18:48Z","isPatch":true,"sender":{"key":"sschuberth@gmail.com","avatar":"https://avatars.githubusercontent.com/u/349154?v=4"},"body":"On 20.01.2010 20:45, Ramsay Jones wrote:\n\n> Signed-off-by: Ramsay Jones<ramsay@ramsay1.demon.co.uk>\n\nAcked-by: Sebastian Schuberth <sschuberth@gmail.com>\n\n-- \nSebastian Schuberth\n"}]}