{"thread":{"id":"22190","subject":"[PATCH] Add `commit.signoff` configuration variable.","startedAt":"2010-01-13T03:36:44Z","lastAt":"2010-01-13T08:30:21Z","messageCount":3,"participants":["Steven Drake","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"131415","messageId":"alpine.LNX.2.00.1001131635510.16395@vqena.qenxr.bet.am","threadId":"22190","inReplyTo":null,"subject":"[PATCH] Add `commit.signoff` configuration variable.","fromName":"Steven Drake","fromEmail":"sdrake@xnet.co.nz","sentAt":"2010-01-13T03:36:44Z","receivedAt":"2010-01-13T03:36:44Z","isPatch":true,"sender":{"key":"sdrake@xnet.co.nz","avatar":null},"body":"Signed-off-by: Steven Drake <sdrake@xnet.co.nz>\n---\n Documentation/config.txt     |    4 ++++\n Documentation/git-commit.txt |    2 +-\n builtin-commit.c             |    4 ++++\n 3 files changed, 9 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex 23a965e..dd261cf 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -712,6 +712,10 @@ color.ui::\n \tterminal. When more specific variables of color.* are set, they always\n \ttake precedence over this setting. Defaults to false.\n \n+commit.signoff::\n+\tAdd Signed-off-by line by the committer at the end of the commit\n+\tlog message.\n+\n commit.template::\n \tSpecify a file to use as the template for new commit messages.\n \t\"{tilde}/\" is expanded to the value of `$HOME` and \"{tilde}user/\" to the\ndiff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt\nindex c97c151..5a977b6 100644\n--- a/Documentation/git-commit.txt\n+++ b/Documentation/git-commit.txt\n@@ -114,7 +114,7 @@ OPTIONS\n -s::\n --signoff::\n \tAdd Signed-off-by line by the committer at the end of the commit\n-\tlog message.\n+\tlog message. This overrides the `commit.signoff` configuration variable.\n \n -n::\n --no-verify::\ndiff --git a/builtin-commit.c b/builtin-commit.c\nindex 3dfcd77..db90e7a 100644\n--- a/builtin-commit.c\n+++ b/builtin-commit.c\n@@ -1093,6 +1093,10 @@ static int git_commit_config(const char *k, const char *v, void *cb)\n \n \tif (!strcmp(k, \"commit.template\"))\n \t\treturn git_config_pathname(&template_file, k, v);\n+\tif (!strcmp(k, \"commit.signoff\")) {\n+\t\tsignoff = git_config_bool(k, v);\n+\t\treturn 0;\n+\t}\n \n \treturn git_status_config(k, v, s);\n }\n-- \n1.6.4\n"},{"id":"131419","messageId":"alpine.LNX.2.00.1001131735520.22756@vqena.qenxr.bet.am","threadId":"22190","inReplyTo":"alpine.LNX.2.00.1001131635510.16395@vqena.qenxr.bet.am","subject":"Re: [PATCH] Add `commit.signoff` configuration variable.","fromName":"Steven Drake","fromEmail":"sdrake@xnet.co.nz","sentAt":"2010-01-13T04:36:08Z","receivedAt":"2010-01-13T04:36:08Z","isPatch":true,"sender":{"key":"sdrake@xnet.co.nz","avatar":null},"body":"On Wed, 13 Jan 2010, Steven Drake wrote:\n> Signed-off-by: Steven Drake <sdrake@xnet.co.nz>\n\nI ment to make a note with that patch that the commit message Signed-off-by\nwas added using using the `commit.signoff` feature.\n\n-- \nSteven\n  1: Linux - will work for fish.\n  2: The Linux penguin - looks stuffed to the brim with herring.\n  ( make your own conclusions )\n"},{"id":"131442","messageId":"7v1vhuquea.fsf@alter.siamese.dyndns.org","threadId":"22190","inReplyTo":"alpine.LNX.2.00.1001131635510.16395@vqena.qenxr.bet.am","subject":"Re: [PATCH] Add `commit.signoff` configuration variable.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-01-13T08:30:21Z","receivedAt":"2010-01-13T08:30:21Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"You need to defend this one better, in fact a *lot* better, than other\nones.  See\n\n  http://thread.gmane.org/gmane.comp.version-control.git/32503/focus=32522\n  http://thread.gmane.org/gmane.comp.version-control.git/103939/focus=104207\n\nfor starters.  Your justifications should address all the points raised in\nprevious threads.\n"}]}