{"thread":{"id":"22039","subject":"[PATCH] Documentation: commit: explain the non-meaning of S-o-b","startedAt":"2009-12-28T18:40:01Z","lastAt":"2009-12-29T07:54:15Z","messageCount":2,"participants":["Jan Krüger","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"130410","messageId":"20091228194001.7b4c68f4@perceptron","threadId":"22039","inReplyTo":null,"subject":"[PATCH] Documentation: commit: explain the non-meaning of S-o-b","fromName":"Jan Krüger","fromEmail":"jk@jk.gs","sentAt":"2009-12-28T18:40:01Z","receivedAt":"2009-12-28T18:40:01Z","isPatch":true,"sender":{"key":"jk@jk.gs","avatar":"https://avatars.githubusercontent.com/u/1774?v=4"},"body":"In the manpage for git commit, the option --signoff is mentioned but\nthere is no explanation of what it actually means. Add a brief hint that\nS-o-b doesn't have a pre-defined meaning.\n\nSigned-off-by: Jan Krüger <jk@jk.gs>\n---\nSemi-resend. Nobody commented on this when I first sent it in early\nDecember, so here it is again, with a slightly more verbose\nexplanation. The repetition is intentional.\n\n Documentation/git-commit.txt |    3 ++-\n 1 files changed, 2 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt\nindex d227cec..cae510b 100644\n--- a/Documentation/git-commit.txt\n+++ b/Documentation/git-commit.txt\n@@ -114,7 +114,10 @@ OPTIONS\n -s::\n --signoff::\n \tAdd Signed-off-by line by the committer at the end of the commit\n-\tlog message.\n+\tlog message. This line has no inherent meaning; it is up to the\n+\tpotential recipient of the commit to decide what it stands for.\n+\tIt is typically understood as an assurance by the committer that\n+\tthe commit conforms to the receiving project's commit guidelines.\n \n -n::\n --no-verify::\n-- \n1.6.5.3.171.ge36e\n"},{"id":"130438","messageId":"7voclimd08.fsf@alter.siamese.dyndns.org","threadId":"22039","inReplyTo":"20091228194001.7b4c68f4@perceptron","subject":"Re: [PATCH] Documentation: commit: explain the non-meaning of S-o-b","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-12-29T07:54:15Z","receivedAt":"2009-12-29T07:54:15Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jan Krüger <jk@jk.gs> writes:\n\n> In the manpage for git commit, the option --signoff is mentioned but\n> there is no explanation of what it actually means. Add a brief hint that\n> S-o-b doesn't have a pre-defined meaning.\n\nThe commands am, cherry-pick, commit, format-patch, and revert all share\nthe \"sign-off\" and they more or less deliberately refused to define what\nit means to sign-off a patch; as your patch says, it is up to the project\npolicy.\n\nconfig.txt gives a description for format.signoff option that is too\nspecific to git and the kernel, which I think is a mistake given the much\nwider audience we have these days.\n\nHow similar should the document for the \"sign-off\" options to these\ncommands be?  I am wondering if we should have the same description copied\nand pasted to all of them, or avoid repeating ourselves and instead have\nthem refer to a central place, perhaps somewhere in the Tutorial or the\nWorkflow document.\n\n\n> Signed-off-by: Jan Krüger <jk@jk.gs>\n> ---\n> Semi-resend. Nobody commented on this when I first sent it in early\n> December, so here it is again, with a slightly more verbose\n> explanation. The repetition is intentional.\n>\n>  Documentation/git-commit.txt |    3 ++-\n>  1 files changed, 2 insertions(+), 1 deletions(-)\n>\n> diff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt\n> index d227cec..cae510b 100644\n> --- a/Documentation/git-commit.txt\n> +++ b/Documentation/git-commit.txt\n> @@ -114,7 +114,10 @@ OPTIONS\n>  -s::\n>  --signoff::\n>  \tAdd Signed-off-by line by the committer at the end of the commit\n> -\tlog message.\n> +\tlog message. This line has no inherent meaning; it is up to the\n> +\tpotential recipient of the commit to decide what it stands for.\n> +\tIt is typically understood as an assurance by the committer that\n> +\tthe commit conforms to the receiving project's commit guidelines.\n>  \n>  -n::\n>  --no-verify::\n> -- \n> 1.6.5.3.171.ge36e\n"}]}