{"thread":{"id":"22005","subject":"[BUG REPORT] git-svn fails to create branches if ssh+svn gets used as protocol.","startedAt":"2009-12-22T09:53:52Z","lastAt":"2009-12-23T20:03:28Z","messageCount":4,"participants":["Florian Köberle","Eric Wong"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"130236","messageId":"4B309730.5070509@fkoeberle.de","threadId":"22005","inReplyTo":null,"subject":"[BUG REPORT] git-svn fails to create branches if ssh+svn gets used as protocol.","fromName":"Florian Köberle","fromEmail":"florian@fkoeberle.de","sentAt":"2009-12-22T09:53:52Z","receivedAt":"2009-12-22T09:53:52Z","isPatch":false,"sender":{"key":"florian@fkoeberle.de","avatar":null},"body":"Hello\n\nI haven't seen a link to a bug tracker so I am sending this bug report\nto the mailing list, I hope it's okay.\n\nIf you try to run\n$ git svn branch foo\nin a project using a svn+ssh url, you get the following error log:\n\nCopying svn+ssh://example.org/svn/project/trunk at r1000 to\nsvn+ssh://me@example.org/svn/project/branches/foo...\nTrying to use an unsupported feature: Source and dest appear not to be\nin the same repository (src: 'svn+ssh://example.org/svn/project/trunk';\ndst: 'svn+ssh://me@example.org/svn/project/branches/foo') at\n/home/florian/libexec/git-core/git-svn line 722\n\nIt fails as the username is missing in the source url. If you modify the\ngit-svn script and add the username it works. The bug can be reproduced\nwith git-svn version 1.6.5.7 (svn 1.5.1).\n\nBest regards,\nFlorian\n"},{"id":"130275","messageId":"20091223072500.GB4323@dcvr.yhbt.net","threadId":"22005","inReplyTo":"4B309730.5070509@fkoeberle.de","subject":"Re: [BUG REPORT] git-svn fails to create branches if ssh+svn gets used as protocol.","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2009-12-23T07:25:00Z","receivedAt":"2009-12-23T07:25:00Z","isPatch":false,"sender":{"key":"e@80x24.org","avatar":null},"body":"Florian Köberle wrote:\n> Hello\n> \n> I haven't seen a link to a bug tracker so I am sending this bug report\n> to the mailing list, I hope it's okay.\n\nHi Florian,\n\nThe mailing list is the bug tracker here :)\n\n> If you try to run\n> $ git svn branch foo\n> in a project using a svn+ssh url, you get the following error log:\n> \n> Copying svn+ssh://example.org/svn/project/trunk at r1000 to\n> svn+ssh://me@example.org/svn/project/branches/foo...\n> Trying to use an unsupported feature: Source and dest appear not to be\n> in the same repository (src: 'svn+ssh://example.org/svn/project/trunk';\n> dst: 'svn+ssh://me@example.org/svn/project/branches/foo') at\n> /home/florian/libexec/git-core/git-svn line 722\n> \n> It fails as the username is missing in the source url. If you modify the\n> git-svn script and add the username it works. The bug can be reproduced\n> with git-svn version 1.6.5.7 (svn 1.5.1).\n\nThanks for the info, the following patch should help.\n\nI rarely get around to testing against svn+ssh servers myself\n(and they don't appear too common compared to http/https).\n\nLet us know how it goes, thanks!\n\nFrom b2bc7e330209659c20d02ee0ba3785f9f59fd0b2 Mon Sep 17 00:00:00 2001\nFrom: Eric Wong \nDate: Tue, 22 Dec 2009 22:40:18 -0800\nSubject: [PATCH] git svn: branch/tag commands detect username in URLs\n\nSigned-off-by: Eric Wong \n---\n git-svn.perl | 3 ++-\n 1 files changed, 2 insertions(+), 1 deletions(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex dba0d12..650c9e5 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -663,7 +663,8 @@ sub cmd_branch {\n \t}\n \t$head ||= 'HEAD';\n \n-\tmy ($src, $rev, undef, $gs) = working_head_info($head);\n+\tmy (undef, $rev, undef, $gs) = working_head_info($head);\n+\tmy $src = $gs->full_url;\n \n \tmy $remote = Git::SVN::read_all_remotes()->{$gs->{repo_id}};\n \tmy $allglobs = $remote->{ $_tag ? 'tags' : 'branches' };\n-- \nEric Wong\n"},{"id":"130289","messageId":"4B326EE3.5060409@fkoeberle.de","threadId":"22005","inReplyTo":"20091223072500.GB4323@dcvr.yhbt.net","subject":"Re: [BUG REPORT] git-svn fails to create branches if ssh+svn gets used as protocol.","fromName":"Florian Köberle","fromEmail":"florian@fkoeberle.de","sentAt":"2009-12-23T19:26:27Z","receivedAt":"2009-12-23T19:26:27Z","isPatch":false,"sender":{"key":"florian@fkoeberle.de","avatar":null},"body":"Hello Eric,\n\nyour patch works great. I created successfully a branch on a svn+ssh://\nrepository using the patched git-svn.\n\nThank you for the patch and the fast reply. I hope the patch find it's\nway into the next release.\n\nBest regards,\nFlorian\n\n\n\nEric Wong wrote:\n> Florian Köberle wrote:\n> \n>> Hello\n>>\n>> I haven't seen a link to a bug tracker so I am sending this bug report\n>> to the mailing list, I hope it's okay.\n>> \n>\n> Hi Florian,\n>\n> The mailing list is the bug tracker here :)\n>\n> \n>> If you try to run\n>> $ git svn branch foo\n>> in a project using a svn+ssh url, you get the following error log:\n>>\n>> Copying svn+ssh://example.org/svn/project/trunk at r1000 to\n>> svn+ssh://me@example.org/svn/project/branches/foo...\n>> Trying to use an unsupported feature: Source and dest appear not to be\n>> in the same repository (src: 'svn+ssh://example.org/svn/project/trunk';\n>> dst: 'svn+ssh://me@example.org/svn/project/branches/foo') at\n>> /home/florian/libexec/git-core/git-svn line 722\n>>\n>> It fails as the username is missing in the source url. If you modify the\n>> git-svn script and add the username it works. The bug can be reproduced\n>> with git-svn version 1.6.5.7 (svn 1.5.1).\n>> \n>\n> Thanks for the info, the following patch should help.\n>\n> I rarely get around to testing against svn+ssh servers myself\n> (and they don't appear too common compared to http/https).\n>\n> Let us know how it goes, thanks!\n>\n> From b2bc7e330209659c20d02ee0ba3785f9f59fd0b2 Mon Sep 17 00:00:00 2001\n> From: Eric Wong \n> Date: Tue, 22 Dec 2009 22:40:18 -0800\n> Subject: [PATCH] git svn: branch/tag commands detect username in URLs\n>\n> Signed-off-by: Eric Wong \n> ---\n> git-svn.perl | 3 ++-\n> 1 files changed, 2 insertions(+), 1 deletions(-)\n>\n> diff --git a/git-svn.perl b/git-svn.perl\n> index dba0d12..650c9e5 100755\n> --- a/git-svn.perl\n> +++ b/git-svn.perl\n> @@ -663,7 +663,8 @@ sub cmd_branch {\n> \t}\n> \t$head ||= 'HEAD';\n> \n> -\tmy ($src, $rev, undef, $gs) = working_head_info($head);\n> +\tmy (undef, $rev, undef, $gs) = working_head_info($head);\n> +\tmy $src = $gs->full_url;\n> \n> \tmy $remote = Git::SVN::read_all_remotes()->{$gs->{repo_id}};\n> \tmy $allglobs = $remote->{ $_tag ? 'tags' : 'branches' };\n> \n"},{"id":"130291","messageId":"20091223200328.GA11521@dcvr.yhbt.net","threadId":"22005","inReplyTo":"4B326EE3.5060409@fkoeberle.de","subject":"Re: [BUG REPORT] git-svn fails to create branches if ssh+svn gets used as protocol.","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2009-12-23T20:03:28Z","receivedAt":"2009-12-23T20:03:28Z","isPatch":false,"sender":{"key":"e@80x24.org","avatar":null},"body":"Florian Köberle wrote:\n> Hello Eric,\n> \n> your patch works great. I created successfully a branch on a svn+ssh://\n> repository using the patched git-svn.\n> \n> Thank you for the patch and the fast reply. I hope the patch find it's\n> way into the next release.\n\nHi Florian, thanks for the report and testing the fix.\n\nI've just pushed the that commit and Robert's test for Junio to pull at\ngit://git.bogomips.org/git-svn\n\nEric Wong (1):\n git svn: branch/tag commands detect username in URLs\n\nRobert Zeh (1):\n git svn: add test for a git svn gc followed by a git svn mkdirs\n\n-- \nEric Wong\n"}]}