{"thread":{"id":"21987","subject":"Feature suggestion: support arguments for GIT_PROXY_COMMAND & core.gitproxy","startedAt":"2009-12-18T23:39:22Z","lastAt":"2009-12-30T11:05:57Z","messageCount":5,"participants":["Joey Korkames","Nanako Shiraishi","Junio C Hamano","Jeff King"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"130110","messageId":"cone.1261179562.490491.4033.1000@toolshiner.phx1.kidfixit.com","threadId":"21987","inReplyTo":null,"subject":"Feature suggestion: support arguments for GIT_PROXY_COMMAND & core.gitproxy","fromName":"Joey Korkames","fromEmail":"joey+floss@kidfixit.com","sentAt":"2009-12-18T23:39:22Z","receivedAt":"2009-12-18T23:39:22Z","isPatch":false,"sender":{"key":"joey+floss@kidfixit.com","avatar":null},"body":"Could /connect.c be patched to support multiple arguments in \nENV[GIT_PROXY_COMMAND] and git config core.gitproxy?\n\nFor instance, something like :\n  GIT_PROXY_COMMAND=\"myproxyscript arg1 arg2\"\n\nor (way more useful):\n git config core.gitproxy \\\n  '\"myproxyscript -mode git -proxy joey@gw.myhouse.com -proxy joey@bastion.foocorp.com\" for foocorp.com$'\n\nIts slightly annoying to maintain and distribute custom copies of myproxyscript \nthat carry the repo-specific proxy arguments inline just because git won't \npass those arguments itself (arguments that a repo's .git/config can easily \nstore).\n\nI think supporting tokens (ala ssh's ProxyCommand - %h=repohost, \n%p=repoport, %u=repouser) would be awesome, but that change would not be \nbackward-compatible with existing .git/config files or GIT_PROXY_COMMAND \nutilizing-scripts. Its enough to assume that \"$host $port\" will always be \nappended to the gitproxy arg list.\n\nThanks for reading, (and thnaks for git!)\n-joey\n"},{"id":"130112","messageId":"cone.1261184309.999283.4033.1000@toolshiner.phx1.kidfixit.com","threadId":"21987","inReplyTo":"cone.1261179562.490491.4033.1000@toolshiner.phx1.kidfixit.com","subject":"Re: Feature suggestion: support arguments for GIT_PROXY_COMMAND & core.gitproxy","fromName":"Joey Korkames","fromEmail":"joey+lists@kidfixit.com","sentAt":"2009-12-19T00:58:29Z","receivedAt":"2009-12-19T00:58:29Z","isPatch":false,"sender":{"key":"joey+lists@kidfixit.com","avatar":null},"body":"I forgot to mention that this all applies to ENV[GIT_SSH] as well, which \nhas no correspondgin git-config option, currently.\n\nI see there's some hardcoding of Tortoise and PuTTY's plink\nargument-handling in connect.c . I think a tokenable core.sshproxy option in \n~/.gitconfig would be way less hinky, IMHO.\n\nI just played with the man options in git config and I really liked how that \nworked; maybe that's a good part of the codebase to copy-paste from? I'm no \nC hacker, otherwise I'd be shutting up and sending a patch...\n\n-joey\n"},{"id":"130511","messageId":"20091230121329.6117@nanako3.lavabit.com","threadId":"21987","inReplyTo":"cone.1261179562.490491.4033.1000@toolshiner.phx1.kidfixit.com","subject":"Re: Feature suggestion: support arguments for GIT_PROXY_COMMAND & core.gitproxy","fromName":"Nanako Shiraishi","fromEmail":"nanako3@lavabit.com","sentAt":"2009-12-30T03:13:29Z","receivedAt":"2009-12-30T03:13:29Z","isPatch":false,"sender":{"key":"nanako3@lavabit.com","avatar":"https://gravatar.com/avatar/3777b9e201c5883a62b1a6fdf7c53f2d712d1d80989146063ea861e33aad72a8?d=mp&s=160"},"body":"Junio, could you tell us what happened to this thread?\n\nI think this is probably related to the \"textconv\" change.\n"},{"id":"130526","messageId":"7vmy1051ik.fsf@alter.siamese.dyndns.org","threadId":"21987","inReplyTo":"20091230121329.6117@nanako3.lavabit.com","subject":"Re: Feature suggestion: support arguments for GIT_PROXY_COMMAND & core.gitproxy","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-12-30T08:06:43Z","receivedAt":"2009-12-30T08:06:43Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Nanako Shiraishi <nanako3@lavabit.com> writes:\n\n> Junio, could you tell us what happened to this thread?\n>\n> I think this is probably related to the \"textconv\" change.\n\nYeah, you guessed right. I think the unified way to launch user specified\nprograms would come first and then spawning proxy the same way as others\nwould become trivial.\n"},{"id":"130544","messageId":"20091230110557.GG22959@coredump.intra.peff.net","threadId":"21987","inReplyTo":"7vmy1051ik.fsf@alter.siamese.dyndns.org","subject":"Re: Feature suggestion: support arguments for GIT_PROXY_COMMAND & core.gitproxy","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2009-12-30T11:05:57Z","receivedAt":"2009-12-30T11:05:57Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Dec 30, 2009 at 12:06:43AM -0800, Junio C Hamano wrote:\n\n> Nanako Shiraishi <nanako3@lavabit.com> writes:\n> \n> > Junio, could you tell us what happened to this thread?\n> >\n> > I think this is probably related to the \"textconv\" change.\n> \n> Yeah, you guessed right. I think the unified way to launch user specified\n> programs would come first and then spawning proxy the same way as others\n> would become trivial.\n\nAs a \"7/6\" on top of my other series, this should just be:\n\ndiff --git a/connect.c b/connect.c\nindex db965c9..838146c 100644\n--- a/connect.c\n+++ b/connect.c\n@@ -432,6 +432,7 @@ static void git_proxy_connect(int fd[2], char *host)\n \targv[2] = port;\n \targv[3] = NULL;\n \tmemset(&proxy, 0, sizeof(proxy));\n+\tproxy.use_shell = 1;\n \tproxy.argv = argv;\n \tproxy.in = -1;\n \tproxy.out = -1;\n\nBut I will leave it to somebody who actually uses the proxy feature to\ntest and submit a patch.\n\n-Peff\n"}]}