{"thread":{"id":"21911","subject":"[PATCH 2/2] git-svn: Move setting of svn.authorsfile in clone to between init and fetch","startedAt":"2009-12-08T20:54:10Z","lastAt":"2009-12-09T04:44:03Z","messageCount":3,"participants":["Alex Vandiver","Eric Wong"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"129577","messageId":"1260305651-11111-1-git-send-email-alex@chmrr.net","threadId":"21911","inReplyTo":null,"subject":"[PATCH 1/2] git-svn: Set svn.authorsfile to an absolute path when cloning","fromName":"Alex Vandiver","fromEmail":"alex@chmrr.net","sentAt":"2009-12-08T20:54:10Z","receivedAt":"2009-12-08T20:54:10Z","isPatch":true,"sender":{"key":"alex@chmrr.net","avatar":"https://avatars.githubusercontent.com/u/28347?v=4"},"body":"If --authors-file is passed a relative path, cloning will work, but\nfuture `git svn fetch`es will fail to locate the authors file\ncorrectly.  Thus, use File::Spec->rel2abs to determine an absolute\npath for the authors file before setting it.\n\nSigned-off-by: Alex Vandiver <alex@chmrr.net>\n---\n git-svn.perl |    4 +++-\n 1 files changed, 3 insertions(+), 1 deletions(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex 957d44e..cf5e75e 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -392,9 +392,11 @@ sub cmd_clone {\n \t\t$path = $url;\n \t}\n \t$path = basename($url) if !defined $path || !length $path;\n+\tmy $authors_absolute = $_authors ? File::Spec->rel2abs($_authors) : \"\";\n \tcmd_init($url, $path);\n \tGit::SVN::fetch_all($Git::SVN::default_repo_id);\n-\tcommand_oneline('config', 'svn.authorsfile', $_authors) if $_authors;\n+\tcommand_oneline('config', 'svn.authorsfile', $authors_absolute)\n+\t    if $_authors;\n }\n \n sub cmd_init {\n-- \n1.6.6.rc0.360.gc408\n"},{"id":"129576","messageId":"1260305651-11111-2-git-send-email-alex@chmrr.net","threadId":"21911","inReplyTo":"1260305651-11111-1-git-send-email-alex@chmrr.net","subject":"[PATCH 2/2] git-svn: Move setting of svn.authorsfile in clone to between init and fetch","fromName":"Alex Vandiver","fromEmail":"alex@chmrr.net","sentAt":"2009-12-08T20:54:11Z","receivedAt":"2009-12-08T20:54:11Z","isPatch":true,"sender":{"key":"alex@chmrr.net","avatar":"https://avatars.githubusercontent.com/u/28347?v=4"},"body":"If a clone errors out because of a missing author, or user interrupt,\nthis allows `git svn fetch` to resume seamlessly, rather than forcing\nthe user to re-provide the path to the authors file.\n\nSigned-off-by: Alex Vandiver <alex@chmrr.net>\n---\n git-svn.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex cf5e75e..3c3e0e0 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -394,9 +394,9 @@ sub cmd_clone {\n \t$path = basename($url) if !defined $path || !length $path;\n \tmy $authors_absolute = $_authors ? File::Spec->rel2abs($_authors) : \"\";\n \tcmd_init($url, $path);\n-\tGit::SVN::fetch_all($Git::SVN::default_repo_id);\n \tcommand_oneline('config', 'svn.authorsfile', $authors_absolute)\n \t    if $_authors;\n+\tGit::SVN::fetch_all($Git::SVN::default_repo_id);\n }\n \n sub cmd_init {\n-- \n1.6.6.rc0.360.gc408\n"},{"id":"129598","messageId":"20091209044403.GA22566@dcvr.yhbt.net","threadId":"21911","inReplyTo":"1260305651-11111-2-git-send-email-alex@chmrr.net","subject":"Re: [PATCH 2/2] git-svn: Move setting of svn.authorsfile in clone to between init and fetch","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2009-12-09T04:44:03Z","receivedAt":"2009-12-09T04:44:03Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Alex Vandiver <alex@chmrr.net> wrote:\n> If a clone errors out because of a missing author, or user interrupt,\n> this allows `git svn fetch` to resume seamlessly, rather than forcing\n> the user to re-provide the path to the authors file.\n\nThanks Alex,\n\nI shortened the subject on this one, acked the series and pushed to\ngit://git.bogomips.org/git-svn\n\nAlex Vandiver (2):\n      git-svn: Set svn.authorsfile to an absolute path when cloning\n      git-svn: set svn.authorsfile earlier when cloning\n\n-- \nEric Wong\n"}]}