{"thread":{"id":"21784","subject":"[PATCH] reset: add --quiet option","startedAt":"2009-11-29T10:58:10Z","lastAt":"2009-12-04T01:43:01Z","messageCount":9,"participants":["Felipe Contreras","Stephen Boyd","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"128678","messageId":"1259492290-21771-1-git-send-email-felipe.contreras@gmail.com","threadId":"21784","inReplyTo":null,"subject":"[PATCH] reset: add --quiet option","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2009-11-29T10:58:10Z","receivedAt":"2009-11-29T10:58:10Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"There's already -q, but --quiet is missing.\n\nSigned-off-by: Felipe Contreras \n---\n Documentation/git-reset.txt | 1 +\n builtin-reset.c | 2 +-\n 2 files changed, 2 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/git-reset.txt b/Documentation/git-reset.txt\nindex 2d27e40..9df6de2 100644\n--- a/Documentation/git-reset.txt\n+++ b/Documentation/git-reset.txt\n@@ -62,6 +62,7 @@ This means that `git reset -p` is the opposite of `git add -p` (see\n linkgit:git-add[1]).\n \n -q::\n+--quiet::\n \tBe quiet, only report errors.\n \n ::\ndiff --git a/builtin-reset.c b/builtin-reset.c\nindex 73e6022..c0127c4 100644\n--- a/builtin-reset.c\n+++ b/builtin-reset.c\n@@ -209,7 +209,7 @@ int cmd_reset(int argc, const char **argv, const char *prefix)\n \t\t\t\t\"reset HEAD, index and working tree\", HARD),\n \t\tOPT_SET_INT(0, \"merge\", &reset_type,\n \t\t\t\t\"reset HEAD, index and working tree\", MERGE),\n-\t\tOPT_BOOLEAN('q', NULL, &quiet,\n+\t\tOPT_BOOLEAN('q', \"quiet\", &quiet,\n \t\t\t\t\"disable showing new HEAD in hard reset and progress message\"),\n \t\tOPT_BOOLEAN('p', \"patch\", &patch_mode, \"select hunks interactively\"),\n \t\tOPT_END()\n-- \n1.6.6.rc0.63.g0471c\n"},{"id":"128710","messageId":"1259543939.5679.5.camel@swboyd-laptop","threadId":"21784","inReplyTo":"1259492290-21771-1-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH] reset: add --quiet option","fromName":"Stephen Boyd","fromEmail":"bebarino@gmail.com","sentAt":"2009-11-30T01:18:59Z","receivedAt":"2009-11-30T01:18:59Z","isPatch":true,"sender":{"key":"bebarino@gmail.com","avatar":"https://avatars.githubusercontent.com/u/38832?v=4"},"body":"On Sun, 2009-11-29 at 12:58 +0200, Felipe Contreras wrote:\n> diff --git a/builtin-reset.c b/builtin-reset.c\n> index 73e6022..c0127c4 100644\n> --- a/builtin-reset.c\n> +++ b/builtin-reset.c\n> @@ -209,7 +209,7 @@ int cmd_reset(int argc, const char **argv, const char *prefix)\n> \t\t\t\t\"reset HEAD, index and working tree\", HARD),\n> \t\tOPT_SET_INT(0, \"merge\", &reset_type,\n> \t\t\t\t\"reset HEAD, index and working tree\", MERGE),\n> -\t\tOPT_BOOLEAN('q', NULL, &quiet,\n> +\t\tOPT_BOOLEAN('q', \"quiet\", &quiet,\n> \t\t\t\t\"disable showing new HEAD in hard reset and progress message\"),\n> \t\tOPT_BOOLEAN('p', \"patch\", &patch_mode, \"select hunks interactively\"),\n> \t\tOPT_END()\n\nWhy not just OPT__QUIET? We lose the specific help string but it's\npossible that what quiet is silencing will change in the future.\n\nMaybe you could move the help string to the documentation if you want to\nsave it.\n"},{"id":"128732","messageId":"7vvdgsxyzk.fsf@alter.siamese.dyndns.org","threadId":"21784","inReplyTo":"1259543939.5679.5.camel@swboyd-laptop","subject":"Re: [PATCH] reset: add --quiet option","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-11-30T07:17:51Z","receivedAt":"2009-11-30T07:17:51Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Stephen Boyd writes:\n\n> Why not just OPT__QUIET?\n\nGood question. I was in no hurry to queue this, so Felipe has plenty time\nto respond.\n"},{"id":"128758","messageId":"94a0d4530911300219j51e21e2cwae17d4248400a345@mail.gmail.com","threadId":"21784","inReplyTo":"1259543939.5679.5.camel@swboyd-laptop","subject":"Re: [PATCH] reset: add --quiet option","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2009-11-30T10:19:27Z","receivedAt":"2009-11-30T10:19:27Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Mon, Nov 30, 2009 at 3:18 AM, Stephen Boyd wrote:\n> Why not just OPT__QUIET? We lose the specific help string but it's\n> possible that what quiet is silencing will change in the future.\n\nI thought somebody would complain about loosing that string. In any\ncase, first step is adding --query to 'git reset', second step is\nmoving all OPT_BOOLEAN('q' to OPT__QUIET; there are other commands\ndoing the same.\n\n-- \nFelipe Contreras\n"},{"id":"128812","messageId":"780e0a6b0911301345v42c2b22bs34092fb69b21a2a0@mail.gmail.com","threadId":"21784","inReplyTo":"94a0d4530911300219j51e21e2cwae17d4248400a345@mail.gmail.com","subject":"Re: [PATCH] reset: add --quiet option","fromName":"Stephen Boyd","fromEmail":"bebarino@gmail.com","sentAt":"2009-11-30T21:45:30Z","receivedAt":"2009-11-30T21:45:30Z","isPatch":true,"sender":{"key":"bebarino@gmail.com","avatar":"https://avatars.githubusercontent.com/u/38832?v=4"},"body":"On Mon, Nov 30, 2009 at 2:19 AM, Felipe Contreras\n wrote:\n> I thought somebody would complain about loosing that string. In any\n> case, first step is adding --query to 'git reset', second step is\n> moving all OPT_BOOLEAN('q' to OPT__QUIET; there are other commands\n> doing the same.\n>\n\nIf you're already touching the line why not just do it once? I agree a\nfollow-up patch to cover the other commands would be good.\n"},{"id":"129112","messageId":"94a0d4530912030133n7e2fbf2asfea6e3896980dc7c@mail.gmail.com","threadId":"21784","inReplyTo":"780e0a6b0911301345v42c2b22bs34092fb69b21a2a0@mail.gmail.com","subject":"Re: [PATCH] reset: add --quiet option","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2009-12-03T09:33:47Z","receivedAt":"2009-12-03T09:33:47Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Mon, Nov 30, 2009 at 11:45 PM, Stephen Boyd wrote:\n> If you're already touching the line why not just do it once? I agree a\n> follow-up patch to cover the other commands would be good.\n\nBecause the less trivial the patches, the less luck I have of getting\nthem applied :)\n\nAnyway, I sent a patch to use OPT__QUIET directly in two places.\n\n-- \nFelipe Contreras\n"},{"id":"129113","messageId":"1259833595.1491.1.camel@swboyd-laptop","threadId":"21784","inReplyTo":"94a0d4530912030133n7e2fbf2asfea6e3896980dc7c@mail.gmail.com","subject":"Re: [PATCH] reset: add --quiet option","fromName":"Stephen Boyd","fromEmail":"bebarino@gmail.com","sentAt":"2009-12-03T09:46:35Z","receivedAt":"2009-12-03T09:46:35Z","isPatch":true,"sender":{"key":"bebarino@gmail.com","avatar":"https://avatars.githubusercontent.com/u/38832?v=4"},"body":"On Thu, 2009-12-03 at 11:33 +0200, Felipe Contreras wrote:\n> On Mon, Nov 30, 2009 at 11:45 PM, Stephen Boyd wrote:\n> > If you're already touching the line why not just do it once? I agree a\n> > follow-up patch to cover the other commands would be good.\n> \n> Because the less trivial the patches, the less luck I have of getting\n> them applied :)\n\nHeh, still seems pretty trivial to me ;-)\n\n> \n> Anyway, I sent a patch to use OPT__QUIET directly in two places.\n> \n\nGreat. Thanks for making it more consistent.\n"},{"id":"129153","messageId":"7v7ht3zgaz.fsf@alter.siamese.dyndns.org","threadId":"21784","inReplyTo":"94a0d4530912030133n7e2fbf2asfea6e3896980dc7c@mail.gmail.com","subject":"Re: [PATCH] reset: add --quiet option","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-12-04T01:19:48Z","receivedAt":"2009-12-04T01:19:48Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Felipe Contreras writes:\n\n> On Mon, Nov 30, 2009 at 11:45 PM, Stephen Boyd wrote:\n>> If you're already touching the line why not just do it once? I agree a\n>> follow-up patch to cover the other commands would be good.\n>\n> Because the less trivial the patches, the less luck I have of getting\n> them applied :)\n\nWell, the name of the game is not \"let me have more commits under my name\nin a well known project\". It is \"let's work together to make the system\nbetter without stepping on each other's toes and without introducing\nunintended side effects\".\n\nI actually do not think it is the complexity that matters. It largely\ndepends on what other patches are in flight that may have interactions,\nand if the change is suitable for the phase of the cycle.\n\n> Anyway, I sent a patch to use OPT__QUIET directly in two places.\n\nYeah, I saw it and queued it to 'pu'. Thanks.\n\nWe _might_ want to think about doing something about the lossage of \"long\nmessages\" by this conversion, and we may end up updating OPT__QUIET() to\nallow its users supply messages that are more suitable than the default\none, but I do not want to see such a change to parse-options before 1.6.6\nhappens on the 'master' branch, as I do not have infinite mental\nbandwidth.\n"},{"id":"129154","messageId":"94a0d4530912031743j360fc891m4093e92ecd9a66d5@mail.gmail.com","threadId":"21784","inReplyTo":"7v7ht3zgaz.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] reset: add --quiet option","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2009-12-04T01:43:01Z","receivedAt":"2009-12-04T01:43:01Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Fri, Dec 4, 2009 at 3:19 AM, Junio C Hamano wrote:\n> Felipe Contreras writes:\n>> Because the less trivial the patches, the less luck I have of getting\n>> them applied :)\n>\n> Well, the name of the game is not \"let me have more commits under my name\n> in a well known project\".  It is \"let's work together to make the system\n> better without stepping on each other's toes and without introducing\n> unintended side effects\".\n\nExcept that different people have different opinions about what's\n\"better\", when it's OK to step on somebody else's toes, and what's an\nimportant side-effect.\n\n> I actually do not think it is the complexity that matters.  It largely\n> depends on what other patches are in flight that may have interactions,\n> and if the change is suitable for the phase of the cycle.\n\nAnd whether or not you consider the change desirable at all.\n\n-- \nFelipe Contreras\n"}]}