{"thread":{"id":"21725","subject":"[PATCH] t4014-format-patch: do not assume 'test' is available as non-builtin","startedAt":"2009-11-23T09:35:53Z","lastAt":"2009-11-23T09:35:53Z","messageCount":1,"participants":["Johannes Sixt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"128161","messageId":"4B0A5779.4050401@viscovery.net","threadId":"21725","inReplyTo":null,"subject":"[PATCH] t4014-format-patch: do not assume 'test' is available as non-builtin","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2009-11-23T09:35:53Z","receivedAt":"2009-11-23T09:35:53Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"From: Johannes Sixt <j6t@kdbg.org>\n\nOne test case used 'xargs test', which assumes that 'test' is available\nas external program. At least on MinGW it is not.\n\nMoreover, 'git format-patch' was invoked in a pipeline, but not as the\nlast command. Rewrite the test case to catch breakage in 'git format-patch'\nas well.\n\nSigned-off-by: Johannes Sixt <j6t@kdbg.org>\n---\n t/t4014-format-patch.sh |    6 ++----\n 1 files changed, 2 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh\nindex 5689d59..7f267f9 100755\n--- a/t/t4014-format-patch.sh\n+++ b/t/t4014-format-patch.sh\n@@ -549,9 +549,7 @@ test_expect_success 'options no longer allowed for format-patch' '\n \ttest_cmp expect.check output'\n\n test_expect_success 'format-patch --numstat should produce a patch' '\n-\tgit format-patch --numstat --stdout master..side |\n-\tgrep \"^diff --git a/\" |\n-\twc -l |\n-\txargs test 6 = '\n+\tgit format-patch --numstat --stdout master..side > output &&\n+\ttest 6 = $(grep \"^diff --git a/\" output | wc -l)'\n\n test_done\n-- \n1.6.6.rc0.1059.gdce25\n"}]}