{"thread":{"id":"21677","subject":"Name/documentation on git-log --full-diff is insufficient","startedAt":"2009-11-19T23:26:33Z","lastAt":"2009-11-20T14:19:00Z","messageCount":3,"participants":["Phil Miller","Miklos Vajna","Tim Henigan"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"127940","messageId":"81f018ac0911191526o1cfa8e56r79f8db33256a4e9c@mail.gmail.com","threadId":"21677","inReplyTo":null,"subject":"Name/documentation on git-log --full-diff is insufficient","fromName":"Phil Miller","fromEmail":"mille121@illinois.edu","sentAt":"2009-11-19T23:26:33Z","receivedAt":"2009-11-19T23:26:33Z","isPatch":false,"sender":{"key":"mille121@illinois.edu","avatar":"https://avatars.githubusercontent.com/u/126464?v=4"},"body":"I've been trying for a few days to figure out how to see all the files\ntouched in all the commits that changed a particular path. I just\ndiscovered that that 'git log --full-diff --stat path' gives me the\ncomplete list of files changed in the displayed commits, and not just\nthe files matching path. Reading the documentation, I figured that it\neither only applied when running 'git log -p' or that it implied the\n'-p', neither of which was desirable.\n\nThus, I'd suggest a couple potential improvements:\n1. Expand the manual text to clarify that --full-diff really means\n'tell me about all of the files in the commits that I see' regardless\nof what information (a list of files, a diffstat, or a full diff) is\nbeing printed about those files\n2. Add a synonym with a more general name. Something like --all-files\nwould be close to the mark, though there are probably other more\nsuitable names.\n\nPhil\n\nPS: I sent in a patch for git-cvsserver a week ago, and have seen no\nresponse or action on it. Is there something I should have done\ndifferently?\nhttp://article.gmane.org/gmane.comp.version-control.git/132789\n"},{"id":"128016","messageId":"20091120140138.GB23718@genesis.frugalware.org","threadId":"21677","inReplyTo":"81f018ac0911191526o1cfa8e56r79f8db33256a4e9c@mail.gmail.com","subject":"Re: Name/documentation on git-log --full-diff is insufficient","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2009-11-20T14:01:38Z","receivedAt":"2009-11-20T14:01:38Z","isPatch":false,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"On Thu, Nov 19, 2009 at 05:26:33PM -0600, Phil Miller <mille121@illinois.edu> wrote:\n> PS: I sent in a patch for git-cvsserver a week ago, and have seen no\n> response or action on it. Is there something I should have done\n> differently?\n\nFrom MaintNotes:\n\n\"If you sent a patch that you did not hear from anybody for three days,\nthat is a very good indication that it was dropped on the floor ---\nplease do not hesitate to remind me.\"\n"},{"id":"128017","messageId":"32c343770911200619i38009e2fy5067a301be3fc313@mail.gmail.com","threadId":"21677","inReplyTo":"20091120140138.GB23718@genesis.frugalware.org","subject":"Re: Name/documentation on git-log --full-diff is insufficient","fromName":"Tim Henigan","fromEmail":"tim.henigan@gmail.com","sentAt":"2009-11-20T14:19:00Z","receivedAt":"2009-11-20T14:19:00Z","isPatch":false,"sender":{"key":"tim.henigan@gmail.com","avatar":"https://avatars.githubusercontent.com/u/42022?v=4"},"body":"On Fri, Nov 20, 2009 at 9:01 AM, Miklos Vajna <vmiklos@frugalware.org> wrote:\n> On Thu, Nov 19, 2009 at 05:26:33PM -0600, Phil Miller <mille121@illinois.edu> wrote:\n>> PS: I sent in a patch for git-cvsserver a week ago, and have seen no\n>> response or action on it. Is there something I should have done\n>> differently?\n>\n> From MaintNotes:\n>\n> \"If you sent a patch that you did not hear from anybody for three days,\n> that is a very good indication that it was dropped on the floor ---\n> please do not hesitate to remind me.\"\n\n...also as noted in 'Documentation/SubmittingPatches':\n   - Patches should be placed inline in your email rather than attached.\n   - Patches should be addressed to both:\n       * gitster@pobox.com\n       * git@vger.kernel.org\n\nYou should also double-check your patch against the rest of the\nguidelines in 'SubmittingPatches', to be sure it will apply cleanly.\n"}]}