{"thread":{"id":"21655","subject":"[PATCH v2 2/2] gitk: add --no-replace-objects option","startedAt":"2009-11-18T06:50:59Z","lastAt":"2009-11-19T09:01:25Z","messageCount":2,"participants":["Christian Couder","Paul Mackerras"],"isPatch":true,"patchVersion":2,"patchTotal":2},"messages":[{"id":"127821","messageId":"20091118065100.4206.48820.chriscool@tuxfamily.org","threadId":"21655","inReplyTo":null,"subject":"[PATCH v2 2/2] gitk: add --no-replace-objects option","fromName":"Christian Couder","fromEmail":"chriscool@tuxfamily.org","sentAt":"2009-11-18T06:50:59Z","receivedAt":"2009-11-18T06:50:59Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"This option simply sets the GIT_NO_REPLACE_OBJECTS environment\nvariable, and that is enough to make gitk ignore replace refs.\n\nThe GIT_NO_REPLACE_OBJECTS is set to \"1\" instead of \"\" as it is\nsafer on some platforms, thanks to Johannes Sixt and Michael J\nGruber.\n\nTested-by: Michael J Gruber <git@drmicha.warpmail.net>\nSigned-off-by: Christian Couder <chriscool@tuxfamily.org>\n---\n gitk-git/gitk |    5 ++++-\n 1 files changed, 4 insertions(+), 1 deletions(-)\n\ndiff --git a/gitk-git/gitk b/gitk-git/gitk\nindex a0214b7..c586b93 100644\n--- a/gitk-git/gitk\n+++ b/gitk-git/gitk\n@@ -128,7 +128,7 @@ proc unmerged_files {files} {\n }\n \n proc parseviewargs {n arglist} {\n-    global vdatemode vmergeonly vflags vdflags vrevs vfiltered vorigargs\n+    global vdatemode vmergeonly vflags vdflags vrevs vfiltered vorigargs env\n \n     set vdatemode($n) 0\n     set vmergeonly($n) 0\n@@ -208,6 +208,9 @@ proc parseviewargs {n arglist} {\n \t\t# git rev-parse doesn't understand --merge\n \t\tlappend revargs --gitk-symmetric-diff-marker MERGE_HEAD...HEAD\n \t    }\n+\t    \"--no-replace-objects\" {\n+\t\tset env(GIT_NO_REPLACE_OBJECTS) \"1\"\n+\t    }\n \t    \"-*\" {\n \t\t# Other flag arguments including -<n>\n \t\tif {[string is digit -strict [string range $arg 1 end]]} {\n-- \n1.6.5.1.gaf97d\n"},{"id":"127890","messageId":"19205.2405.220888.736317@cargo.ozlabs.ibm.com","threadId":"21655","inReplyTo":"20091118065100.4206.48820.chriscool@tuxfamily.org","subject":"Re: [PATCH v2 2/2] gitk: add --no-replace-objects option","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2009-11-19T09:01:25Z","receivedAt":"2009-11-19T09:01:25Z","isPatch":true,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"Christian Couder writes:\n\n> This option simply sets the GIT_NO_REPLACE_OBJECTS environment\n> variable, and that is enough to make gitk ignore replace refs.\n\nFor the commit message, could you add a couple of lines telling us\nwhat replace refs are and why you might want gitk to ignore them?\n\nPaul.\n"}]}