{"thread":{"id":"21387","subject":"[PATCH 2/4] Makefile: merge two Cygwin configuration sections into one","startedAt":"2009-10-27T19:11:55Z","lastAt":"2009-11-03T07:46:28Z","messageCount":3,"participants":["Ramsay Jones","Johannes Sixt","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"126055","messageId":"4AE745FB.1060902@ramsay1.demon.co.uk","threadId":"21387","inReplyTo":null,"subject":"[PATCH 2/4] Makefile: merge two Cygwin configuration sections into one","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2009-10-27T19:11:55Z","receivedAt":"2009-10-27T19:11:55Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n\nI can't think of any potential problems with this... but I've\nadded Dmitry to the cc-list, since he appears to have added\nthe second cygwin section in adbc0b6b, just in case... ;-)\n\nATB,\nRamsay Jones\n\n Makefile |    6 ++----\n 1 files changed, 2 insertions(+), 4 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex fea237b..8e1cfc5 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -782,6 +782,8 @@ ifeq ($(uname_O),Cygwin)\n \tNO_MMAP = YesPlease\n \tNO_IPV6 = YesPlease\n \tX = .exe\n+\tCOMPAT_OBJS += compat/cygwin.o\n+\tUNRELIABLE_FSTAT = UnfortunatelyYes\n endif\n ifeq ($(uname_S),FreeBSD)\n \tNEEDS_LIBICONV = YesPlease\n@@ -891,10 +893,6 @@ ifeq ($(uname_S),HP-UX)\n \tNO_SYS_SELECT_H = YesPlease\n \tSNPRINTF_RETURNS_BOGUS = YesPlease\n endif\n-ifneq (,$(findstring CYGWIN,$(uname_S)))\n-\tCOMPAT_OBJS += compat/cygwin.o\n-\tUNRELIABLE_FSTAT = UnfortunatelyYes\n-endif\n ifdef MSVC\n \tGIT_VERSION := $(GIT_VERSION).MSVC\n \tpathsep = ;\n-- \n1.6.5\n"},{"id":"126627","messageId":"4AEFDA3F.2070405@viscovery.net","threadId":"21387","inReplyTo":"4AE745FB.1060902@ramsay1.demon.co.uk","subject":"Re: [PATCH 2/4] Makefile: merge two Cygwin configuration sections into one","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2009-11-03T07:22:39Z","receivedAt":"2009-11-03T07:22:39Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Ramsay Jones schrieb:\n> diff --git a/Makefile b/Makefile\n> index fea237b..8e1cfc5 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -782,6 +782,8 @@ ifeq ($(uname_O),Cygwin)\n>  \tNO_MMAP = YesPlease\n>  \tNO_IPV6 = YesPlease\n>  \tX = .exe\n> +\tCOMPAT_OBJS += compat/cygwin.o\n> +\tUNRELIABLE_FSTAT = UnfortunatelyYes\n>  endif\n>  ifeq ($(uname_S),FreeBSD)\n>  \tNEEDS_LIBICONV = YesPlease\n> @@ -891,10 +893,6 @@ ifeq ($(uname_S),HP-UX)\n>  \tNO_SYS_SELECT_H = YesPlease\n>  \tSNPRINTF_RETURNS_BOGUS = YesPlease\n>  endif\n> -ifneq (,$(findstring CYGWIN,$(uname_S)))\n> -\tCOMPAT_OBJS += compat/cygwin.o\n> -\tUNRELIABLE_FSTAT = UnfortunatelyYes\n> -endif\n>  ifdef MSVC\n>  \tGIT_VERSION := $(GIT_VERSION).MSVC\n>  \tpathsep = ;\n\nI think this an obviously good change even outside this series.\n\n-- Hannes\n"},{"id":"126632","messageId":"7vk4y8t5ij.fsf@alter.siamese.dyndns.org","threadId":"21387","inReplyTo":"4AEFDA3F.2070405@viscovery.net","subject":"Re: [PATCH 2/4] Makefile: merge two Cygwin configuration sections into one","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-11-03T07:46:28Z","receivedAt":"2009-11-03T07:46:28Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Sixt <j.sixt@viscovery.net> writes:\n\n> Ramsay Jones schrieb:\n>> diff --git a/Makefile b/Makefile\n>> index fea237b..8e1cfc5 100644\n>> --- a/Makefile\n>> +++ b/Makefile\n>> @@ -782,6 +782,8 @@ ifeq ($(uname_O),Cygwin)\n>>  \tNO_MMAP = YesPlease\n>>  \tNO_IPV6 = YesPlease\n>>  \tX = .exe\n>> +\tCOMPAT_OBJS += compat/cygwin.o\n>> +\tUNRELIABLE_FSTAT = UnfortunatelyYes\n>>  endif\n>>  ifeq ($(uname_S),FreeBSD)\n>>  \tNEEDS_LIBICONV = YesPlease\n>> @@ -891,10 +893,6 @@ ifeq ($(uname_S),HP-UX)\n>>  \tNO_SYS_SELECT_H = YesPlease\n>>  \tSNPRINTF_RETURNS_BOGUS = YesPlease\n>>  endif\n>> -ifneq (,$(findstring CYGWIN,$(uname_S)))\n>> -\tCOMPAT_OBJS += compat/cygwin.o\n>> -\tUNRELIABLE_FSTAT = UnfortunatelyYes\n>> -endif\n>>  ifdef MSVC\n>>  \tGIT_VERSION := $(GIT_VERSION).MSVC\n>>  \tpathsep = ;\n>\n> I think this an obviously good change even outside this series.\n\nThanks; I think this one makes sense.\n"}]}