{"thread":{"id":"21382","subject":"[PATCH] gitk: fix typo when diffing committed -> staged","startedAt":"2009-10-27T17:13:42Z","lastAt":"2009-11-03T11:32:42Z","messageCount":2,"participants":["Jens Lehmann","Paul Mackerras"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"126039","messageId":"4AE72A46.5040201@web.de","threadId":"21382","inReplyTo":null,"subject":"[PATCH] gitk: fix typo when diffing committed -> staged","fromName":"Jens Lehmann","fromEmail":"jens.lehmann@web.de","sentAt":"2009-10-27T17:13:42Z","receivedAt":"2009-10-27T17:13:42Z","isPatch":true,"sender":{"key":"jens.lehmann@web.de","avatar":"https://avatars.githubusercontent.com/u/135220?v=4"},"body":"When highlighting a commit, using the context menu over the staged changes\nand then selecting \"Diff this -> selected\" the diff was empty. The same\nhappened when highlighting the staged changes and using \"Diff selected ->\nthis\" over a commit.\n\nSigned-off-by: Jens Lehmann <Jens.Lehmann@web.de>\n---\n\nI became aware of this issue while testing the submodule patch sent\nearlier. Looks just like a copy & paste typo.\n\n gitk-git/gitk |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitk-git/gitk b/gitk-git/gitk\nindex a0214b7..8e892b3 100644\n--- a/gitk-git/gitk\n+++ b/gitk-git/gitk\n@@ -7224,7 +7224,7 @@ proc diffcmd {ids flags} {\n \tset cmd [concat | git diff-index --cached $flags]\n \tif {[llength $ids] > 1} {\n \t    # comparing index with specific revision\n-\t    if {$i == 0} {\n+\t    if {$j == 0} {\n \t\tlappend cmd -R [lindex $ids 1]\n \t    } else {\n \t\tlappend cmd [lindex $ids 0]\n-- \n1.6.5.2.181.gd6f41.dirty\n"},{"id":"126646","messageId":"19184.5338.488429.366571@cargo.ozlabs.ibm.com","threadId":"21382","inReplyTo":"4AE72A46.5040201@web.de","subject":"Re: [PATCH] gitk: fix typo when diffing committed -> staged","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2009-11-03T11:32:42Z","receivedAt":"2009-11-03T11:32:42Z","isPatch":true,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"Jens Lehmann writes:\n\n> When highlighting a commit, using the context menu over the staged changes\n> and then selecting \"Diff this -> selected\" the diff was empty. The same\n> happened when highlighting the staged changes and using \"Diff selected ->\n> this\" over a commit.\n> \n> Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>\n\nThanks, applied.\n\nPaul.\n"}]}