{"thread":{"id":"21378","subject":"[PATCH] help -i: properly error out if no info viewer can be found","startedAt":"2009-10-27T13:31:33Z","lastAt":"2009-10-28T07:18:05Z","messageCount":2,"participants":["Gerrit Pape","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"126012","messageId":"20091027133134.28975.qmail@34dfe9cde77152.315fe32.mid.smarden.org","threadId":"21378","inReplyTo":null,"subject":"[PATCH] help -i: properly error out if no info viewer can be found","fromName":"Gerrit Pape","fromEmail":"pape@smarden.org","sentAt":"2009-10-27T13:31:33Z","receivedAt":"2009-10-27T13:31:33Z","isPatch":true,"sender":{"key":"pape@smarden.org","avatar":"https://avatars.githubusercontent.com/u/143170252?v=4"},"body":"With this commit, git help -i <cmd> prints an error message and exits\nnon-zero instead of being silent and exit code 0.\n\nReported by Trent W. Buck through\n http://bugs.debian.org/537664\n\nSigned-off-by: Gerrit Pape <pape@smarden.org>\n---\n builtin-help.c |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/builtin-help.c b/builtin-help.c\nindex e1eba77..e1ade8e 100644\n--- a/builtin-help.c\n+++ b/builtin-help.c\n@@ -372,6 +372,7 @@ static void show_info_page(const char *git_cmd)\n \tconst char *page = cmd_to_page(git_cmd);\n \tsetenv(\"INFOPATH\", system_path(GIT_INFO_PATH), 1);\n \texeclp(\"info\", \"info\", \"gitman\", page, NULL);\n+\tdie(\"no info viewer handled the request\");\n }\n \n static void get_html_page_path(struct strbuf *page_path, const char *page)\n-- \n1.6.5.2\n"},{"id":"126096","messageId":"7vskd4t2aa.fsf@alter.siamese.dyndns.org","threadId":"21378","inReplyTo":"20091027133134.28975.qmail@34dfe9cde77152.315fe32.mid.smarden.org","subject":"Re: [PATCH] help -i: properly error out if no info viewer can be found","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-10-28T07:18:05Z","receivedAt":"2009-10-28T07:18:05Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.\n"}]}