{"thread":{"id":"21376","subject":"[PATCH] Do not try to remove directories when removing old links","startedAt":"2009-10-27T11:23:33Z","lastAt":"2009-10-28T07:19:45Z","messageCount":2,"participants":["Sebastian Schuberth","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"126004","messageId":"hc6l9h$fn6$1@ger.gmane.org","threadId":"21376","inReplyTo":null,"subject":"[PATCH] Do not try to remove directories when removing old links","fromName":"Sebastian Schuberth","fromEmail":"sschuberth@gmail.com","sentAt":"2009-10-27T11:23:33Z","receivedAt":"2009-10-27T11:23:33Z","isPatch":true,"sender":{"key":"sschuberth@gmail.com","avatar":"https://avatars.githubusercontent.com/u/349154?v=4"},"body":"When building Git with MSVC on Windows, directories named after the Git alias\nare created for the output files, e.g. there is a \"git-merge-index\" directory\nnext to the \"git-merge-index.exe\" executable in the build root. Previously,\n\"make all\" just checked if \"git-merge-index\" and \"git-merge-index.exe\" are the\nsame file, and if not, tried to remove \"git-merge-index\". This fails in the\ncase of \"git-merge-index\" being a directory, which is why this is checked now.\n\nSigned-off-by: Sebastian Schuberth <sschuberth@gmail.com>\n---\n Makefile |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 42b7d60..268aede 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1375,7 +1375,7 @@ SHELL = $(SHELL_PATH)\n \n all:: shell_compatibility_test $(ALL_PROGRAMS) $(BUILT_INS) $(OTHER_PROGRAMS) GIT-BUILD-OPTIONS\n ifneq (,$X)\n-\t$(QUIET_BUILT_IN)$(foreach p,$(patsubst %$X,%,$(filter %$X,$(ALL_PROGRAMS) $(BUILT_INS) git$X)), test '$p' -ef '$p$X' || $(RM) '$p';)\n+\t$(QUIET_BUILT_IN)$(foreach p,$(patsubst %$X,%,$(filter %$X,$(ALL_PROGRAMS) $(BUILT_INS) git$X)), test -d '$p' -o '$p' -ef '$p$X' || $(RM) '$p';)\n endif\n \n all::\n-- \n1.6.5.rc2.13.g1be2\n"},{"id":"126105","messageId":"7vd448rnn2.fsf@alter.siamese.dyndns.org","threadId":"21376","inReplyTo":"hc6l9h$fn6$1@ger.gmane.org","subject":"Re: [PATCH] Do not try to remove directories when removing old links","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-10-28T07:19:45Z","receivedAt":"2009-10-28T07:19:45Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.\n"}]}