{"thread":{"id":"21356","subject":"[PATCH] push: always load default config","startedAt":"2009-10-25T19:15:22Z","lastAt":"2009-10-25T19:15:22Z","messageCount":1,"participants":["Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"125914","messageId":"20091025191521.GA19014@sigio.peff.net","threadId":"21356","inReplyTo":null,"subject":"[PATCH] push: always load default config","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2009-10-25T19:15:22Z","receivedAt":"2009-10-25T19:15:22Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"This is needed because we want to use the\nadvice.pushnonfastforward variable.\n\nPreviously, we would load the config on demand only when we\nneeded to look at push.default.  Which meant that \"git push\"\nwould load it, but \"git push remote\" would not, leading to\ndiffering behavior.\n\nSigned-off-by: Jeff King <peff@peff.net>\n---\n builtin-push.c |    3 ++-\n 1 files changed, 2 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin-push.c b/builtin-push.c\nindex b5cd2cd..7338176 100644\n--- a/builtin-push.c\n+++ b/builtin-push.c\n@@ -66,7 +66,6 @@ static void setup_push_tracking(void)\n \n static void setup_default_push_refspecs(void)\n {\n-\tgit_config(git_default_config, NULL);\n \tswitch (push_default) {\n \tdefault:\n \tcase PUSH_DEFAULT_MATCHING:\n@@ -174,6 +173,8 @@ int cmd_push(int argc, const char **argv, const char *prefix)\n \tint rc;\n \tconst char *repo = NULL;\t/* default repository */\n \n+\tgit_config(git_default_config, NULL);\n+\n \tstruct option options[] = {\n \t\tOPT_BIT('q', \"quiet\", &flags, \"be quiet\", TRANSPORT_PUSH_QUIET),\n \t\tOPT_BIT('v', \"verbose\", &flags, \"be verbose\", TRANSPORT_PUSH_VERBOSE),\n-- \n1.6.4.2.269.g75194.dirty\n"}]}