{"thread":{"id":"2132","subject":"[PATCH] Fix cvsimport warning when called without --no-cvs-direct","startedAt":"2005-10-18T14:30:27Z","lastAt":"2005-10-18T14:30:27Z","messageCount":1,"participants":["Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"10206","messageId":"Pine.LNX.4.63.0510181630040.31297@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"2132","inReplyTo":null,"subject":"[PATCH] Fix cvsimport warning when called without --no-cvs-direct","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2005-10-18T14:30:27Z","receivedAt":"2005-10-18T14:30:27Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Perl was warning that $opt_p was undefined in that case.\n\nSigned-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>\n\n---\n\n git-cvsimport.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\napplies-to: ba55da41e2670b8728cf911ac7424bc1afeb6ce4\n8d4a03322860fcc79cd20b76cb91b2f549cf14fd\ndiff --git a/git-cvsimport.perl b/git-cvsimport.perl\nindex 0621dc3..bbb83fb 100755\n--- a/git-cvsimport.perl\n+++ b/git-cvsimport.perl\n@@ -487,7 +487,7 @@ unless($pid) {\n \tmy @opt;\n \t@opt = split(/,/,$opt_p) if defined $opt_p;\n \tunshift @opt, '-z', $opt_z if defined $opt_z;\n-\tunless ($opt_p =~ m/--no-cvs-direct/) {\n+\tunless (defined($opt_p) && $opt_p =~ m/--no-cvs-direct/) {\n \t\tpush @opt, '--cvs-direct';\n \t}\n \texec(\"cvsps\",@opt,\"-u\",\"-A\",'--root',$opt_d,$cvs_tree);\n---\n0.99.8.GIT\n"}]}