{"thread":{"id":"21233","subject":"[PATCH] gitweb: linkify author/committer names with search","startedAt":"2009-10-14T02:12:24Z","lastAt":"2009-10-16T04:14:59Z","messageCount":7,"participants":["Stephen Boyd","Junio C Hamano","Wincent Colaiuta","Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"124918","messageId":"1255486344-11891-1-git-send-email-bebarino@gmail.com","threadId":"21233","inReplyTo":null,"subject":"[PATCH] gitweb: linkify author/committer names with search","fromName":"Stephen Boyd","fromEmail":"bebarino@gmail.com","sentAt":"2009-10-14T02:12:24Z","receivedAt":"2009-10-14T02:12:24Z","isPatch":true,"sender":{"key":"bebarino@gmail.com","avatar":"https://avatars.githubusercontent.com/u/38832?v=4"},"body":"It's nice to search for an author by merely clicking on their name in\ngitweb. This is usually faster than selecting the name, copying the\nselection, pasting it into the search box, selecting between\nauthor/committer and then hitting enter.\n\nLinkify the avatar icon in log/shortlog view because the icon is directly\nadjacent to the name and thus more related. The same is not true\nwhen in commit/tag view where the icon is farther away.\n\nSigned-off-by: Stephen Boyd <bebarino@gmail.com>\n---\n\nThis is on top of Giuseppe's fix esc_param patch.\n\n gitweb/gitweb.css  |    1 +\n gitweb/gitweb.perl |   21 ++++++++++++++++-----\n 2 files changed, 17 insertions(+), 5 deletions(-)\n\ndiff --git a/gitweb/gitweb.css b/gitweb/gitweb.css\nindex 8f68fe3..e2cd9d7 100644\n--- a/gitweb/gitweb.css\n+++ b/gitweb/gitweb.css\n@@ -30,6 +30,7 @@ img.logo {\n \n img.avatar {\n \tvertical-align: middle;\n+\tborder-width: 0px;\n }\n \n div.page_header {\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 4b21ad2..bdf1037 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -1602,8 +1602,12 @@ sub format_author_html {\n \tmy $co = shift;\n \tmy $author = chop_and_escape_str($co->{'author_name'}, @_);\n \treturn \"<$tag class=\\\"author\\\">\" .\n-\t       git_get_avatar($co->{'author_email'}, -pad_after => 1) .\n-\t       $author . \"</$tag>\";\n+\t       $cgi->a({-href => href(action=>\"search\", hash=>$hash,\n+\t\t\tsearchtext=>$co->{'author_name'},\n+\t\t\tsearchtype=>\"author\"), class=>\"list\"},\n+\t\t\tgit_get_avatar($co->{'author_email'}, -pad_after => 1) .\n+\t\t\t$author) .\n+\t       \"</$tag>\";\n }\n \n # format git diff header line, i.e. \"diff --(git|combined|cc) ...\"\n@@ -3372,10 +3376,13 @@ sub git_print_authorship {\n \tmy $co = shift;\n \tmy %opts = @_;\n \tmy $tag = $opts{-tag} || 'div';\n+\tmy $author = $co->{'author_name'};\n \n \tmy %ad = parse_date($co->{'author_epoch'}, $co->{'author_tz'});\n \tprint \"<$tag class=\\\"author_date\\\">\" .\n-\t      esc_html($co->{'author_name'}) .\n+\t      $cgi->a({-href => href(action=>\"search\", searchtext=>$author,\n+\t\t      searchtype=>\"author\"), class=>\"list\"},\n+\t\t      esc_html($author)) .\n \t      \" [$ad{'rfc2822'}\";\n \tprint_local_time(%ad) if ($opts{-localtime});\n \tprint \"]\" . git_get_avatar($co->{'author_email'}, -pad_before => 1)\n@@ -3394,8 +3401,12 @@ sub git_print_authorship_rows {\n \t@people = ('author', 'committer') unless @people;\n \tforeach my $who (@people) {\n \t\tmy %wd = parse_date($co->{\"${who}_epoch\"}, $co->{\"${who}_tz\"});\n-\t\tprint \"<tr><td>$who</td><td>\" . esc_html($co->{$who}) . \"</td>\" .\n-\t\t      \"<td rowspan=\\\"2\\\">\" .\n+\t\tprint \"<tr><td>$who</td><td>\" .\n+\t\t      $cgi->a({-href => href(action=>\"search\",\n+\t\t\t       searchtext=>$co->{\"${who}_name\"},\n+\t\t\t       searchtype=>$who), class=>\"list\"},\n+\t\t\t       esc_html($co->{$who})) .\n+\t\t      \"</td><td rowspan=\\\"2\\\">\" .\n \t\t      git_get_avatar($co->{\"${who}_email\"}, -size => 'double') .\n \t\t      \"</td></tr>\\n\" .\n \t\t      \"<tr>\" .\n-- \n1.6.5.1.g75846.dirty\n"},{"id":"124951","messageId":"7v7huyfidb.fsf@alter.siamese.dyndns.org","threadId":"21233","inReplyTo":"1255486344-11891-1-git-send-email-bebarino@gmail.com","subject":"Re: [PATCH] gitweb: linkify author/committer names with search","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-10-14T09:13:36Z","receivedAt":"2009-10-14T09:13:36Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Stephen Boyd <bebarino@gmail.com> writes:\n\n> It's nice to search for an author by merely clicking on their name in\n> gitweb. This is usually faster than selecting the name, copying the\n> selection, pasting it into the search box, selecting between\n> author/committer and then hitting enter.\n>\n> Linkify the avatar icon in log/shortlog view because the icon is directly\n> adjacent to the name and thus more related. The same is not true\n> when in commit/tag view where the icon is farther away.\n>\n> Signed-off-by: Stephen Boyd <bebarino@gmail.com>\n> ---\n>\n> This is on top of Giuseppe's fix esc_param patch.\n>\n>  gitweb/gitweb.css  |    1 +\n>  gitweb/gitweb.perl |   21 ++++++++++++++++-----\n>  2 files changed, 17 insertions(+), 5 deletions(-)\n>\n> diff --git a/gitweb/gitweb.css b/gitweb/gitweb.css\n> index 8f68fe3..e2cd9d7 100644\n> --- a/gitweb/gitweb.css\n> +++ b/gitweb/gitweb.css\n> @@ -30,6 +30,7 @@ img.logo {\n>  \n>  img.avatar {\n>  \tvertical-align: middle;\n> +\tborder-width: 0px;\n>  }\n\nEven though it _might_ be a good thing to do, this looks an unrelated\nchange,\n\n>  div.page_header {\n> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> index 4b21ad2..bdf1037 100755\n> --- a/gitweb/gitweb.perl\n> +++ b/gitweb/gitweb.perl\n> @@ -1602,8 +1602,12 @@ sub format_author_html {\n>  \tmy $co = shift;\n>  \tmy $author = chop_and_escape_str($co->{'author_name'}, @_);\n>  \treturn \"<$tag class=\\\"author\\\">\" .\n> -\t       git_get_avatar($co->{'author_email'}, -pad_after => 1) .\n> -\t       $author . \"</$tag>\";\n> +\t       $cgi->a({-href => href(action=>\"search\", hash=>$hash,\n> +\t\t\tsearchtext=>$co->{'author_name'},\n> +\t\t\tsearchtype=>\"author\"), class=>\"list\"},\n> +\t\t\tgit_get_avatar($co->{'author_email'}, -pad_after => 1) .\n> +\t\t\t$author) .\n> +\t       \"</$tag>\";\n>  }\n>  \n>  # format git diff header line, i.e. \"diff --(git|combined|cc) ...\"\n> @@ -3372,10 +3376,13 @@ sub git_print_authorship {\n>  \tmy $co = shift;\n>  \tmy %opts = @_;\n>  \tmy $tag = $opts{-tag} || 'div';\n> +\tmy $author = $co->{'author_name'};\n>  \n>  \tmy %ad = parse_date($co->{'author_epoch'}, $co->{'author_tz'});\n>  \tprint \"<$tag class=\\\"author_date\\\">\" .\n> -\t      esc_html($co->{'author_name'}) .\n> +\t      $cgi->a({-href => href(action=>\"search\", searchtext=>$author,\n> +\t\t      searchtype=>\"author\"), class=>\"list\"},\n> +\t\t      esc_html($author)) .\n>  \t      \" [$ad{'rfc2822'}\";\n>  \tprint_local_time(%ad) if ($opts{-localtime});\n>  \tprint \"]\" . git_get_avatar($co->{'author_email'}, -pad_before => 1)\n> @@ -3394,8 +3401,12 @@ sub git_print_authorship_rows {\n>  \t@people = ('author', 'committer') unless @people;\n>  \tforeach my $who (@people) {\n>  \t\tmy %wd = parse_date($co->{\"${who}_epoch\"}, $co->{\"${who}_tz\"});\n> -\t\tprint \"<tr><td>$who</td><td>\" . esc_html($co->{$who}) . \"</td>\" .\n> -\t\t      \"<td rowspan=\\\"2\\\">\" .\n> +\t\tprint \"<tr><td>$who</td><td>\" .\n> +\t\t      $cgi->a({-href => href(action=>\"search\",\n> +\t\t\t       searchtext=>$co->{\"${who}_name\"},\n> +\t\t\t       searchtype=>$who), class=>\"list\"},\n> +\t\t\t       esc_html($co->{$who})) .\n> +\t\t      \"</td><td rowspan=\\\"2\\\">\" .\n>  \t\t      git_get_avatar($co->{\"${who}_email\"}, -size => 'double') .\n>  \t\t      \"</td></tr>\\n\" .\n>  \t\t      \"<tr>\" .\n> -- \n> 1.6.5.1.g75846.dirty\n"},{"id":"124990","messageId":"BB11D6A2-212D-4FDB-AFCC-B8BDC7ADB208@wincent.com","threadId":"21233","inReplyTo":"1255486344-11891-1-git-send-email-bebarino@gmail.com","subject":"Re: [PATCH] gitweb: linkify author/committer names with search","fromName":"Wincent Colaiuta","fromEmail":"win@wincent.com","sentAt":"2009-10-14T16:55:43Z","receivedAt":"2009-10-14T16:55:43Z","isPatch":true,"sender":{"key":"greg@hurrell.net","avatar":"https://avatars.githubusercontent.com/u/7074?v=4"},"body":"El 14/10/2009, a las 04:12, Stephen Boyd escribió:\n\n> It's nice to search for an author by merely clicking on their name in\n> gitweb. This is usually faster than selecting the name, copying the\n> selection, pasting it into the search box, selecting between\n> author/committer and then hitting enter.\n\nWhat about installs where search is turned off? (ie. with \"$feature \n{'search'}{'default'} = [undef];\" in gitweb.conf)\n\nCheers,\nWincent\n"},{"id":"125016","messageId":"1255551886-15496-1-git-send-email-bebarino@gmail.com","threadId":"21233","inReplyTo":"1255486344-11891-1-git-send-email-bebarino@gmail.com","subject":"[PATCHv2] gitweb: linkify author/committer names with search","fromName":"Stephen Boyd","fromEmail":"bebarino@gmail.com","sentAt":"2009-10-14T20:24:46Z","receivedAt":"2009-10-14T20:24:46Z","isPatch":false,"sender":{"key":"bebarino@gmail.com","avatar":"https://avatars.githubusercontent.com/u/38832?v=4"},"body":"It's nice to search for an author by merely clicking on their name in\ngitweb. This is usually faster than selecting the name, copying the\nselection, pasting it into the search box, selecting between\nauthor/committer and then hitting enter.\n\nLinkify the avatar icon in log/shortlog view because the icon is directly\nadjacent to the name and thus more related. The same is not true\nwhen in commit/tag view where the icon is farther away.\n\nSigned-off-by: Stephen Boyd <bebarino@gmail.com>\n---\n\nThis is based off next now that Giuseppe's patch is there.\n\nChanges since v1:\n\n * CSS hack has been cleaned up to only remove the link border from\n   avatar icons when actually linked.\n\n * Checking for search capability to avoid generating search links (Wincent)\n\n * Linking of name and email are separate in commit/commitdiff/tag views\n\nThe last one I figured I'd throw in because I'm doing it again.\n\n gitweb/gitweb.css  |    4 ++++\n gitweb/gitweb.perl |   33 ++++++++++++++++++++++++++++-----\n 2 files changed, 32 insertions(+), 5 deletions(-)\n\ndiff --git a/gitweb/gitweb.css b/gitweb/gitweb.css\nindex 8faa94e..50067f2 100644\n--- a/gitweb/gitweb.css\n+++ b/gitweb/gitweb.css\n@@ -32,6 +32,10 @@ img.avatar {\n \tvertical-align: middle;\n }\n \n+a.list img.avatar {\n+\tborder-style: none;\n+}\n+\n div.page_header {\n \theight: 25px;\n \tpadding: 8px;\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 0c71ee8..6325b97 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -1625,6 +1625,22 @@ sub git_get_avatar {\n \t}\n }\n \n+sub format_search_author {\n+\tmy $searchtext = shift;\n+\tmy $searchtype = shift;\n+\tmy $displaytext = shift;\n+\tmy $have_search = gitweb_check_feature('search');\n+\tif ($have_search) {\n+\t\treturn $cgi->a({-href => href(action=>\"search\", hash=>$hash,\n+\t\t\t\tsearchtext=>$searchtext,\n+\t\t\t\tsearchtype=>$searchtype), class=>\"list\"},\n+\t\t\t\t$displaytext);\n+\n+\t} else {\n+\t\treturn $displaytext;\n+\t}\n+}\n+\n # format the author name of the given commit with the given tag\n # the author name is chopped and escaped according to the other\n # optional parameters (see chop_str).\n@@ -1633,8 +1649,10 @@ sub format_author_html {\n \tmy $co = shift;\n \tmy $author = chop_and_escape_str($co->{'author_name'}, @_);\n \treturn \"<$tag class=\\\"author\\\">\" .\n-\t       git_get_avatar($co->{'author_email'}, -pad_after => 1) .\n-\t       $author . \"</$tag>\";\n+\t       format_search_author($co->{'author_name'}, \"author\",\n+\t\t       git_get_avatar($co->{'author_email'}, -pad_after => 1) .\n+\t\t       $author) .\n+\t       \"</$tag>\";\n }\n \n # format git diff header line, i.e. \"diff --(git|combined|cc) ...\"\n@@ -3433,10 +3451,11 @@ sub git_print_authorship {\n \tmy $co = shift;\n \tmy %opts = @_;\n \tmy $tag = $opts{-tag} || 'div';\n+\tmy $author = $co->{'author_name'};\n \n \tmy %ad = parse_date($co->{'author_epoch'}, $co->{'author_tz'});\n \tprint \"<$tag class=\\\"author_date\\\">\" .\n-\t      esc_html($co->{'author_name'}) .\n+\t      format_search_author($author, \"author\", esc_html($author)) .\n \t      \" [$ad{'rfc2822'}\";\n \tprint_local_time(%ad) if ($opts{-localtime});\n \tprint \"]\" . git_get_avatar($co->{'author_email'}, -pad_before => 1)\n@@ -3455,8 +3474,12 @@ sub git_print_authorship_rows {\n \t@people = ('author', 'committer') unless @people;\n \tforeach my $who (@people) {\n \t\tmy %wd = parse_date($co->{\"${who}_epoch\"}, $co->{\"${who}_tz\"});\n-\t\tprint \"<tr><td>$who</td><td>\" . esc_html($co->{$who}) . \"</td>\" .\n-\t\t      \"<td rowspan=\\\"2\\\">\" .\n+\t\tprint \"<tr><td>$who</td><td>\" .\n+\t\t      format_search_author($co->{\"${who}_name\"}, $who,\n+\t\t\t       esc_html($co->{\"${who}_name\"})) . \" \" .\n+\t\t      format_search_author($co->{\"${who}_email\"}, $who,\n+\t\t\t       esc_html(\"<\" . $co->{\"${who}_email\"} . \">\")) .\n+\t\t      \"</td><td rowspan=\\\"2\\\">\" .\n \t\t      git_get_avatar($co->{\"${who}_email\"}, -size => 'double') .\n \t\t      \"</td></tr>\\n\" .\n \t\t      \"<tr>\" .\n-- \n1.6.5.94.gcd2f3\n"},{"id":"125071","messageId":"200910151341.36520.jnareb@gmail.com","threadId":"21233","inReplyTo":"1255486344-11891-1-git-send-email-bebarino@gmail.com","subject":"Re: [PATCH] gitweb: linkify author/committer names with search","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2009-10-15T11:41:34Z","receivedAt":"2009-10-15T11:41:34Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On Wed, 14 Oct 2009, Stephen Boyd wrote:\n\n> It's nice to search for an author by merely clicking on their name in\n> gitweb. This is usually faster than selecting the name, copying the\n> selection, pasting it into the search box, selecting between\n> author/committer and then hitting enter.\n[...]\n\nI see that it can be useful.  But is this discoverable, and does this\ndo expected thing?  Most of links in gitweb lead to some view (page)\nthat is specific to link; other lead to anchor on same page.  Leading\nto search results can be unexpected.\n\nPerhaps title explaining what does such link does would help?  Or making\nstyle of this link distinct from other (dashed underline, dashed \nunderline on mouseover, double underline, different mouse cursor on\nmouseover, etc.)?\n\nJust my 2 eurocents.  Feel free to ignore my ramblings.\n\n-- \nJakub Narebski\nPoland\n"},{"id":"125093","messageId":"4AD76A4B.5000302@gmail.com","threadId":"21233","inReplyTo":"200910151341.36520.jnareb@gmail.com","subject":"Re: [PATCH] gitweb: linkify author/committer names with search","fromName":"Stephen Boyd","fromEmail":"bebarino@gmail.com","sentAt":"2009-10-15T18:30:35Z","receivedAt":"2009-10-15T18:30:35Z","isPatch":true,"sender":{"key":"bebarino@gmail.com","avatar":"https://avatars.githubusercontent.com/u/38832?v=4"},"body":"Jakub Narebski wrote:\n>\n> I see that it can be useful.  But is this discoverable, and does this\n> do expected thing?  Most of links in gitweb lead to some view (page)\n> that is specific to link; other lead to anchor on same page.  Leading\n> to search results can be unexpected.\n>\n> Perhaps title explaining what does such link does would help?  Or making\n> style of this link distinct from other (dashed underline, dashed \n> underline on mouseover, double underline, different mouse cursor on\n> mouseover, etc.)?\n\nA title sounds good. Something like \"List commits by $author\"? I'll try\nto write something up by tonight.\n"},{"id":"125134","messageId":"1255666499-14098-1-git-send-email-bebarino@gmail.com","threadId":"21233","inReplyTo":"1255486344-11891-1-git-send-email-bebarino@gmail.com","subject":"[PATCHv3] gitweb: linkify author/committer names with search","fromName":"Stephen Boyd","fromEmail":"bebarino@gmail.com","sentAt":"2009-10-16T04:14:59Z","receivedAt":"2009-10-16T04:14:59Z","isPatch":false,"sender":{"key":"bebarino@gmail.com","avatar":"https://avatars.githubusercontent.com/u/38832?v=4"},"body":"It's nice to search for an author by merely clicking on their name in\ngitweb. This is usually faster than selecting the name, copying the\nselection, pasting it into the search box, selecting between\nauthor/committer and then hitting enter.\n\nLinkify the avatar icon in log/shortlog view because the icon is directly\nadjacent to the name and thus more related. The same is not true\nwhen in commit/tag view where the icon is farther away.\n\nSigned-off-by: Stephen Boyd <bebarino@gmail.com>\n---\n\nChanges since v2:\n\n * Add a title to make it not so suprising before you click (Jakub)\n\nChanges since v1:\n\n * CSS hack has been cleaned up to only remove the link border from\n    avatar icons when actually linked.\n\n * Checking for search capability to avoid generating search links (Wincent)\n\n * Linking of name and email are separate in commit/commitdiff/tag views\n\n gitweb/gitweb.css  |    4 ++++\n gitweb/gitweb.perl |   40 +++++++++++++++++++++++++++++++++++-----\n 2 files changed, 39 insertions(+), 5 deletions(-)\n\ndiff --git a/gitweb/gitweb.css b/gitweb/gitweb.css\nindex 8faa94e..50067f2 100644\n--- a/gitweb/gitweb.css\n+++ b/gitweb/gitweb.css\n@@ -32,6 +32,10 @@ img.avatar {\n \tvertical-align: middle;\n }\n \n+a.list img.avatar {\n+\tborder-style: none;\n+}\n+\n div.page_header {\n \theight: 25px;\n \tpadding: 8px;\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 0c71ee8..63e18f4 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -1625,6 +1625,29 @@ sub git_get_avatar {\n \t}\n }\n \n+sub format_search_author {\n+\tmy ($author, $searchtype, $displaytext) = @_;\n+\tmy $have_search = gitweb_check_feature('search');\n+\n+\tif ($have_search) {\n+\t\tmy $performed = \"\";\n+\t\tif ($searchtype eq 'author') {\n+\t\t\t$performed = \"authored\";\n+\t\t} elsif ($searchtype eq 'committer') {\n+\t\t\t$performed = \"committed\";\n+\t\t}\n+\n+\t\treturn $cgi->a({-href => href(action=>\"search\", hash=>$hash,\n+\t\t\t\tsearchtext=>$author,\n+\t\t\t\tsearchtype=>$searchtype), class=>\"list\",\n+\t\t\t\ttitle=>\"Search for commits $performed by $author\"},\n+\t\t\t\t$displaytext);\n+\n+\t} else {\n+\t\treturn $displaytext;\n+\t}\n+}\n+\n # format the author name of the given commit with the given tag\n # the author name is chopped and escaped according to the other\n # optional parameters (see chop_str).\n@@ -1633,8 +1656,10 @@ sub format_author_html {\n \tmy $co = shift;\n \tmy $author = chop_and_escape_str($co->{'author_name'}, @_);\n \treturn \"<$tag class=\\\"author\\\">\" .\n-\t       git_get_avatar($co->{'author_email'}, -pad_after => 1) .\n-\t       $author . \"</$tag>\";\n+\t       format_search_author($co->{'author_name'}, \"author\",\n+\t\t       git_get_avatar($co->{'author_email'}, -pad_after => 1) .\n+\t\t       $author) .\n+\t       \"</$tag>\";\n }\n \n # format git diff header line, i.e. \"diff --(git|combined|cc) ...\"\n@@ -3433,10 +3458,11 @@ sub git_print_authorship {\n \tmy $co = shift;\n \tmy %opts = @_;\n \tmy $tag = $opts{-tag} || 'div';\n+\tmy $author = $co->{'author_name'};\n \n \tmy %ad = parse_date($co->{'author_epoch'}, $co->{'author_tz'});\n \tprint \"<$tag class=\\\"author_date\\\">\" .\n-\t      esc_html($co->{'author_name'}) .\n+\t      format_search_author($author, \"author\", esc_html($author)) .\n \t      \" [$ad{'rfc2822'}\";\n \tprint_local_time(%ad) if ($opts{-localtime});\n \tprint \"]\" . git_get_avatar($co->{'author_email'}, -pad_before => 1)\n@@ -3455,8 +3481,12 @@ sub git_print_authorship_rows {\n \t@people = ('author', 'committer') unless @people;\n \tforeach my $who (@people) {\n \t\tmy %wd = parse_date($co->{\"${who}_epoch\"}, $co->{\"${who}_tz\"});\n-\t\tprint \"<tr><td>$who</td><td>\" . esc_html($co->{$who}) . \"</td>\" .\n-\t\t      \"<td rowspan=\\\"2\\\">\" .\n+\t\tprint \"<tr><td>$who</td><td>\" .\n+\t\t      format_search_author($co->{\"${who}_name\"}, $who,\n+\t\t\t       esc_html($co->{\"${who}_name\"})) . \" \" .\n+\t\t      format_search_author($co->{\"${who}_email\"}, $who,\n+\t\t\t       esc_html(\"<\" . $co->{\"${who}_email\"} . \">\")) .\n+\t\t      \"</td><td rowspan=\\\"2\\\">\" .\n \t\t      git_get_avatar($co->{\"${who}_email\"}, -size => 'double') .\n \t\t      \"</td></tr>\\n\" .\n \t\t      \"<tr>\" .\n-- \n1.6.5.94.gb6c65\n"}]}