{"thread":{"id":"2120","subject":"Do you use \"git-apply --show-files\"?","startedAt":"2005-10-16T18:41:50Z","lastAt":"2005-10-17T00:45:24Z","messageCount":2,"participants":["Junio C Hamano","Linus Torvalds"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"10161","messageId":"7vek6lxq1d.fsf@assigned-by-dhcp.cox.net","threadId":"2120","inReplyTo":null,"subject":"Do you use \"git-apply --show-files\"?","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-10-16T18:41:50Z","receivedAt":"2005-10-16T18:41:50Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"As a part of \"funny pathname character\" updates, I was reviewing\n\"apply.c\" and have two questions on its \"--show-files\" flag.\n\n * Unlike other informational flags like --stat and --summary,\n   it does not turn off \"apply\".  Is it intentional? \n\n * Do you (or anybody else) use it, and if so how?\n\nThe current code in the proposed updates branch decodes the same\nC-style encoded pathnames GNU patch with proposed enhancements\nwould understand before applying patches, and when it needs to\nshow pathnames with --index-info, --stat, and --summary, it uses\nthe same encoded pathname to keep things on one line.\n\nI think --show-files should also do the same for consistency,\nbut before I update it I wanted to ask the above questions.  If\nnobody uses it, I can just ignore the issues and probably\nremove the flag.\n\nThe plan is to backport the git-apply change to the maint branch\nto do a 0.99.8e before updated git-diff-* hits the master\nbranch.  The only thing that would make a difference is embedded\nSP.  Currently they are not quoted, but they will be, like this:\n\n        : siamese; git diff\n        diff --git \"a/Read Me\" \"b/Read Me\"\n        index 3deac99..543a8f0 100644\n        --- \"a/Read Me\"\n        +++ \"b/Read Me\"\n        ...\n"},{"id":"10168","messageId":"Pine.LNX.4.64.0510161740000.23590@g5.osdl.org","threadId":"2120","inReplyTo":"7vek6lxq1d.fsf@assigned-by-dhcp.cox.net","subject":"Re: Do you use \"git-apply --show-files\"?","fromName":"Linus Torvalds","fromEmail":"torvalds@osdl.org","sentAt":"2005-10-17T00:45:24Z","receivedAt":"2005-10-17T00:45:24Z","isPatch":false,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\n\nOn Sun, 16 Oct 2005, Junio C Hamano wrote:\n>\n> As a part of \"funny pathname character\" updates, I was reviewing\n> \"apply.c\" and have two questions on its \"--show-files\" flag.\n> \n>  * Unlike other informational flags like --stat and --summary,\n>    it does not turn off \"apply\".  Is it intentional? \n> \n>  * Do you (or anybody else) use it, and if so how?\n\nAs far as I'm concerned, you can remove it.\n\nThe point of show-files was to have the index update be based on the files \nthat were updated, it I was originally not planning to updating the index \ndirectly in git-apply, but instead do something like\n\n\tfiles=$(git-apply --show-files)\n\tgit-update-cache --add --delete -- $files\n\nbut it turned out to be a lot easier to just update the index.\n\nSo just remove that flag, I doubt it has ever been used.\n\n\t\tLinus\n"}]}