{"thread":{"id":"21123","subject":"[PATCH] MSVC: Enable OpenSSL, and translate -lcrypto","startedAt":"2009-10-03T20:00:39Z","lastAt":"2009-10-03T20:17:48Z","messageCount":4,"participants":["Marius Storm-Olsen","Erik Faye-Lund"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"124185","messageId":"18cd41840910031300i32c74b15t74eb9eee23ff8469@mail.gmail.com","threadId":"21123","inReplyTo":null,"subject":"[PATCH] MSVC: Enable OpenSSL, and translate -lcrypto","fromName":"Marius Storm-Olsen","fromEmail":"mstormo@gmail.com","sentAt":"2009-10-03T20:00:39Z","receivedAt":"2009-10-03T20:00:39Z","isPatch":true,"sender":{"key":"mstormo@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1500?v=4"},"body":"\nWe don't use crypto, but rather require libeay32 and\nssleay32. handle it in both the Makefile msvc linker\nscript, and the buildsystem generator.\n\nSigned-off-by: Marius Storm-Olsen \n---\n Requires Erik Faye-Lund's MinGW patches for imap-send\n ontop of git.git master.\n\n This patch was actually sent using the MSVC\n git-imap-send.exe to my GMail account.\n D:\\msvc\\git>cat\n0001-MSVC-Enable-OpenSSL-and-translate-lcrypto.patch |\ngit-imap-send.exe\n Resolving imap.gmail.com... ok\n Connecting to 74.125.79.109:993... ok\n Logging in...\n sending 1 message\n 100% (1/1) done\n :)\n\n Makefile | 1 -\n compat/vcbuild/scripts/clink.pl | 3 +++\n contrib/buildsystems/engine.pl | 3 +++\n 3 files changed, 6 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 8818f0f..c4b91d8 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -881,7 +881,6 @@ ifdef MSVC\n \tGIT_VERSION := $(GIT_VERSION).MSVC\n \tpathsep = ;\n \tNO_PREAD = YesPlease\n-\tNO_OPENSSL = YesPlease\n \tNO_LIBGEN_H = YesPlease\n \tNO_SYMLINK_HEAD = YesPlease\n \tNO_IPV6 = YesPlease\ndiff --git a/compat/vcbuild/scripts/clink.pl b/compat/vcbuild/scripts/clink.pl\nindex 0ffd59f..fce1e24 100644\n--- a/compat/vcbuild/scripts/clink.pl\n+++ b/compat/vcbuild/scripts/clink.pl\n@@ -29,6 +29,9 @@ while (@ARGV) {\n \t\tpush(@args, \"zlib.lib\");\n \t} elsif (\"$arg\" eq \"-liconv\") {\n \t\tpush(@args, \"iconv.lib\");\n+\t} elsif (\"$arg\" eq \"-lcrypto\") {\n+\t\tpush(@args, \"libeay32.lib\");\n+\t\tpush(@args, \"ssleay32.lib\");\n \t} elsif (\"$arg\" =~ /^-L/ && \"$arg\" ne \"-LTCG\") {\n \t\t$arg =~ s/^-L/-LIBPATH:/;\n \t\tpush(@args, $arg);\ndiff --git a/contrib/buildsystems/engine.pl b/contrib/buildsystems/engine.pl\nindex 20bd061..d506717 100644\n--- a/contrib/buildsystems/engine.pl\n+++ b/contrib/buildsystems/engine.pl\n@@ -315,6 +315,9 @@ sub handleLinkLine\n $appout = shift @parts;\n } elsif (\"$part\" eq \"-lz\") {\n push(@libs, \"zlib.lib\");\n+\t} elsif (\"$part\" eq \"-lcrypto\") {\n+ push(@libs, \"libeay32.lib\");\n+ push(@libs, \"ssleay32.lib\");\n } elsif ($part =~ /^-/) {\n push(@lflags, $part);\n } elsif ($part =~ /\\.(a|lib)$/) {\n-- \n1.6.3.msysgit.0.18.gef407\n"},{"id":"124186","messageId":"40aa078e0910031305u38cfaf4aua72d4c7af2a470b2@mail.gmail.com","threadId":"21123","inReplyTo":"18cd41840910031300i32c74b15t74eb9eee23ff8469@mail.gmail.com","subject":"Re: [PATCH] MSVC: Enable OpenSSL, and translate -lcrypto","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@googlemail.com","sentAt":"2009-10-03T20:05:36Z","receivedAt":"2009-10-03T20:05:36Z","isPatch":true,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"\nOn Sat, Oct 3, 2009 at 1:00 PM, Marius Storm-Olsen wrote:\n>  This patch was actually sent using the MSVC\n>  git-imap-send.exe to my GMail account.\n>   D:\\msvc\\git>cat\n> 0001-MSVC-Enable-OpenSSL-and-translate-lcrypto.patch |\n> git-imap-send.exe\n>   Resolving imap.gmail.com... ok\n>   Connecting to 74.125.79.109:993... ok\n>   Logging in...\n>   sending 1 message\n>   100% (1/1) done\n>  :)\n\nAwesome :)\n\n> diff --git a/Makefile b/Makefile\n> index 8818f0f..c4b91d8 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -881,7 +881,6 @@ ifdef MSVC\n>        GIT_VERSION := $(GIT_VERSION).MSVC\n>        pathsep = ;\n>        NO_PREAD = YesPlease\n> -       NO_OPENSSL = YesPlease\n>        NO_LIBGEN_H = YesPlease\n>        NO_SYMLINK_HEAD = YesPlease\n>        NO_IPV6 = YesPlease\n\nDidn't my 7/7 already do this hunk?\n\n-- \nErik \"kusma\" Faye-Lund\nkusmabite@gmail.com\n(+47) 986 59 656\n"},{"id":"124187","messageId":"4AC7AF58.1090603@gmail.com","threadId":"21123","inReplyTo":"40aa078e0910031305u38cfaf4aua72d4c7af2a470b2@mail.gmail.com","subject":"Re: [PATCH] MSVC: Enable OpenSSL, and translate -lcrypto","fromName":"Marius Storm-Olsen","fromEmail":"marius@storm-olsen.com","sentAt":"2009-10-03T20:08:56Z","receivedAt":"2009-10-03T20:08:56Z","isPatch":true,"sender":{"key":"marius@storm-olsen.com","avatar":"https://avatars.githubusercontent.com/u/1500?v=4"},"body":"\nErik Faye-Lund said the following on 03.10.2009 22:05:\n> On Sat, Oct 3, 2009 at 1:00 PM, Marius Storm-Olsen wrote:\n>> This patch was actually sent using the MSVC\n>> git-imap-send.exe to my GMail account.\n>> D:\\msvc\\git>cat\n>> 0001-MSVC-Enable-OpenSSL-and-translate-lcrypto.patch |\n>> git-imap-send.exe\n>> Resolving imap.gmail.com... ok\n>> Connecting to 74.125.79.109:993... ok\n>> Logging in...\n>> sending 1 message\n>> 100% (1/1) done\n>> :)\n> \n> Awesome :)\n\nYup, only sad to see that GMail dropped the In-reply-to when sending :-/\n\n>> diff --git a/Makefile b/Makefile\n>> index 8818f0f..c4b91d8 100644\n>> --- a/Makefile\n>> +++ b/Makefile\n>> @@ -881,7 +881,6 @@ ifdef MSVC\n>> GIT_VERSION := $(GIT_VERSION).MSVC\n>> pathsep = ;\n>> NO_PREAD = YesPlease\n>> - NO_OPENSSL = YesPlease\n>> NO_LIBGEN_H = YesPlease\n>> NO_SYMLINK_HEAD = YesPlease\n>> NO_IPV6 = YesPlease\n> \n> Didn't my 7/7 already do this hunk?\n\nNot for MSVC. It has it's own section above the MinGW part. Besides, the\n-lcrypto 'translation' is critical for it to link.\n\n--\n.marius\n"},{"id":"124190","messageId":"40aa078e0910031317p4b76b0ci4f5b1f8eeb4a905e@mail.gmail.com","threadId":"21123","inReplyTo":"4AC7AF58.1090603@gmail.com","subject":"Re: [PATCH] MSVC: Enable OpenSSL, and translate -lcrypto","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@googlemail.com","sentAt":"2009-10-03T20:17:48Z","receivedAt":"2009-10-03T20:17:48Z","isPatch":true,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"\nOn Sat, Oct 3, 2009 at 1:08 PM, Marius Storm-Olsen\n wrote:\n>> Didn't my 7/7 already do this hunk?\n>\n> Not for MSVC. It has it's own section above the MinGW part. Besides, the\n> -lcrypto 'translation' is critical for it to link.\n\nAhh, thanks for the clarification :)\n\n-- \nErik \"kusma\" Faye-Lund\nkusmabite@gmail.com\n(+47) 986 59 656\n"}]}