{"thread":{"id":"21079","subject":"[PATCH] generators/vcproj.pm: remove UNICODE from build","startedAt":"2009-09-28T10:46:52Z","lastAt":"2009-09-28T12:39:24Z","messageCount":2,"participants":["Michael Wookey","Marius Storm-Olsen"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"123937","messageId":"d2e97e800909280346s12c205f2gf95ff4c135d4625c@mail.gmail.com","threadId":"21079","inReplyTo":null,"subject":"[PATCH] generators/vcproj.pm: remove UNICODE from build","fromName":"Michael Wookey","fromEmail":"michaelwookey@gmail.com","sentAt":"2009-09-28T10:46:52Z","receivedAt":"2009-09-28T10:46:52Z","isPatch":true,"sender":{"key":"michaelwookey@gmail.com","avatar":"https://avatars.githubusercontent.com/u/19476?v=4"},"body":"Defining UNICODE for MSVC IDE builds results in certain Win32 WIDE API's\nreceiving ANSI strings. The result of which is an invalid use of the API\nand will end in either data corruption or an application crash.\n\nPrevent the use of WIDE API's when building with the MSVC IDE for\ncompatibility with msysGit.\n\nSigned-off-by: Michael Wookey <michaelwookey@gmail.com>\n---\n contrib/buildsystems/Generators/Vcproj.pm |    8 ++++----\n 1 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/contrib/buildsystems/Generators/Vcproj.pm\nb/contrib/buildsystems/Generators/Vcproj.pm\nindex 00ec0c1..a215911 100644\n--- a/contrib/buildsystems/Generators/Vcproj.pm\n+++ b/contrib/buildsystems/Generators/Vcproj.pm\n@@ -173,7 +173,7 @@ sub createLibProject {\n \t\t\t\tOptimization=\"0\"\n \t\t\t\tInlineFunctionExpansion=\"1\"\n \t\t\t\tAdditionalIncludeDirectories=\"$includes\"\n-\t\t\t\tPreprocessorDefinitions=\"UNICODE,WIN32,_DEBUG,$defines\"\n+\t\t\t\tPreprocessorDefinitions=\"WIN32,_DEBUG,$defines\"\n \t\t\t\tMinimalRebuild=\"true\"\n \t\t\t\tRuntimeLibrary=\"1\"\n \t\t\t\tUsePrecompiledHeader=\"0\"\n@@ -239,7 +239,7 @@ sub createLibProject {\n \t\t\t\tInlineFunctionExpansion=\"1\"\n \t\t\t\tEnableIntrinsicFunctions=\"true\"\n \t\t\t\tAdditionalIncludeDirectories=\"$includes\"\n-\t\t\t\tPreprocessorDefinitions=\"UNICODE,WIN32,NDEBUG,$defines\"\n+\t\t\t\tPreprocessorDefinitions=\"WIN32,NDEBUG,$defines\"\n \t\t\t\tRuntimeLibrary=\"0\"\n \t\t\t\tEnableFunctionLevelLinking=\"true\"\n \t\t\t\tUsePrecompiledHeader=\"0\"\n@@ -395,7 +395,7 @@ sub createAppProject {\n \t\t\t\tOptimization=\"0\"\n \t\t\t\tInlineFunctionExpansion=\"1\"\n \t\t\t\tAdditionalIncludeDirectories=\"$includes\"\n-\t\t\t\tPreprocessorDefinitions=\"UNICODE,WIN32,_DEBUG,$defines\"\n+\t\t\t\tPreprocessorDefinitions=\"WIN32,_DEBUG,$defines\"\n \t\t\t\tMinimalRebuild=\"true\"\n \t\t\t\tRuntimeLibrary=\"1\"\n \t\t\t\tUsePrecompiledHeader=\"0\"\n@@ -466,7 +466,7 @@ sub createAppProject {\n \t\t\t\tInlineFunctionExpansion=\"1\"\n \t\t\t\tEnableIntrinsicFunctions=\"true\"\n \t\t\t\tAdditionalIncludeDirectories=\"$includes\"\n-\t\t\t\tPreprocessorDefinitions=\"UNICODE,WIN32,NDEBUG,$defines\"\n+\t\t\t\tPreprocessorDefinitions=\"WIN32,NDEBUG,$defines\"\n \t\t\t\tRuntimeLibrary=\"0\"\n \t\t\t\tEnableFunctionLevelLinking=\"true\"\n \t\t\t\tUsePrecompiledHeader=\"0\"\n-- \n1.6.5.rc2\n"},{"id":"123945","messageId":"4AC0AE7C.3080308@gmail.com","threadId":"21079","inReplyTo":"d2e97e800909280346s12c205f2gf95ff4c135d4625c@mail.gmail.com","subject":"Re: [PATCH] generators/vcproj.pm: remove UNICODE from build","fromName":"Marius Storm-Olsen","fromEmail":"mstormo@gmail.com","sentAt":"2009-09-28T12:39:24Z","receivedAt":"2009-09-28T12:39:24Z","isPatch":true,"sender":{"key":"mstormo@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1500?v=4"},"body":"Michael Wookey said the following on 28.09.2009 12:46:\n> Defining UNICODE for MSVC IDE builds results in certain Win32 WIDE API's\n> receiving ANSI strings. The result of which is an invalid use of the API\n> and will end in either data corruption or an application crash.\n> \n> Prevent the use of WIDE API's when building with the MSVC IDE for\n> compatibility with msysGit.\n> \n> Signed-off-by: Michael Wookey <michaelwookey@gmail.com>\n> ---\n\nAfter manually editing the patch until it applied (some headers which \ngt-am didn't like):\n\n     Acked-by: Marius Storm-Olsen <mstormo@gmail.com>\n\n--\n.marius\n"}]}