{"thread":{"id":"21070","subject":"[PATCH] gitweb: fix spelling errors in comments","startedAt":"2009-09-26T23:32:33Z","lastAt":"2009-09-27T08:54:12Z","messageCount":3,"participants":["Miklos Vajna","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"123876","messageId":"1254007953-1961-1-git-send-email-vmiklos@frugalware.org","threadId":"21070","inReplyTo":null,"subject":"[PATCH] gitweb: fix spelling errors in comments","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2009-09-26T23:32:33Z","receivedAt":"2009-09-26T23:32:33Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>\n---\n gitweb/gitweb.perl |   10 +++++-----\n 1 files changed, 5 insertions(+), 5 deletions(-)\n\nThe plural form of \"id\" is \"ids\", not \"id's\", right?\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 24b2193..b66c4d0 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -4949,7 +4949,7 @@ sub git_blob_plain {\n \t\t\tdie_error(400, \"No file name defined\");\n \t\t}\n \t} elsif ($hash =~ m/^[0-9a-fA-F]{40}$/) {\n-\t\t# blobs defined by non-textual hash id's can be cached\n+\t\t# blobs defined by non-textual hash ids can be cached\n \t\t$expires = \"+1d\";\n \t}\n \n@@ -5001,7 +5001,7 @@ sub git_blob {\n \t\t\tdie_error(400, \"No file name defined\");\n \t\t}\n \t} elsif ($hash =~ m/^[0-9a-fA-F]{40}$/) {\n-\t\t# blobs defined by non-textual hash id's can be cached\n+\t\t# blobs defined by non-textual hash ids can be cached\n \t\t$expires = \"+1d\";\n \t}\n \n@@ -5346,7 +5346,7 @@ sub git_commit {\n \t@difftree = map { chomp; $_ } <$fd>;\n \tclose $fd or die_error(404, \"Reading git-diff-tree failed\");\n \n-\t# non-textual hash id's can be cached\n+\t# non-textual hash ids can be cached\n \tmy $expires;\n \tif ($hash =~ m/^[0-9a-fA-F]{40}$/) {\n \t\t$expires = \"+1d\";\n@@ -5513,7 +5513,7 @@ sub git_blobdiff {\n \t\t$hash_parent ||= $diffinfo{'from_id'};\n \t\t$hash        ||= $diffinfo{'to_id'};\n \n-\t\t# non-textual hash id's can be cached\n+\t\t# non-textual hash ids can be cached\n \t\tif ($hash_base =~ m/^[0-9a-fA-F]{40}$/ &&\n \t\t    $hash_parent_base =~ m/^[0-9a-fA-F]{40}$/) {\n \t\t\t$expires = '+1d';\n@@ -5733,7 +5733,7 @@ sub git_commitdiff {\n \t\tdie_error(400, \"Unknown commitdiff format\");\n \t}\n \n-\t# non-textual hash id's can be cached\n+\t# non-textual hash ids can be cached\n \tmy $expires;\n \tif ($hash =~ m/^[0-9a-fA-F]{40}$/) {\n \t\t$expires = \"+1d\";\n-- \n1.6.5.rc1.44.ga1675.dirty\n"},{"id":"123891","messageId":"20090927083507.GA25891@coredump.intra.peff.net","threadId":"21070","inReplyTo":"1254007953-1961-1-git-send-email-vmiklos@frugalware.org","subject":"Re: [PATCH] gitweb: fix spelling errors in comments","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2009-09-27T08:35:07Z","receivedAt":"2009-09-27T08:35:07Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sun, Sep 27, 2009 at 01:32:33AM +0200, Miklos Vajna wrote:\n\n> Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>\n> ---\n>  gitweb/gitweb.perl |   10 +++++-----\n>  1 files changed, 5 insertions(+), 5 deletions(-)\n> \n> The plural form of \"id\" is \"ids\", not \"id's\", right?\n\nIt is a matter of some debate, actually. As an abbreviation, it should\nrightly be \"ID\", and therefore \"IDs\". Most style manuals indicate that\nno apostrophe should be used these days, unless it is an abbreviation\nseparated by dots (e.g., \"I.D.'s\").\n\nSome disagree, and some indicate that you should use an apostrophe where\nit may be visually more clear (for example, in single-letter\nabbreviations like \"A's\").\n\nThere is a nice summary of some style guides here:\n\n  http://answers.google.com/answers/threadview?id=499296\n\nHonestly, for such an informal bit of text as a code comment, I'm not\nsure it is worth nit-picking the grammar (e.g., we should be\nwriting SHA-1 everywhere, and we obviously don't). I'll let Shawn decide\nwhether he wants to apply or not.\n\n-Peff\n"},{"id":"123893","messageId":"20090927085412.GS32702@genesis.frugalware.org","threadId":"21070","inReplyTo":"20090927083507.GA25891@coredump.intra.peff.net","subject":"Re: [PATCH] gitweb: fix spelling errors in comments","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2009-09-27T08:54:12Z","receivedAt":"2009-09-27T08:54:12Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"On Sun, Sep 27, 2009 at 04:35:07AM -0400, Jeff King <peff@peff.net> wrote:\n> > The plural form of \"id\" is \"ids\", not \"id's\", right?\n> \n> It is a matter of some debate, actually. As an abbreviation, it should\n> rightly be \"ID\", and therefore \"IDs\". Most style manuals indicate that\n> no apostrophe should be used these days, unless it is an abbreviation\n> separated by dots (e.g., \"I.D.'s\").\n> \n> Some disagree, and some indicate that you should use an apostrophe where\n> it may be visually more clear (for example, in single-letter\n> abbreviations like \"A's\").\n> \n> There is a nice summary of some style guides here:\n> \n>   http://answers.google.com/answers/threadview?id=499296\n> \n> Honestly, for such an informal bit of text as a code comment, I'm not\n> sure it is worth nit-picking the grammar (e.g., we should be\n> writing SHA-1 everywhere, and we obviously don't). I'll let Shawn decide\n> whether he wants to apply or not.\n\nAs a non-native I did not know to resolve \"id's\" to \"id is\" or \"id has\",\nand once I figured it out, I thought about sending a patch.\n\nThough, if that helps, I can resend it with \"Blobs defined by\nnon-textual hash IDs can be cached\" to be more readable.\n"}]}