{"thread":{"id":"21060","subject":"Re: [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer","startedAt":"2009-09-24T14:40:52Z","lastAt":"2009-09-28T13:40:24Z","messageCount":16,"participants":["Shawn O. Pearce","Alex Riesen","Sebastian Schuberth","Baz","Marius Storm-Olsen"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"299120","messageId":"4ABB84F4.7080403@gmail.com","threadId":"21060","inReplyTo":null,"subject":"[PATCH 1/2] Make generated MSVC solution file open from Windows Explorer","fromName":"Sebastian Schuberth","fromEmail":"sschuberth@gmail.com","sentAt":"2009-09-24T14:40:52Z","receivedAt":"2009-09-24T14:40:52Z","isPatch":true,"sender":{"key":"sschuberth@gmail.com","avatar":"https://avatars.githubusercontent.com/u/349154?v=4"},"body":" From c6d29a2d243647bb2877eb2114938ae20c8e56e5 Mon Sep 17 00:00:00 2001\nFrom: Sebastian Schuberth \nDate: Thu, 24 Sep 2009 15:52:25 +0200\nSubject: [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer\n\nIn order to be able to open the generated solution file by double-clicking it\nin Windows Explorer, all project files need to use DOS line-endings and a\ncomment about the Visual Studio version needs to be added to the header of the\nsolution file. This also fixes the icon that is displayed for the solution file\nin Windows Explorer.\nNote that opening the solution file from a running instance of Visual Studio\nalready worked before.\n\nSigned-off-by: Sebastian Schuberth \n---\n contrib/buildsystems/Generators/Vcproj.pm | 5 ++++-\n 1 files changed, 4 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/buildsystems/Generators/Vcproj.pm b/contrib/buildsystems/Generators/Vcproj.pm\nindex 00ec0c1..50daa03 100644\n--- a/contrib/buildsystems/Generators/Vcproj.pm\n+++ b/contrib/buildsystems/Generators/Vcproj.pm\n@@ -131,6 +131,7 @@ sub createLibProject {\n $includes =~ s/-I//g;\n mkdir \"$target\" || die \"Could not create the directory $target for lib project!\\n\";\n open F, \">$target/$target.vcproj\" || die \"Could not open $target/$target.pro for writing!\\n\";\n+ binmode F, \":crlf\";\n print F << \"EOM\";\n \n $target/$target.vcproj\" || die \"Could not open $target/$target.pro for writing!\\n\";\n+ binmode F, \":crlf\";\n print F << \"EOM\";\n \n git.sln\" || die \"Could not open git.sln for writing!\\n\";\n+ binmode F, \":crlf\";\n print F \"$SLN_HEAD\";\n foreach (@libs) {\n my $libname = $_;\n-- \n1.6.4.msysgit.0\n\n"},{"id":"123815","messageId":"20090925220510.GY14660@spearce.org","threadId":"21060","inReplyTo":"4ABB84F4.7080403@gmail.com","subject":"Re: [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2009-09-25T22:05:10Z","receivedAt":"2009-09-25T22:05:10Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Sebastian Schuberth wrote:\n> From c6d29a2d243647bb2877eb2114938ae20c8e56e5 Mon Sep 17 00:00:00 2001\n> From: Sebastian Schuberth \n> Date: Thu, 24 Sep 2009 15:52:25 +0200\n> Subject: [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer\n>\n> In order to be able to open the generated solution file by double-clicking it\n> in Windows Explorer, all project files need to use DOS line-endings and a\n> comment about the Visual Studio version needs to be added to the header of the\n> solution file. This also fixes the icon that is displayed for the solution file\n> in Windows Explorer.\n> Note that opening the solution file from a running instance of Visual Studio\n> already worked before.\n\nSomething is wrong with both patches; neither applies. It looks\nto be an issue with whitespace, like context lines are gaining an\nextra space at the start of the line.\n\n-- \nShawn.\n"},{"id":"123816","messageId":"81b0412b0909251511m24e5c6bcg3f8c4e3576ad3bd3@mail.gmail.com","threadId":"21060","inReplyTo":"20090925220510.GY14660@spearce.org","subject":"Re: [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2009-09-25T22:11:13Z","receivedAt":"2009-09-25T22:11:13Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"On Sat, Sep 26, 2009 at 00:05, Shawn O. Pearce wrote:\n> Sebastian Schuberth wrote:\n>> In order to be able to open the generated solution file by double-clicking it\n>> in Windows Explorer, all project files need to use DOS line-endings and a\n>> comment about the Visual Studio version needs to be added to the header of the\n>> solution file. This also fixes the icon that is displayed for the solution file\n>> in Windows Explorer.\n>> Note that opening the solution file from a running instance of Visual Studio\n>> already worked before.\n>\n> Something is wrong with both patches; neither applies.  It looks\n> to be an issue with whitespace, like context lines are gaining an\n> extra space at the start of the line.\n\nBesides, there is PERLIO environment variable. Try setting it to\nPERLIO=':perlio'\n"},{"id":"123818","messageId":"bdca99240909251541h2e9932a3r67c1d8604e56a8df@mail.gmail.com","threadId":"21060","inReplyTo":"20090925220510.GY14660@spearce.org","subject":"Re: [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer","fromName":"Sebastian Schuberth","fromEmail":"sschuberth@gmail.com","sentAt":"2009-09-25T22:41:01Z","receivedAt":"2009-09-25T22:41:01Z","isPatch":true,"sender":{"key":"sschuberth@gmail.com","avatar":"https://avatars.githubusercontent.com/u/349154?v=4"},"body":"On Sat, Sep 26, 2009 at 00:05, Shawn O. Pearce wrote:\n\n> Sebastian Schuberth wrote:\n>> From c6d29a2d243647bb2877eb2114938ae20c8e56e5 Mon Sep 17 00:00:00 2001\n>> From: Sebastian Schuberth \n>> Date: Thu, 24 Sep 2009 15:52:25 +0200\n>> Subject: [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer\n>>\n>> In order to be able to open the generated solution file by double-clicking it\n>> in Windows Explorer, all project files need to use DOS line-endings and a\n>> comment about the Visual Studio version needs to be added to the header of the\n>> solution file. This also fixes the icon that is displayed for the solution file\n>> in Windows Explorer.\n>> Note that opening the solution file from a running instance of Visual Studio\n>> already worked before.\n>\n> Something is wrong with both patches; neither applies.  It looks\n> to be an issue with whitespace, like context lines are gaining an\n> extra space at the start of the line.\n\nHmm, the patches apply fine onto master for me.\n\nAs a side note, I've never liked sending patches via mail. It just\nfeels like writing a text on a computer just to print it out, scan in\nthe sheet again, and then sending the scanned image as an attachment\nvia email. Isn't there a better way to contribute patches to Git, like\npushing to a mob branch as for the msysGit project?\n\n-- \nSebastian Schuberth\n"},{"id":"123820","messageId":"bdca99240909251545h48fd62bdsafacb42aeb9a7b2@mail.gmail.com","threadId":"21060","inReplyTo":"81b0412b0909251511m24e5c6bcg3f8c4e3576ad3bd3@mail.gmail.com","subject":"Re: [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer","fromName":"Sebastian Schuberth","fromEmail":"sschuberth@gmail.com","sentAt":"2009-09-25T22:45:51Z","receivedAt":"2009-09-25T22:45:51Z","isPatch":true,"sender":{"key":"sschuberth@gmail.com","avatar":"https://avatars.githubusercontent.com/u/349154?v=4"},"body":"On Sat, Sep 26, 2009 at 00:11, Alex Riesen wrote:\n\n> On Sat, Sep 26, 2009 at 00:05, Shawn O. Pearce wrote:\n>> Sebastian Schuberth wrote:\n>>> In order to be able to open the generated solution file by double-clicking it\n>>> in Windows Explorer, all project files need to use DOS line-endings and a\n>>> comment about the Visual Studio version needs to be added to the header of the\n>>> solution file. This also fixes the icon that is displayed for the solution file\n>>> in Windows Explorer.\n>>> Note that opening the solution file from a running instance of Visual Studio\n>>> already worked before.\n>>\n>> Something is wrong with both patches; neither applies.  It looks\n>> to be an issue with whitespace, like context lines are gaining an\n>> extra space at the start of the line.\n>\n> Besides, there is PERLIO environment variable. Try setting it to\n> PERLIO=':perlio'\n\nBut I don't feel like using it here would be the right thing to do.\nVisual Studio project files should never ever be written out with Unix\nline-endings, not even if someone created them under Unix. So instead\nof relying on the environment variable to be set correctly, I believe\nit's better to always enforce the correct line-endings here.\n\n-- \nSebastian Schuberth\n"},{"id":"123822","messageId":"20090925225940.GB14660@spearce.org","threadId":"21060","inReplyTo":"bdca99240909251541h2e9932a3r67c1d8604e56a8df@mail.gmail.com","subject":"Re: [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2009-09-25T22:59:40Z","receivedAt":"2009-09-25T22:59:40Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Sebastian Schuberth wrote:\n> On Sat, Sep 26, 2009 at 00:05, Shawn O. Pearce wrote:\n> > Something is wrong with both patches; neither applies. ??It looks\n> > to be an issue with whitespace, like context lines are gaining an\n> > extra space at the start of the line.\n> \n> Hmm, the patches apply fine onto master for me.\n\nAfter going through your client and the GMane email gateway?\nOr before you pasted it into the message?\n \n> As a side note, I've never liked sending patches via mail. It just\n> feels like writing a text on a computer just to print it out, scan in\n> the sheet again, and then sending the scanned image as an attachment\n> via email. Isn't there a better way to contribute patches to Git, like\n> pushing to a mob branch as for the msysGit project?\n\nIt works fine, so long as the tools in the chain leave the body\nof the message alone and don't try to outsmart the human who put\nit there.\n\nThe git project in particular as rules about only applying patches\noff the mailing list, because then all contributions are in a\npermanent, public archive. Its also the form of communication most\ncontributors prefer for code reviews.\n\n-- \nShawn.\n"},{"id":"123825","messageId":"bdca99240909251658q395a62b6r8d5998382ac3fc7b@mail.gmail.com","threadId":"21060","inReplyTo":"20090925225940.GB14660@spearce.org","subject":"Re: [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer","fromName":"Sebastian Schuberth","fromEmail":"sschuberth@gmail.com","sentAt":"2009-09-25T23:58:11Z","receivedAt":"2009-09-25T23:58:11Z","isPatch":true,"sender":{"key":"sschuberth@gmail.com","avatar":"https://avatars.githubusercontent.com/u/349154?v=4"},"body":"On Sat, Sep 26, 2009 at 00:59, Shawn O. Pearce wrote:\n\n> Sebastian Schuberth wrote:\n>> On Sat, Sep 26, 2009 at 00:05, Shawn O. Pearce wrote:\n>> > Something is wrong with both patches; neither applies. ??It looks\n>> > to be an issue with whitespace, like context lines are gaining an\n>> > extra space at the start of the line.\n>>\n>> Hmm, the patches apply fine onto master for me.\n>\n> After going through your client and the GMane email gateway?\n> Or before you pasted it into the message?\n\nBoth. As a test for the first, I've copied & pasted my mail as it\nappears for me in gmane.comp.version-control.git to a new file and\nsuccessfully applied that file via \"git apply\". I had to do it this\nway, as on Windows I cannot really use \"git am\" with Thunderbird.\n\n-- \nSebastian Schuberth\n"},{"id":"123826","messageId":"20090926000500.GE14660@spearce.org","threadId":"21060","inReplyTo":"bdca99240909251658q395a62b6r8d5998382ac3fc7b@mail.gmail.com","subject":"Re: [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2009-09-26T00:05:00Z","receivedAt":"2009-09-26T00:05:00Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Sebastian Schuberth wrote:\n> On Sat, Sep 26, 2009 at 00:59, Shawn O. Pearce wrote:\n> > Sebastian Schuberth wrote:\n> >> On Sat, Sep 26, 2009 at 00:05, Shawn O. Pearce wrote:\n> >> > Something is wrong with both patches; neither applies.\n> >>\n> >> Hmm, the patches apply fine onto master for me.\n> >\n> > After going through your client and the GMane email gateway?\n> > Or before you pasted it into the message?\n> \n> Both. As a test for the first, I've copied & pasted my mail as it\n> appears for me in gmane.comp.version-control.git to a new file and\n> successfully applied that file via \"git apply\". I had to do it this\n> way, as on Windows I cannot really use \"git am\" with Thunderbird.\n\nOdd. If I copy and paste from Thunderbird, its fine. But if I\nsave the body out as an attachment from mutt, it fails.\n\nI wonder if it has to do with the From header appearing in the top\nof the body; this header has to be escaped with a leading space in\nmbox format. It looks like Thunderbird might be doing some magic to\nremove that leading space from the context lines, while mutt isn't.\n\nNext time, don't include the first From line?\n\n-- \nShawn.\n"},{"id":"123836","messageId":"bdca99240909260245i6ba10dd4j1b2ee9e74ea5282d@mail.gmail.com","threadId":"21060","inReplyTo":"20090926000500.GE14660@spearce.org","subject":"Re: [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer","fromName":"Sebastian Schuberth","fromEmail":"sschuberth@gmail.com","sentAt":"2009-09-26T09:45:54Z","receivedAt":"2009-09-26T09:45:54Z","isPatch":true,"sender":{"key":"sschuberth@gmail.com","avatar":"https://avatars.githubusercontent.com/u/349154?v=4"},"body":"On Sat, Sep 26, 2009 at 02:05, Shawn O. Pearce wrote:\n\n> Odd.  If I copy and paste from Thunderbird, its fine.  But if I\n> save the body out as an attachment from mutt, it fails.\n>\n> I wonder if it has to do with the From header appearing in the top\n> of the body; this header has to be escaped with a leading space in\n> mbox format.  It looks like Thunderbird might be doing some magic to\n> remove that leading space from the context lines, while mutt isn't.\n>\n> Next time, don't include the first From line?\n\nWill try. So what about these two patches? Should I re-send them with\nthe first \"From\" stripped?\n\nOr will *.patch files that are attached to emails, instead of sending\nthe patch inline, be accepted?\n\n-- \nSebastian Schuberth\n"},{"id":"123863","messageId":"20090926200529.GJ14660@spearce.org","threadId":"21060","inReplyTo":"bdca99240909260245i6ba10dd4j1b2ee9e74ea5282d@mail.gmail.com","subject":"Re: [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2009-09-26T20:05:29Z","receivedAt":"2009-09-26T20:05:29Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Sebastian Schuberth wrote:\n> On Sat, Sep 26, 2009 at 02:05, Shawn O. Pearce wrote:\n> > Odd. ??If I copy and paste from Thunderbird, its fine. ??But if I\n> > save the body out as an attachment from mutt, it fails.\n> >\n> > I wonder if it has to do with the From header appearing in the top\n> > of the body; this header has to be escaped with a leading space in\n> > mbox format. ??It looks like Thunderbird might be doing some magic to\n> > remove that leading space from the context lines, while mutt isn't.\n> >\n> > Next time, don't include the first From line?\n> \n> Will try. So what about these two patches? Should I re-send them with\n> the first \"From\" stripped?\n\nMight be worth trying. I honestly don't know why they were munged\nbefore.\n \n> Or will *.patch files that are attached to emails, instead of sending\n> the patch inline, be accepted?\n\nWe really don't like them, because you can't comment on them inline\neasily. Sometimes they are acceptable for translation files when\nthe character encoding otherwise gets really broken.\n\n-- \nShawn.\n"},{"id":"123935","messageId":"2faad3050909280336r61e11b20nb52629a8fe95b0c0@mail.gmail.com","threadId":"21060","inReplyTo":"bdca99240909260245i6ba10dd4j1b2ee9e74ea5282d@mail.gmail.com","subject":"Re: [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer","fromName":"Baz","fromEmail":"brian.ewins@gmail.com","sentAt":"2009-09-28T10:36:54Z","receivedAt":"2009-09-28T10:36:54Z","isPatch":true,"sender":{"key":"brian.ewins@gmail.com","avatar":"https://gravatar.com/avatar/9ac03d89105e50a7151e695a1b4b1228151064ec3ac380a73b74ab397796baf7?d=mp&s=160"},"body":"2009/9/26 Sebastian Schuberth :\n> On Sat, Sep 26, 2009 at 02:05, Shawn O. Pearce wrote:\n>\n>> Odd.  If I copy and paste from Thunderbird, its fine.  But if I\n>> save the body out as an attachment from mutt, it fails.\n>>\n>> I wonder if it has to do with the From header appearing in the top\n>> of the body; this header has to be escaped with a leading space in\n>> mbox format.  It looks like Thunderbird might be doing some magic to\n>> remove that leading space from the context lines, while mutt isn't.\n\nFYI: the Thunderbird version included this header:\nContent-Type: text/plain; charset=ISO-8859-1; format=flowed\n\nThe format=flowed part shows that Thunderbird is reformatting\nwhitespace. You can disable that:\nhttp://kb.mozillazine.org/Plain_text_e-mail_-_Thunderbird#Completely_plain_email\n\n'flowed' is a lossy transformation of text, so git won't attempt to\nfix patches that have been mangled that way. There's a longer\nexplanation from Junio here:\nhttp://kerneltrap.org/mailarchive/git/2008/2/15/867294\n\nHope this helps,\nBaz\n\n>>\n>> Next time, don't include the first From line?\n>\n> Will try. So what about these two patches? Should I re-send them with\n> the first \"From\" stripped?\n>\n> Or will *.patch files that are attached to emails, instead of sending\n> the patch inline, be accepted?\n>\n> --\n> Sebastian Schuberth\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n>\n"},{"id":"123941","messageId":"cover.1254137149.git.mstormo@gmail.com","threadId":"21060","inReplyTo":"4ABB84F4.7080403@gmail.com","subject":"[PATCH 0/2] MSVC generator fixups","fromName":"Marius Storm-Olsen","fromEmail":"mstormo@gmail.com","sentAt":"2009-09-28T11:34:19Z","receivedAt":"2009-09-28T11:34:19Z","isPatch":true,"sender":{"key":"mstormo@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1500?v=4"},"body":"The generated solution file was valid, but not exactly in the way the\n2008 IDE wanted them, so the IDE would query to save the solution file\neven though the user never touched the solution/projects.\nThese two patches ensures that the solution file is in the way the IDE\nwants them, so we avoid the naging.\n\nThe two patches didn't apply for me in the way they were sent. I\nmanually applied them ontop of master, and added an Acked-by.\n\nThanks!\n\nSebastian Schuberth (2):\n Make generated MSVC solution file open from Windows Explorer\n Make just opening the generated MSVC solution file not modify it\n\n contrib/buildsystems/Generators/Vcproj.pm | 47 +++++++++-------------------\n 1 files changed, 15 insertions(+), 32 deletions(-)\n"},{"id":"123942","messageId":"bffcec831c47d8f82e41ee629bd381dbcc7221d0.1254137149.git.mstormo@gmail.com","threadId":"21060","inReplyTo":"cover.1254137149.git.mstormo@gmail.com","subject":"[PATCH 1/2] Make generated MSVC solution file open from Windows Explorer","fromName":"Marius Storm-Olsen","fromEmail":"mstormo@gmail.com","sentAt":"2009-09-28T11:34:20Z","receivedAt":"2009-09-28T11:34:20Z","isPatch":true,"sender":{"key":"mstormo@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1500?v=4"},"body":"From: Sebastian Schuberth \n\nIn order to be able to open the generated solution file by double-\nclicking it in Windows Explorer, all project files need to use DOS\nline-endings and a comment about the Visual Studio version needs to\nbe added to the header of the solution file. This also fixes the icon\nthat is displayed for the solution file in Windows Explorer.\nNote that opening the solution file from a running instance of Visual\nStudio already worked before.\n\nSigned-off-by: Sebastian Schuberth \nAcked-by: Marius Storm-Olsen \n---\n contrib/buildsystems/Generators/Vcproj.pm | 5 ++++-\n 1 files changed, 4 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/buildsystems/Generators/Vcproj.pm b/contrib/buildsystems/Generators/Vcproj.pm\nindex 00ec0c1..50daa03 100644\n--- a/contrib/buildsystems/Generators/Vcproj.pm\n+++ b/contrib/buildsystems/Generators/Vcproj.pm\n@@ -131,6 +131,7 @@ sub createLibProject {\n $includes =~ s/-I//g;\n mkdir \"$target\" || die \"Could not create the directory $target for lib project!\\n\";\n open F, \">$target/$target.vcproj\" || die \"Could not open $target/$target.pro for writing!\\n\";\n+ binmode F, \":crlf\";\n print F << \"EOM\";\n \n $target/$target.vcproj\" || die \"Could not open $target/$target.pro for writing!\\n\";\n+ binmode F, \":crlf\";\n print F << \"EOM\";\n \n git.sln\" || die \"Could not open git.sln for writing!\\n\";\n+ binmode F, \":crlf\";\n print F \"$SLN_HEAD\";\n foreach (@libs) {\n my $libname = $_;\n-- \n1.6.5.rc2.177.ga9dd6\n"},{"id":"123943","messageId":"f8aa063d3a2be33146b3626c4908ce1f64d9c7ac.1254137149.git.mstormo@gmail.com","threadId":"21060","inReplyTo":"cover.1254137149.git.mstormo@gmail.com","subject":"[PATCH 2/2] Make just opening the generated MSVC solution file not modify it","fromName":"Marius Storm-Olsen","fromEmail":"mstormo@gmail.com","sentAt":"2009-09-28T11:34:21Z","receivedAt":"2009-09-28T11:34:21Z","isPatch":true,"sender":{"key":"mstormo@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1500?v=4"},"body":"\nFrom: Sebastian Schuberth \n\nThe format of the generated MSVC solution file is fixed in a way that\njust opening it in Visual Studio and immediately closing it again\nwithout performing any modifications does not trigger a prompt to save\nthe solution file. This behavior was caused by several minor\nincompatibilities between the generated file and what Visual Studio\n2008 expected, so Visual Studio transparently fixed the file format,\nmarking it internally as modified.\n\nSigned-off-by: Sebastian Schuberth \nAcked-by: Marius Storm-Olsen \n---\n contrib/buildsystems/Generators/Vcproj.pm | 42 +++++++---------------------\n 1 files changed, 11 insertions(+), 31 deletions(-)\n\ndiff --git a/contrib/buildsystems/Generators/Vcproj.pm b/contrib/buildsystems/Generators/Vcproj.pm\nindex 50daa03..d53ff2c 100644\n--- a/contrib/buildsystems/Generators/Vcproj.pm\n+++ b/contrib/buildsystems/Generators/Vcproj.pm\n@@ -571,45 +571,29 @@ sub createGlueProject {\n print F \"\\\"${libname}\\\", \\\"${libname}\\\\${libname}.vcproj\\\", \\\"${uuid}\\\"\";\n print F \"$SLN_POST\";\n }\n+ my $uuid_libgit = $build_structure{\"LIBS_libgit_GUID\"};\n+ my $uuid_xdiff_lib = $build_structure{\"LIBS_xdiff_lib_GUID\"};\n foreach (@apps) {\n my $appname = $_;\n my $uuid = $build_structure{\"APPS_${appname}_GUID\"};\n print F \"$SLN_PRE\";\n- print F \"\\\"${appname}\\\", \\\"${appname}\\\\${appname}.vcproj\\\", \\\"${uuid}\\\"\";\n+ print F \"\\\"${appname}\\\", \\\"${appname}\\\\${appname}.vcproj\\\", \\\"${uuid}\\\"\\n\";\n+ print F \"\tProjectSection(ProjectDependencies) = postProject\\n\";\n+ print F \"\t\t${uuid_libgit} = ${uuid_libgit}\\n\";\n+ print F \"\t\t${uuid_xdiff_lib} = ${uuid_xdiff_lib}\\n\";\n+ print F \"\tEndProjectSection\";\n print F \"$SLN_POST\";\n }\n \n print F << \"EOM\";\n Global\n-\tGlobalSection(SolutionConfiguration) = preSolution\n-\t\tConfigName.0 = Debug|Win32\n-\t\tConfigName.1 = Release|Win32\n+\tGlobalSection(SolutionConfigurationPlatforms) = preSolution\n+\t\tDebug|Win32 = Debug|Win32\n+\t\tRelease|Win32 = Release|Win32\n \tEndGlobalSection\n-\tGlobalSection(ProjectDependencies) = postSolution\n EOM\n- foreach (@{$build_structure{\"APPS\"}}) {\n- my $appname = $_;\n- my $appname_clean = $_;\n- $appname_clean =~ s/\\//_/g;\n- $appname_clean =~ s/\\.exe//;\n-\n- my $uuid = $build_structure{\"APPS_${appname_clean}_GUID\"};\n- my $dep_index = 0;\n- foreach(@{$build_structure{\"APPS_${appname}_LIBS\"}}) {\n- my $libname = $_;\n- $libname =~ s/\\//_/g;\n- $libname =~ s/\\.(a|lib)//;\n- my $libuuid = $build_structure{\"LIBS_${libname}_GUID\"};\n- if (defined $libuuid) {\n- print F \"\\t\\t${uuid}.${dep_index} = ${libuuid}\\n\";\n- $dep_index += 1;\n- }\n- }\n- }\n-\n print F << \"EOM\";\n-\tEndGlobalSection\n-\tGlobalSection(ProjectConfiguration) = postSolution\n+\tGlobalSection(ProjectConfigurationPlatforms) = postSolution\n EOM\n foreach (@libs) {\n my $libname = $_;\n@@ -630,10 +614,6 @@ EOM\n \n print F << \"EOM\";\n \tEndGlobalSection\n-\tGlobalSection(ExtensibilityGlobals) = postSolution\n-\tEndGlobalSection\n-\tGlobalSection(ExtensibilityAddIns) = postSolution\n-\tEndGlobalSection\n EndGlobal\n EOM\n close F;\n-- \n1.6.5.rc2.177.ga9dd6\n"},{"id":"123948","messageId":"bdca99240909280601r296d66efi78a6092282ffc256@mail.gmail.com","threadId":"21060","inReplyTo":"cover.1254137149.git.mstormo@gmail.com","subject":"Re: [PATCH 0/2] MSVC generator fixups","fromName":"Sebastian Schuberth","fromEmail":"sschuberth@gmail.com","sentAt":"2009-09-28T13:01:30Z","receivedAt":"2009-09-28T13:01:30Z","isPatch":true,"sender":{"key":"sschuberth@gmail.com","avatar":"https://avatars.githubusercontent.com/u/349154?v=4"},"body":"\n> The two patches didn't apply for me in the way they were sent. I\n> manually applied them ontop of master, and added an Acked-by.\n\nThanks for fixing my patches, Marius!\n\n-- \nSebastian Schuberth\n"},{"id":"123950","messageId":"bdca99240909280640x410ba7f4u5bd09a8cba2c9bb2@mail.gmail.com","threadId":"21060","inReplyTo":"2faad3050909280336r61e11b20nb52629a8fe95b0c0@mail.gmail.com","subject":"Re: [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer","fromName":"Sebastian Schuberth","fromEmail":"sschuberth@gmail.com","sentAt":"2009-09-28T13:40:24Z","receivedAt":"2009-09-28T13:40:24Z","isPatch":true,"sender":{"key":"sschuberth@gmail.com","avatar":"https://avatars.githubusercontent.com/u/349154?v=4"},"body":"On Mon, Sep 28, 2009 at 12:36, Baz wrote:\n\n>>> Odd.  If I copy and paste from Thunderbird, its fine.  But if I\n>>> save the body out as an attachment from mutt, it fails.\n>>>\n>>> I wonder if it has to do with the From header appearing in the top\n>>> of the body; this header has to be escaped with a leading space in\n>>> mbox format.  It looks like Thunderbird might be doing some magic to\n>>> remove that leading space from the context lines, while mutt isn't.\n>\n> FYI: the Thunderbird version included this header:\n> Content-Type:  text/plain; charset=ISO-8859-1; format=flowed\n>\n> The format=flowed part shows that Thunderbird is reformatting\n> whitespace. You can disable that:\n> http://kb.mozillazine.org/Plain_text_e-mail_-_Thunderbird#Completely_plain_email\n\nThanks, this was indeed helpful. I was relying on the \"Toggle Word\nWrap\" extension [1] to handle this, but apparently it only changes how\nthe *sender* sees the message, but does not remove \"format=flowed\" if\nword wrap is turned off. I've sent an according suggestion to the\nextension's author.\n\n[1] https://addons.mozilla.org/en-US/firefox/addon/2351\n\n-- \nSebastian Schuberth\n"}]}