{"thread":{"id":"2105","subject":"cygwin: t3200-branch.sh fails with \"List form of pipe open not implemented at -e line 22.\"","startedAt":"2005-10-14T12:46:25Z","lastAt":"2005-10-17T08:40:30Z","messageCount":6,"participants":["Alex Riesen","Junio C Hamano","H. Peter Anvin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"10099","messageId":"81b0412b0510140546ya10bc8fg3dd5eaab429eba6f@mail.gmail.com","threadId":"2105","inReplyTo":null,"subject":"cygwin: t3200-branch.sh fails with \"List form of pipe open not implemented at -e line 22.\"","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2005-10-14T12:46:25Z","receivedAt":"2005-10-14T12:46:25Z","isPatch":false,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Now, how broken is that:\n\nThe message comes from one of the hooks, which are executed even\nthough they never meant to, because cygwin apparently uses file\ncontent or name to detect executability (on FAT).\n\nI just remove the hooks from repositories atm.\n"},{"id":"10103","messageId":"7vpsq8rsgv.fsf@assigned-by-dhcp.cox.net","threadId":"2105","inReplyTo":"81b0412b0510140546ya10bc8fg3dd5eaab429eba6f@mail.gmail.com","subject":"Re: cygwin: t3200-branch.sh fails with \"List form of pipe open not implemented at -e line 22.\"","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-10-14T16:09:04Z","receivedAt":"2005-10-14T16:09:04Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Alex Riesen writes:\n\n> Now, how broken is that:\n>\n> The message comes from one of the hooks, which are executed even\n> though they never meant to, because cygwin apparently uses file\n> content or name to detect executability (on FAT).\n>\n> I just remove the hooks from repositories atm.\n\nAh, that indeed is broken.\n\nWe probably should fix it at two levels.\n\nUnless a test is trying to make sure the hook mechanism works, I\nthink we should not have them in the t/trash/ test repository.\nThe initial git-init-db done at the end of t/test-lib.sh should\nbe changed to run with an explicit --template= parameter to not\ncopy templates from random places. If somebody is going to do\nthis and supply a tested patch to me, it will also be nice to\nadd tests to specifically check the hook mechanism while she is\nat it.\n\nI think the original idea of using executable bit to control\nwhether the hook is enabled or not is still sound, but it may be\nsafer to have hooks in templates to have a suffix such as\n.sample in their names *and* be executable --- the set of hooks\ncopied from default templates are still disabled, but now\ninstead of asking users to \"chmod +x foo-hook\", we ask them to\n\"mv foo-hook.sample foo-hook\" if she wants to enable it.\n"},{"id":"10111","messageId":"434FF189.3080806@zytor.com","threadId":"2105","inReplyTo":"81b0412b0510140546ya10bc8fg3dd5eaab429eba6f@mail.gmail.com","subject":"Re: cygwin: t3200-branch.sh fails with \"List form of pipe open not implemented at -e line 22.\"","fromName":"H. Peter Anvin","fromEmail":"hpa@zytor.com","sentAt":"2005-10-14T17:57:29Z","receivedAt":"2005-10-14T17:57:29Z","isPatch":false,"sender":{"key":"hpa@zytor.com","avatar":null},"body":"Alex Riesen wrote:\n> Now, how broken is that:\n> \n> The message comes from one of the hooks, which are executed even\n> though they never meant to, because cygwin apparently uses file\n> content or name to detect executability (on FAT).\n> \n> I just remove the hooks from repositories atm.\n\nI think the bottom line is \"don't use FAT\".\n\n\t-hpa\n"},{"id":"10137","messageId":"20051015211808.GA3497@steel.home","threadId":"2105","inReplyTo":"434FF189.3080806@zytor.com","subject":"Re: cygwin: t3200-branch.sh fails with \"List form of pipe open not implemented at -e line 22.\"","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2005-10-15T21:18:08Z","receivedAt":"2005-10-15T21:18:08Z","isPatch":false,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"H. Peter Anvin, Fri, Oct 14, 2005 19:57:29 +0200:\n> >Now, how broken is that:\n> >\n> >The message comes from one of the hooks, which are executed even\n> >though they never meant to, because cygwin apparently uses file\n> >content or name to detect executability (on FAT).\n> >\n> >I just remove the hooks from repositories atm.\n> \n> I think the bottom line is \"don't use FAT\".\n> \n\nI'm afraid I have to. NTFS isn't much better (newly created files\nstill have no correct attribute) and is slower (sometimes much\nslower). Not that I have a choice, anyway: it's a typical corporate\nworkstation locked as down as possible.\n"},{"id":"10147","messageId":"7vbr1peweu.fsf@assigned-by-dhcp.cox.net","threadId":"2105","inReplyTo":"20051015211808.GA3497@steel.home","subject":"Re: cygwin: t3200-branch.sh fails with \"List form of pipe open not implemented at -e line 22.\"","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-10-16T07:46:49Z","receivedAt":"2005-10-16T07:46:49Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Alex Riesen writes:\n\n>> >The message comes from one of the hooks, which are executed even\n>> >though they never meant to, because cygwin apparently uses file\n>> >content or name to detect executability (on FAT).\n\nIs this one of the hooks we ship as examples? If so, that\nmeans worse brokenness than just test failing. It means that\nthe hook is not usable in your environment.\n\nI presume it is this line in pre-commit sample hook:\n\n open $fh, \"-|\", qw(git-diff-index -p -M --cached HEAD);\n\nIs Perl on Cygwin incapable of handle this in general, or is it\njust what is on your machine being behind?\n\nIn the meantime, I've changed two things:\n\n - Earlier, tests run in a trash/ repository that was\n initialized with user's random templates. This was *wrong*.\n It now uses freshly built templates that came from the\n source.\n\n - Further, hooks are disabled in the trash/ repository used for\n tests. When we later add tests for hooks (HINTS, anybody\n ;-)), they can add their own anyway.\n"},{"id":"10174","messageId":"81b0412b0510170140r6d5c5f23g87d01ff6cbd0d02e@mail.gmail.com","threadId":"2105","inReplyTo":"7vbr1peweu.fsf@assigned-by-dhcp.cox.net","subject":"Re: cygwin: t3200-branch.sh fails with \"List form of pipe open not implemented at -e line 22.\"","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2005-10-17T08:40:30Z","receivedAt":"2005-10-17T08:40:30Z","isPatch":false,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"On 10/16/05, Junio C Hamano wrote:\n> Alex Riesen writes:\n>\n> >> >The message comes from one of the hooks, which are executed even\n> >> >though they never meant to, because cygwin apparently uses file\n> >> >content or name to detect executability (on FAT).\n>\n> Is this one of the hooks we ship as examples? If so, that\n> means worse brokenness than just test failing. It means that\n> the hook is not usable in your environment.\n>\n> I presume it is this line in pre-commit sample hook:\n>\n> open $fh, \"-|\", qw(git-diff-index -p -M --cached HEAD);\n>\n> Is Perl on Cygwin incapable of handle this in general, or is it\n> just what is on your machine being behind?\n\nActiveState's Windows port of Perl 5.8.6.\n\n$ perl -e 'open $fh, \"-|\", qw(git-diff-index -p -M --cached HEAD)'\nList form of pipe open not implemented at -e line 1.\n\nI think it is not implemented because of Win32 lacking fork(2).\n"}]}