{"thread":{"id":"21033","subject":"[PATCH] Test for correct behaviour on %B(1) and %B(-1)","startedAt":"2009-09-23T13:12:44Z","lastAt":"2009-10-05T19:08:27Z","messageCount":2,"participants":["Johannes Gilger","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"123673","messageId":"1253711564-17876-1-git-send-email-heipei@hackvalue.de","threadId":"21033","inReplyTo":"7vmy4mo85b.fsf@alter.siamese.dyndns.org","subject":"[PATCH] Test for correct behaviour on %B(1) and %B(-1)","fromName":"Johannes Gilger","fromEmail":"heipei@hackvalue.de","sentAt":"2009-09-23T13:12:44Z","receivedAt":"2009-09-23T13:12:44Z","isPatch":true,"sender":{"key":"heipei@hackvalue.de","avatar":"https://avatars.githubusercontent.com/u/6072?v=4"},"body":"Small test for correct indentation of the new %B tag (and whether\nnegative values are ignored as an incorrect placeholder).\n\nSigned-off-by: Johannes Gilger <heipei@hackvalue.de>\n---\nHi Junio,\n\nseeing as the %B-patch is in your pu you seem to be almost happy with it. It's \nmarked NEEDSWORK: tests, so I thought I give that a try too. Probably best to \nbe squashed with the other one.\n\nGreetings,\nJojo\n\n t/t4202-log.sh |   20 ++++++++++++++------\n 1 files changed, 14 insertions(+), 6 deletions(-)\n\ndiff --git a/t/t4202-log.sh b/t/t4202-log.sh\nindex 1e952ca..9b7825d 100755\n--- a/t/t4202-log.sh\n+++ b/t/t4202-log.sh\n@@ -32,8 +32,9 @@ test_expect_success setup '\n \tgit commit -m fifth  &&\n \n \tgit rm a/two &&\n+\techo -e \"sixth\\n\\nlineone\\nlinetwo\" >sixth &&\n \ttest_tick &&\n-\tgit commit -m sixth\n+\tgit commit -F sixth\n \n '\n \n@@ -63,8 +64,15 @@ test_expect_success 'format' '\n \ttest_cmp expect actual\n '\n \n+printf \"sixth\\n\\n lineone\\n linetwo\\n%%B(-1)\\n\" > expect\n+test_expect_success 'format (subject %s, body %B(1), %B(-1))' '\n+\n+\tgit log --format=\"%s%n%n%B(1)%n%B(-1)\" 394ef78..5821e35 > actual &&\n+\ttest_cmp expect actual\n+'\n+\n cat > expect << EOF\n-804a787 sixth\n+5821e35 sixth\n 394ef78 fifth\n 5d31159 fourth\n 2fbe8c0 third\n@@ -150,22 +158,22 @@ test_expect_success 'git log --follow' '\n '\n \n cat > expect << EOF\n-804a787 sixth\n+5821e35 sixth\n 394ef78 fifth\n 5d31159 fourth\n EOF\n test_expect_success 'git log --no-walk <commits> sorts by commit time' '\n-\tgit log --no-walk --oneline 5d31159 804a787 394ef78 > actual &&\n+\tgit log --no-walk --oneline 5d31159 5821e35 394ef78 > actual &&\n \ttest_cmp expect actual\n '\n \n cat > expect << EOF\n 5d31159 fourth\n-804a787 sixth\n+5821e35 sixth\n 394ef78 fifth\n EOF\n test_expect_success 'git show <commits> leaves list of commits as given' '\n-\tgit show --oneline -s 5d31159 804a787 394ef78 > actual &&\n+\tgit show --oneline -s 5d31159 5821e35 394ef78 > actual &&\n \ttest_cmp expect actual\n '\n \n-- \n1.6.5.rc1.38.g1fbd3\n"},{"id":"124264","messageId":"7vws39acb8.fsf@alter.siamese.dyndns.org","threadId":"21033","inReplyTo":"1253711564-17876-1-git-send-email-heipei@hackvalue.de","subject":"Re: [PATCH] Test for correct behaviour on %B(1) and %B(-1)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-10-05T19:08:27Z","receivedAt":"2009-10-05T19:08:27Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Gilger <heipei@hackvalue.de> writes:\n\n> seeing as the %B-patch is in your pu you seem to be almost happy with it.\n\nBeing in 'pu' does not mean that much; it just means that I do not want to\nlose the patch and nothing more.  I'll squash the test in anyway.\n\nWe may want to build on this further to cover Dscho's line-wrap but that\nis independent of this addition.\n\nThanks.\n"}]}