{"thread":{"id":"2092","subject":"[PATCH] Revert \"Also use 'track_object_refs = 0' in update-server-info.\"","startedAt":"2005-10-13T17:20:34Z","lastAt":"2005-10-13T17:20:34Z","messageCount":1,"participants":["Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"10074","messageId":"7v1x2p49lp.fsf@assigned-by-dhcp.cox.net","threadId":"2092","inReplyTo":"20051013161010.GC12092@master.mivlgu.local","subject":"[PATCH] Revert \"Also use 'track_object_refs = 0' in update-server-info.\"","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-10-13T17:20:34Z","receivedAt":"2005-10-13T17:20:34Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Sergey spotted a grave bug, already in \"master\", which shows my\nlack of testing.  I just pushed out his fix, which is to revert\nd119e3de13ea1493107bd57381d0ce9c9dd90976.  It should propagate\nto the mirrors soon.\n\nIf you used git-update-server-info with the bug on your\nrepository, you will find a huge objects/info/packs file.\nUsually it should list just a handful edge tags and commits, but\nwith the bug it practically lists everything.\n\nAfter rebuilding the fixed git-update-server-info, please run\n'git-update-server-info -f' there to fix this problem.\n\nSorry for the stupid bug, and many thanks to Sergey.\n\n ------------\n\nThis reverts d119e3de13ea1493107bd57381d0ce9c9dd90976 commit.\n\nObject references are used in server-info.c:find_pack_info_one() to\nfind out which objects in the pack are heads, therefore tracking of\nreferences cannot be disabled.\n\nSigned-off-by: Sergey Vlasov <vsu@altlinux.ru>\nSigned-off-by: Junio C Hamano <junkio@cox.net>\n\n---\n\n Looks like this bug has caused objects/info/packs in the linux-2.4\n repository to grow huge and hit the limit, which I then needed to remove\n in the previous patch.\n\n\n update-server-info.c |    3 ---\n 1 files changed, 0 insertions(+), 3 deletions(-)\n\napplies-to: 1970e5869a42fd4095917d861654dc84d60f02b7\n985738719bfb5284911871f15180a2aee6512d53\ndiff --git a/update-server-info.c b/update-server-info.c\nindex b708563..e824f62 100644\n--- a/update-server-info.c\n+++ b/update-server-info.c\n@@ -1,5 +1,4 @@\n #include \"cache.h\"\n-#include \"object.h\"\n \n static const char update_server_info_usage[] =\n \"git-update-server-info [--force]\";\n@@ -8,8 +7,6 @@ int main(int ac, char **av)\n {\n \tint i;\n \tint force = 0;\n-\ttrack_object_refs = 0;\n-\n \tfor (i = 1; i < ac; i++) {\n \t\tif (av[i][0] == '-') {\n \t\t\tif (!strcmp(\"--force\", av[i]) ||\n---\n0.99.8.GIT\n"}]}