{"thread":{"id":"20847","subject":"Re: [JGIT] Request for help","startedAt":"2009-09-04T07:12:15Z","lastAt":"2009-09-04T07:12:15Z","messageCount":1,"participants":["Mark Struberg"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"122391","messageId":"64897.80194.qm@web27807.mail.ukl.yahoo.com","threadId":"20847","inReplyTo":null,"subject":"Re: [JGIT] Request for help","fromName":"Mark Struberg","fromEmail":"struberg@yahoo.de","sentAt":"2009-09-04T07:12:15Z","receivedAt":"2009-09-04T07:12:15Z","isPatch":false,"sender":{"key":"struberg@yahoo.de","avatar":"https://gravatar.com/avatar/119742c3e8dbc8db35a92bdff0581aec8d364d415f770e60431cba262daa974f?d=mp&s=160"},"body":"Hi!\n\nSince I work on the sonatype repo and also being a maven guy, I'd be happy to help!\n\nThere are a few patches from the work we've done to come the next weeks anyway, starting with IgnoreRules and stuff. I think we still have to improve the code quality of SimpleRepository but I'd be happy to hear your opinion on this too, so I maybe send a RFC.\n\nIf you like to go with maven for JGIT, we have 2 options:\n\n1.) Use the current directory structure and use the configuration you can see in the sonatype poms Jason did. E.g all paths have to be set in pom.sml\n\n\n2.) Do a complete rework and move over to the standard maven layout [1] . This may include moving org.spearce.jgit.test/ to org.spearce.jgit/src/test/java resp org.spearce.jgit/src/test/resources. \nIn the meantime Eclipse is really fine with handling separate target folders for production code and test classes (target/classes vs target/test-classes) so this is not a showstopper any more.\n\n\nLieGrue,\nstrub\n\n[1] http://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html\n\n\n--- On Thu, 9/3/09, Shawn O. Pearce <spearce@spearce.org> wrote:\n\n> From: Shawn O. Pearce <spearce@spearce.org>\n> Subject: Re: [JGIT] Request for help\n> To: \"Jonas Fonseca\" <jonas.fonseca@gmail.com>\n> Cc: \"Johannes Schindelin\" <Johannes.Schindelin@gmx.de>, \"Nasser Grainawi\" <nasser@codeaurora.org>, \"Git Mailing List\" <git@vger.kernel.org>\n> Date: Thursday, September 3, 2009, 5:52 PM\n> Jonas Fonseca <jonas.fonseca@gmail.com>\n> wrote:\n> > On Thu, Sep 3, 2009 at 10:42, Shawn O. Pearce<spearce@spearce.org>\n> wrote:\n> > > Actually, now that we have forked out of the\n> egit.git repository,\n> > > I want to refactor the layout of the JGit project\n> to be more maven\n> > > like, and have a proper top-level pom to build\n> things.\n> > \n> > What kind of module structure do you have in mind? Do\n> you want to move\n> > some of the modules/subdirectories?\n> > Some refactoring of the maven setup for JGit back was\n> done back in\n> > April in sonatype's (a maven company) JGit clone. It\n> is not\n> > signed-off, but can serve as a reference.\n> \n> Yea, I was hoping they would contribute this back as\n> patches,\n> but thus far they haven't.\n>  \n> > The Maven layout in the sonatype clone simply uses the\n> Eclipse project layout.\n> > \n> > pom.xml: JGit :: Parent\n> >  |- org.spearce.jgit/pom.xml: JGit :: Core\n> >  |- org.spearce.jgit.pgm/pom.xml: JGit ::\n> Programs\n> >  `- org.spearce.jgit.test/pom.xml: JGit :: Test\n> > \n> > However, having tests in a separate module can be both\n> good/bad. For\n> > example, they will not automatically get run when you\n> only build the\n> > Core module.\n> \n> Yea, I know.  This is one area where Maven is just\n> whack, by putting\n> the tests in the same project the Maven plugin for Eclipse\n> puts\n> them into the same classpath, which means you can see test\n> code\n> from project code.  Wrong.  They should be\n> different projects so\n> the test classpath is isolated.\n> \n> However.  This is a bug in the Eclipse plugin I think,\n> not\n> necessarily with Maven's approach of trying to keep tests\n> alongside\n> the code they test.  Thus we probably want:\n> \n>   pom.xml: JGit :: Parent\n>    |- jgit-lib/pom.xml: JGit\n>    | \n>    src/main/java  <-- from\n> org.spearce.jgit/src\n>    | \n>    src/test/java  <-- from\n> org.spearce.jgit.test/src\n>    |\n>    `- jgit-pgm/pom.xml: JGit pgm\n>          src/main/java \n> <-- from org.spearce.jgit.pgm/src\n> \n> IIRC there is Maven support to create proper MANIFEST.MF\n> files for\n> OSGI bundles, which is what we need for the Eclipse plugin\n> support.\n> That should be able to replace the META-INF/MANIFEST.MF in\n> the top\n> of each of the current directories.\n> \n> > Anyway, I would like to help.\n> \n> Please post patches; formatted with -M.  I do want to\n> do this, I just\n> don't have the patience and Maven-fu to write the new poms\n> myself.\n> \n> -- \n> Shawn.\n> --\n> To unsubscribe from this list: send the line \"unsubscribe\n> git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n>\n\n\n\n\n      \n"}]}