{"thread":{"id":"2069","subject":"[PATCH] Support custom build options in config.mak","startedAt":"2005-10-11T07:49:42Z","lastAt":"2005-10-11T17:18:42Z","messageCount":4,"participants":["Johannes Schindelin","Junio C Hamano","Daniel Barkalow"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"9953","messageId":"Pine.LNX.4.63.0510110948170.19774@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"2069","inReplyTo":null,"subject":"[PATCH] Support custom build options in config.mak","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2005-10-11T07:49:42Z","receivedAt":"2005-10-11T07:49:42Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"With this patch, it is possible to store configuration options like\nNO_CURL=YesPlease or NO_OPENSSL=YesPlease into a file named\nconfig.mak, which will be included in the Makefile.\n\nSigned-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>\n\n---\n\n Makefile |    4 ++++\n 1 files changed, 4 insertions(+), 0 deletions(-)\n\napplies-to: 1abfad3540e705eb33e589a8e8cf2be781c89030\n94ca33678ce4f582d9bcbaa7baf9223e026c0b13\ndiff --git a/Makefile b/Makefile\nindex ea4332b..4e2fa7e 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -213,6 +213,10 @@ ifneq (,$(findstring arm,$(uname_M)))\n \tARM_SHA1 = YesPlease\n endif\n \n+ifneq (,$(wildcard config.mak))\n+include config.mak\n+endif\n+\n ifndef NO_CURL\n \tifdef CURLDIR\n \t\t# This is still problematic -- gcc does not want -R.\n---\n0.99.8.GIT\n"},{"id":"9954","messageId":"7vr7astr27.fsf@assigned-by-dhcp.cox.net","threadId":"2069","inReplyTo":"Pine.LNX.4.63.0510110948170.19774@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH] Support custom build options in config.mak","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-10-11T08:07:28Z","receivedAt":"2005-10-11T08:07:28Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"With this patch, you can store the configuration options like\nNO_CURL=YesPlease or NO_OPENSSL=YesPlease into a file named\nMake, and I typically do this:\n\n    $ ./Make CFLAGS='-O1 -Wal -g' clean test install\n\nMy \"Make\" file looks like this:\n\n    $ cat Make\n    #!/bin/sh\n\n    PATH=/usr/bin:/bin\n    LANG=C\n    LC_CTYPE=C\n    export PATH LANG LC_CTYPE\n\n    make bindir=$HOME/bin/Linux \\\n         PYTHON_PATH=/usr/bin/python2.4 \\\n         CFLAGS=\"${CFLAGS-'-O1 -Wall -g'}\" \\\n         WITH_SEND_EMAIL=YesPlease \"$@\"\n\nNothing-to-sign-off-by: Junio C Hamano <junkio@cox.net>\n---\n  0 files changed.\n\n    Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n\n    > With this patch, it is possible to store configuration options like\n    > NO_CURL=YesPlease or NO_OPENSSL=YesPlease into a file named\n    > config.mak, which will be included in the Makefile.\n\n    IOW, I'll have to think about its merit ;-)\n"},{"id":"9955","messageId":"Pine.LNX.4.63.0510111307410.20527@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"2069","inReplyTo":"7vr7astr27.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Support custom build options in config.mak","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2005-10-11T11:08:22Z","receivedAt":"2005-10-11T11:08:22Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 11 Oct 2005, Junio C Hamano wrote:\n\n> With this patch, you can store the configuration options like\n> NO_CURL=YesPlease or NO_OPENSSL=YesPlease into a file named\n> Make, and I typically do this:\n> \n> [...]\n\n:-)\n"},{"id":"9969","messageId":"Pine.LNX.4.63.0510111308520.23242@iabervon.org","threadId":"2069","inReplyTo":"Pine.LNX.4.63.0510110948170.19774@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH] Support custom build options in config.mak","fromName":"Daniel Barkalow","fromEmail":"barkalow@iabervon.org","sentAt":"2005-10-11T17:18:42Z","receivedAt":"2005-10-11T17:18:42Z","isPatch":true,"sender":{"key":"barkalow@iabervon.org","avatar":"https://avatars.githubusercontent.com/u/55364219?v=4"},"body":"On Tue, 11 Oct 2005, Johannes Schindelin wrote:\n\n> +ifneq (,$(wildcard config.mak))\n> +include config.mak\n> +endif\n> +\n\nYou can just do:\n\n-include config.mak\n\nfor the same effect; it includes the file if it exists, and doesn't \ncomplain if it doesn't exist. (It also means that make has a clearer idea \nof what it's doing, which doesn't matter in this case, but is good in \ngeneral.)\n\n\t-Daniel\n*This .sig left intentionally blank*\n"}]}