{"thread":{"id":"20674","subject":"[PATCH v2] Fix symlink __stdcall problem at MSVC","startedAt":"2009-08-20T14:21:12Z","lastAt":"2009-08-21T02:57:10Z","messageCount":3,"participants":["Frank Li"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"121349","messageId":"1250778072-4324-1-git-send-email-lznuaa@gmail.com","threadId":"20674","inReplyTo":null,"subject":"[PATCH v2] Fix symlink __stdcall problem at MSVC","fromName":"Frank Li","fromEmail":"lznuaa@gmail.com","sentAt":"2009-08-20T14:21:12Z","receivedAt":"2009-08-20T14:21:12Z","isPatch":true,"sender":{"key":"lznuaa@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40642?v=4"},"body":"MSVC requires that __stdcall be between return value and function name.\nFurther, all Win32 API definitions look like this:\n\n\tTYPE WINAPI function_name...\n\nSigned-off-by: Frank Li <lznuaa@gmail.com>\n---\n compat/mingw.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/compat/mingw.c b/compat/mingw.c\nindex fd642e4..4256243 100644\n--- a/compat/mingw.c\n+++ b/compat/mingw.c\n@@ -1421,7 +1421,7 @@ int link(const char *oldpath, const char *newpath)\n \n int symlink(const char *oldpath, const char *newpath)\n {\n-\ttypedef BOOL WINAPI (*symlink_fn)(const char*, const char*, DWORD);\n+\ttypedef BOOL (WINAPI *symlink_fn)(const char*, const char*, DWORD);\n \tstatic symlink_fn create_symbolic_link = NULL;\n \tif (!create_symbolic_link) {\n \t\tcreate_symbolic_link = (symlink_fn) GetProcAddress(\n-- \n1.6.4.msysgit.0\n"},{"id":"121372","messageId":"1976ea660908201942r7ba14d1cnbb516f9f2c31f8bb@mail.gmail.com","threadId":"20674","inReplyTo":"1250778072-4324-1-git-send-email-lznuaa@gmail.com","subject":"Re: [PATCH v2] Fix symlink __stdcall problem at MSVC","fromName":"Frank Li","fromEmail":"lznuaa@gmail.com","sentAt":"2009-08-21T02:42:14Z","receivedAt":"2009-08-21T02:42:14Z","isPatch":true,"sender":{"key":"lznuaa@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40642?v=4"},"body":">\n>  int symlink(const char *oldpath, const char *newpath)\n>  {\n> -       typedef BOOL WINAPI (*symlink_fn)(const char*, const char*, DWORD);\n> +       typedef BOOL (WINAPI *symlink_fn)(const char*, const char*, DWORD);\n>        static symlink_fn create_symbolic_link = NULL;\n>        if (!create_symbolic_link) {\n>                create_symbolic_link = (symlink_fn) GetProcAddress(\n> --\n> 1.6.4.msysgit.0\n>\n\nThis is new patch for latest devel branch mingw.c.\n"},{"id":"121374","messageId":"1976ea660908201957l76ebf555wbbbda0dbfb8cbdd7@mail.gmail.com","threadId":"20674","inReplyTo":"1250778072-4324-1-git-send-email-lznuaa@gmail.com","subject":"Re: [PATCH v2] Fix symlink __stdcall problem at MSVC","fromName":"Frank Li","fromEmail":"lznuaa@gmail.com","sentAt":"2009-08-21T02:57:10Z","receivedAt":"2009-08-21T02:57:10Z","isPatch":true,"sender":{"key":"lznuaa@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40642?v=4"},"body":"\n>\n>  int symlink(const char *oldpath, const char *newpath)\n>  {\n> -       typedef BOOL WINAPI (*symlink_fn)(const char*, const char*, DWORD);\n> +       typedef BOOL (WINAPI *symlink_fn)(const char*, const char*, DWORD);\n>        static symlink_fn create_symbolic_link = NULL;\n>        if (!create_symbolic_link) {\n>                create_symbolic_link = (symlink_fn) GetProcAddress(\n> --\n> 1.6.4.msysgit.0\n>\n\nThis is new patch for latest devel branch mingw.c.\n"}]}