{"thread":{"id":"20672","subject":"[PATCH] Fix symlink __stdcall problem at MSVC","startedAt":"2009-08-20T13:24:40Z","lastAt":"2009-08-20T14:16:50Z","messageCount":3,"participants":["Frank Li","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"121325","messageId":"1250774680-4720-1-git-send-email-lznuaa@gmail.com","threadId":"20672","inReplyTo":null,"subject":"[PATCH] Fix symlink __stdcall problem at MSVC","fromName":"Frank Li","fromEmail":"lznuaa@gmail.com","sentAt":"2009-08-20T13:24:40Z","receivedAt":"2009-08-20T13:24:40Z","isPatch":true,"sender":{"key":"lznuaa@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40642?v=4"},"body":"MSVC requires that __stdcall be between return value and function name.\nFurther, all Win32 API definitions look like this:\n\nSigned-off-by: Frank Li <lznuaa@gmail.com>\n---\n compat/mingw.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/compat/mingw.c b/compat/mingw.c\nindex fd642e4..4256243 100644\n--- a/compat/mingw.c\n+++ b/compat/mingw.c\n@@ -1421,7 +1421,7 @@ int link(const char *oldpath, const char *newpath)\n \n int symlink(const char *oldpath, const char *newpath)\n {\n-\ttypedef BOOL WINAPI (*symlink_fn)(const char*, const char*, DWORD);\n+\ttypedef BOOL (WINAPI *symlink_fn)(const char*, const char*, DWORD);\n \tstatic symlink_fn create_symbolic_link = NULL;\n \tif (!create_symbolic_link) {\n \t\tcreate_symbolic_link = (symlink_fn) GetProcAddress(\n-- \n1.6.4.msysgit.0\n"},{"id":"121326","messageId":"alpine.DEB.1.00.0908201546500.4719@intel-tinevez-2-302","threadId":"20672","inReplyTo":"1250774680-4720-1-git-send-email-lznuaa@gmail.com","subject":"Re: [PATCH] Fix symlink __stdcall problem at MSVC","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-08-20T13:47:12Z","receivedAt":"2009-08-20T13:47:12Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Thu, 20 Aug 2009, Frank Li wrote:\n\n> MSVC requires that __stdcall be between return value and function name.\n> Further, all Win32 API definitions look like this:\n> \n> Signed-off-by: Frank Li <lznuaa@gmail.com>\n> ---\n\nLike what?  Seems you did not paste my complete commit message.\n\nCiao,\nDscho\n"},{"id":"121348","messageId":"1976ea660908200716u6643ff3fgd30f6cd859260316@mail.gmail.com","threadId":"20672","inReplyTo":"alpine.DEB.1.00.0908201546500.4719@intel-tinevez-2-302","subject":"Re: [PATCH] Fix symlink __stdcall problem at MSVC","fromName":"Frank Li","fromEmail":"lznuaa@gmail.com","sentAt":"2009-08-20T14:16:50Z","receivedAt":"2009-08-20T14:16:50Z","isPatch":true,"sender":{"key":"lznuaa@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40642?v=4"},"body":">\n> Like what?  Seems you did not paste my complete commit message.\n>\nYes, Sorry about this\n"}]}