{"thread":{"id":"20659","subject":"[PATCH][resend 3] git-svn: Use GIT_SSH setting if SVN_SSH is not set","startedAt":"2009-08-18T23:54:40Z","lastAt":"2009-08-19T03:58:27Z","messageCount":2,"participants":["Karthik R","Eric Wong"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"121192","messageId":"4A8B3F40.10803@fastmail.fm","threadId":"20659","inReplyTo":null,"subject":"[PATCH][resend 3] git-svn: Use GIT_SSH setting if SVN_SSH is not set","fromName":"Karthik R","fromEmail":"karthikr@fastmail.fm","sentAt":"2009-08-18T23:54:40Z","receivedAt":"2009-08-18T23:54:40Z","isPatch":true,"sender":{"key":"karthikr@fastmail.fm","avatar":null},"body":"If SVN_SSH is defined, it will be used. Else value in\nGIT_SSH is copied to SVN_SSH & then, only on Windows,\nthe \\s are escaped.\n\nOn Windows, the shell-variables must be set as follows\n    GIT_SSH=\"C:\\Program Files\\PuTTY\\plink.exe\"\n    SVN_SSH=\"C:\\\\Program Files\\\\PuTTY\\\\plink.exe\"\n\nSee http://code.google.com/p/msysgit/issues/detail?id=305\n\nSigned-off-by: Karthik Rajagopalan <karthikr@fastmail.fm>\n---\nSigned off this time.\n\nPrevious life of patch:\n[PATCH] GIT_SSH does not override ssh in git-svn\n[PATCH][resend] git-svn: Respect GIT_SSH setting\n\n git-svn.perl |    9 +++++++++\n 1 files changed, 9 insertions(+), 0 deletions(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex b0bfb74..ef86d10 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -21,6 +21,15 @@ $Git::SVN::default_ref_id = $ENV{GIT_SVN_ID} ||\n'git-svn';\n $Git::SVN::Ra::_log_window_size = 100;\n $Git::SVN::_minimize_url = 'unset';\n \n+if (! exists $ENV{SVN_SSH}) {\n+    if (exists $ENV{GIT_SSH}) {\n+        $ENV{SVN_SSH} = $ENV{GIT_SSH};\n+        if ($^O eq 'msys') {\n+            $ENV{SVN_SSH} =~ s/\\\\/\\\\\\\\/g;\n+        }\n+    }\n+}\n+\n $Git::SVN::Log::TZ = $ENV{TZ};\n $ENV{TZ} = 'UTC';\n $| = 1; # unbuffer STDOUT\n-- \n1.5.4.3\n"},{"id":"121208","messageId":"20090819035827.GA1454@dcvr.yhbt.net","threadId":"20659","inReplyTo":"4A8B3F40.10803@fastmail.fm","subject":"Re: [PATCH][resend 3] git-svn: Use GIT_SSH setting if SVN_SSH is not set","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2009-08-19T03:58:27Z","receivedAt":"2009-08-19T03:58:27Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Karthik R <karthikr@fastmail.fm> wrote:\n> If SVN_SSH is defined, it will be used. Else value in\n> GIT_SSH is copied to SVN_SSH & then, only on Windows,\n> the \\s are escaped.\n> \n> On Windows, the shell-variables must be set as follows\n>     GIT_SSH=\"C:\\Program Files\\PuTTY\\plink.exe\"\n>     SVN_SSH=\"C:\\\\Program Files\\\\PuTTY\\\\plink.exe\"\n> \n> See http://code.google.com/p/msysgit/issues/detail?id=305\n> \n> Signed-off-by: Karthik Rajagopalan <karthikr@fastmail.fm>\n\nThanks Karthik,\n\nAcked and pushed out along with a few others I hadn't pushed\nto git://yhbt.net/git-svn\n\nEric Wong (1):\n      svn: assume URLs from the command-line are URI-encoded\n\nKarthik R (1):\n      git-svn: Use GIT_SSH setting if SVN_SSH is not set\n\nTuomas Suutari (1):\n      git-svn.txt: Fix location of parent argument\n\n-- \nEric Wong\n"}]}