{"thread":{"id":"20497","subject":"[PATCH 1/2] t0001-init: fix a file name","startedAt":"2009-08-09T15:38:04Z","lastAt":"2009-08-09T16:02:55Z","messageCount":3,"participants":["Johannes Sixt"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"120056","messageId":"4A7EED5C.8050707@kdbg.org","threadId":"20497","inReplyTo":null,"subject":"[PATCH 1/2] t0001-init: fix a file name","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2009-08-09T15:38:04Z","receivedAt":"2009-08-09T15:38:04Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Without this change, grep fails because it does not find the file\ninstead of because it does not find the text in the file.\n\nSigned-off-by: Johannes Sixt <j6t@kdbg.org>\n---\n  t/t0001-init.sh |    2 +-\n  1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/t/t0001-init.sh b/t/t0001-init.sh\nindex 49caa29..07e011d 100755\n--- a/t/t0001-init.sh\n+++ b/t/t0001-init.sh\n@@ -251,7 +251,7 @@ test_expect_success 'init creates a new deep directory' '\n  \t\tgit init --bare --shared=0660 newdir/a/b/c &&\n  \t\ttest -d newdir/a/b/c/refs &&\n  \t\tls -ld newdir/a newdir/a/b > lsab.out &&\n-\t\t! grep -v \"^drwxrw[sx]r-x\" ls.out &&\n+\t\t! grep -v \"^drwxrw[sx]r-x\" lsab.out &&\n  \t\tls -ld newdir/a/b/c > lsc.out &&\n  \t\t! grep -v \"^drwxrw[sx]---\" lsc.out\n  \t)\n-- \n1.6.4.1186.g1d9a\n"},{"id":"120057","messageId":"4A7EEDA7.30301@kdbg.org","threadId":"20497","inReplyTo":"4A7EED5C.8050707@kdbg.org","subject":"[PATCH 2/2] t0001-init: split the existence test from the permission test","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2009-08-09T15:39:19Z","receivedAt":"2009-08-09T15:39:19Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"The test for correct permissions after init created a deep directory\nmust be guarded by POSIXPERM. But testing that the deep dirctory exists\nis good even on platforms that do not provide the POSIXPERM prerequiste.\n\nSigned-off-by: Johannes Sixt <j6t@kdbg.org>\n---\n  t/t0001-init.sh |    8 ++++++++\n  1 files changed, 8 insertions(+), 0 deletions(-)\n\ndiff --git a/t/t0001-init.sh b/t/t0001-init.sh\nindex 07e011d..e53b234 100755\n--- a/t/t0001-init.sh\n+++ b/t/t0001-init.sh\n@@ -245,6 +245,14 @@ test_expect_success 'init recreates a new bare directory' '\n  test_expect_success 'init creates a new deep directory' '\n  \trm -fr newdir &&\n  \t(\n+\t\tgit init newdir/a/b/c &&\n+\t\ttest -d newdir/a/b/c/.git/refs\n+\t)\n+'\n+\n+test_expect_success POSIXPERM 'init creates a new deep directory (umask vs. shared)' '\n+\trm -fr newdir &&\n+\t(\n  \t\t# Leading directories should honor umask while\n  \t\t# the repository itself should follow \"shared\"\n  \t\tumask 002 &&\n-- \n1.6.4.1186.g1d9a\n"},{"id":"120058","messageId":"4A7EF32F.6080408@kdbg.org","threadId":"20497","inReplyTo":"4A7EEDA7.30301@kdbg.org","subject":"[PATCH v2 2/2] t0001-init: split the existence test from the permission test","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2009-08-09T16:02:55Z","receivedAt":"2009-08-09T16:02:55Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"The test for correct permissions after init created a deep directory\nmust be guarded by POSIXPERM. But testing that the deep dirctory exists\nis good even on platforms that do not provide the POSIXPERM prerequiste.\n\nSigned-off-by: Johannes Sixt <j6t@kdbg.org>\n---\n  Sorry, the first version was the result of mindless copying. This version\n  removes the sub-shell (parentheses).\n\n  -- Hannes\n\n  t/t0001-init.sh |    6 ++++++\n  1 files changed, 6 insertions(+), 0 deletions(-)\n\ndiff --git a/t/t0001-init.sh b/t/t0001-init.sh\nindex 07e011d..5386504 100755\n--- a/t/t0001-init.sh\n+++ b/t/t0001-init.sh\n@@ -244,6 +244,12 @@ test_expect_success 'init recreates a new bare directory' '\n\n  test_expect_success 'init creates a new deep directory' '\n  \trm -fr newdir &&\n+\tgit init newdir/a/b/c &&\n+\ttest -d newdir/a/b/c/.git/refs\n+'\n+\n+test_expect_success POSIXPERM 'init creates a new deep directory (umask vs. shared)' '\n+\trm -fr newdir &&\n  \t(\n  \t\t# Leading directories should honor umask while\n  \t\t# the repository itself should follow \"shared\"\n-- \n1.6.4.1186.g1d9a\n\n\t\n"}]}