{"thread":{"id":"20477","subject":"[PATCH 6/9] update 'git-rm' bash completion according to the man page","startedAt":"2009-08-08T08:56:40Z","lastAt":"2009-08-08T20:33:12Z","messageCount":3,"participants":["Emmanuel Trillaud","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":9},"messages":[{"id":"119978","messageId":"9f50533b0908080156t7cfd05ebg3e5d29f7d2260c25@mail.gmail.com","threadId":"20477","inReplyTo":null,"subject":"[PATCH 6/9] update 'git-rm' bash completion according to the man page","fromName":"Emmanuel Trillaud","fromEmail":"etrillaud@gmail.com","sentAt":"2009-08-08T08:56:40Z","receivedAt":"2009-08-08T08:56:40Z","isPatch":true,"sender":{"key":"etrillaud@gmail.com","avatar":null},"body":"Signed-off-by: Emmanuel Trillaud <etrillaud@gmail.com>\n---\n contrib/completion/git-completion.bash |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash\nb/contrib/completion/git-completion.bash\nindex 98e1185..4746eee 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1828,7 +1828,7 @@ _git_rm ()\n \tlocal cur=\"${COMP_WORDS[COMP_CWORD]}\"\n \tcase \"$cur\" in\n \t--*)\n-\t\t__gitcomp \"--cached --dry-run --ignore-unmatch --quiet\"\n+\t\t__gitcomp \"--force --cached --dry-run --ignore-unmatch --quiet\"\n \t\treturn\n \t\t;;\n \tesac\n-- \n1.6.4\n"},{"id":"120008","messageId":"7vljludr2d.fsf@alter.siamese.dyndns.org","threadId":"20477","inReplyTo":"9f50533b0908080156t7cfd05ebg3e5d29f7d2260c25@mail.gmail.com","subject":"Re: [PATCH 6/9] update 'git-rm' bash completion according to the man page","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-08-08T19:49:14Z","receivedAt":"2009-08-08T19:49:14Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Emmanuel Trillaud <etrillaud@gmail.com> writes:\n\n> Signed-off-by: Emmanuel Trillaud <etrillaud@gmail.com>\n\nDescription of what you did?\n\n> -\t\t__gitcomp \"--cached --dry-run --ignore-unmatch --quiet\"\n> +\t\t__gitcomp \"--force --cached --dry-run --ignore-unmatch --quiet\"\n\nI thought not completing --force to allow a dangerous operation was a\nconscious decision.\n"},{"id":"120013","messageId":"20090808223312.75ba3d10@eleanor","threadId":"20477","inReplyTo":"7vljludr2d.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH 6/9] update 'git-rm' bash completion according to the man page","fromName":"Emmanuel Trillaud","fromEmail":"etrillaud@gmail.com","sentAt":"2009-08-08T20:33:12Z","receivedAt":"2009-08-08T20:33:12Z","isPatch":true,"sender":{"key":"etrillaud@gmail.com","avatar":null},"body":"> > -\t\t__gitcomp \"--cached --dry-run --ignore-unmatch\n> > --quiet\"\n> > +\t\t__gitcomp \"--force --cached --dry-run\n> > --ignore-unmatch --quiet\"\n> \n> I thought not completing --force to allow a dangerous operation was a\n> conscious decision.\nFor me, completion as always been a reminder for options I forgot (or I\nthink they exist) and I use short options when I know them because it is\neasier to type. So IMHO '--force' is a useful option that deserve to be\ncomplete. \n\nBut if you make a conscious decision in the past to not complete\n'--force', I won't fight :-) and I will just add a comment in the\ngit-completion script for the guys like me who think it is missing.\n\nBest regard \n\nEmmanuel\n"}]}