{"thread":{"id":"20475","subject":"[PATCH 4/9] add missing long option to 'git grep' bash competion","startedAt":"2009-08-08T08:56:18Z","lastAt":"2009-08-08T20:07:39Z","messageCount":3,"participants":["Emmanuel Trillaud","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":9},"messages":[{"id":"119976","messageId":"9f50533b0908080156h23415740lb94cbd9f2c6a165d@mail.gmail.com","threadId":"20475","inReplyTo":null,"subject":"[PATCH 4/9] add missing long option to 'git grep' bash competion","fromName":"Emmanuel Trillaud","fromEmail":"etrillaud@gmail.com","sentAt":"2009-08-08T08:56:18Z","receivedAt":"2009-08-08T08:56:18Z","isPatch":true,"sender":{"key":"etrillaud@gmail.com","avatar":null},"body":"according to the 'git-grep' man page, the following long options are missing\nfrom the 'git grep' bash completion :\n--null\n--color\n--no-color\n\nSigned-off-by: Emmanuel Trillaud <etrillaud@gmail.com>\n---\n contrib/completion/git-completion.bash |    2 ++\n 1 files changed, 2 insertions(+), 0 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash\nb/contrib/completion/git-completion.bash\nindex f56733b..a4e78d5 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1057,7 +1057,9 @@ _git_grep ()\n \t\t\t--extended-regexp --basic-regexp --fixed-strings\n \t\t\t--files-with-matches --name-only\n \t\t\t--files-without-match\n+\t\t\t--null\n \t\t\t--count\n+\t\t\t--color --no-color\n \t\t\t--and --or --not --all-match\n \t\t\t\"\n \t\treturn\n-- \n1.6.4\n"},{"id":"120007","messageId":"7vskg2dr3o.fsf@alter.siamese.dyndns.org","threadId":"20475","inReplyTo":"9f50533b0908080156h23415740lb94cbd9f2c6a165d@mail.gmail.com","subject":"Re: [PATCH 4/9] add missing long option to 'git grep' bash competion","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-08-08T19:48:27Z","receivedAt":"2009-08-08T19:48:27Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Emmanuel Trillaud <etrillaud@gmail.com> writes:\n\n> according to the 'git-grep' man page, the following long options are missing\n> from the 'git grep' bash completion :\n> --null\n> --color\n> --no-color\n\nI do not think completion's purpose should be to offer everything\navailable under the sun, so \"according to manpage these are missing\" can\nnever be a good justification for patches in this series.\n\nDoes it even make sense to complete --null in an interactive invocation?\n"},{"id":"120012","messageId":"20090808220739.663bb1f7@eleanor","threadId":"20475","inReplyTo":"7vskg2dr3o.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH 4/9] add missing long option to 'git grep' bash competion","fromName":"Emmanuel Trillaud","fromEmail":"etrillaud@gmail.com","sentAt":"2009-08-08T20:07:39Z","receivedAt":"2009-08-08T20:07:39Z","isPatch":true,"sender":{"key":"etrillaud@gmail.com","avatar":null},"body":"> > according to the 'git-grep' man page, the following long options are\n> > missing from the 'git grep' bash completion :\n> > --null\n> > --color\n> > --no-color\n> \n> I do not think completion's purpose should be to offer everything\n> available under the sun, so \"according to manpage these are missing\" can\n> never be a good justification for patches in this series.\nWhen I saw that completion for the long options of 'git checkout' was\nmising, I just start looking around the docs to see if there wasn't other\ngit commands with some missing completions. I see now it was a wrong way\nto update the git bash completion. I will soon come back with a new set\nof (more reasonnable) patches.\n\nEmmanuel \n"}]}