{"thread":{"id":"20356","subject":"[PATCH] hg-to-git: don't import the unused popen2 module","startedAt":"2009-08-03T16:41:34Z","lastAt":"2009-08-03T16:41:34Z","messageCount":1,"participants":["Miklos Vajna"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"119413","messageId":"20090803164134.GZ23059@genesis.frugalware.org","threadId":"20356","inReplyTo":null,"subject":"[PATCH] hg-to-git: don't import the unused popen2 module","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2009-08-03T16:41:34Z","receivedAt":"2009-08-03T16:41:34Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"Importing the popen2 module in Python-2.6 results in the\n\"DeprecationWarning: The popen2 module is deprecated.  Use the\nsubprocess module.\" message. The module itself isn't used in fact, so\njust removing it solves the problem.\n\nSigned-off-by: Miklos Vajna <vmiklos@frugalware.org>\n---\n contrib/hg-to-git/hg-to-git.py |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/hg-to-git/hg-to-git.py b/contrib/hg-to-git/hg-to-git.py\nindex 7b03204..2a6839d 100755\n--- a/contrib/hg-to-git/hg-to-git.py\n+++ b/contrib/hg-to-git/hg-to-git.py\n@@ -20,7 +20,7 @@\n \"\"\"\n \n import os, os.path, sys\n-import tempfile, popen2, pickle, getopt\n+import tempfile, pickle, getopt\n import re\n \n # Maps hg version -> git version\n-- \n1.6.4\n"}]}