{"thread":{"id":"20252","subject":"Slight in error in git-rerere help page","startedAt":"2009-07-28T02:20:30Z","lastAt":"2009-07-28T14:42:15Z","messageCount":3,"participants":["François Pinard","Michael J Gruber"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"118915","messageId":"ygeocr5blap.fsf@phenix.progiciels-bpi.ca","threadId":"20252","inReplyTo":null,"subject":"Slight in error in git-rerere help page","fromName":"François Pinard","fromEmail":"pinard@iro.umontreal.ca","sentAt":"2009-07-28T02:20:30Z","receivedAt":"2009-07-28T02:20:30Z","isPatch":false,"sender":{"key":"pinard@iro.umontreal.ca","avatar":"https://gravatar.com/avatar/0386d0a988a95ad3de74a32872041ab246d4ecad441d961a837ed5af6ab81c79?d=mp&s=160"},"body":"Hi, people.  This is for git version 1.6.4.rc3.12.gdf73a\n\nThe output of \"git help rerere\" contains:\n\n   You need to set the configuration variable rerere.enabled to enable\n   this command.\n\nIt seems that that \"enable\" is not a proper value.  If I used it over a\nsmall repository, I get:\n\n   22:17:33 0 pinard@phenix:etc $ git config rerere.enabled enable\n   22:17:44 0 pinard@phenix:etc $ git gc\n   Counting objects: 1072, done.\n   Compressing objects: 100% (559/559), done.\n   Writing objects: 100% (1072/1072), done.\n   Total 1072 (delta 460), reused 1072 (delta 460)\n   fatal: bad config value for 'rerere.enabled' in .git/config\n   error: failed to run rerere\n\nRemoving the rerere section repairs this last problem.\n\nP.S. - I'm also a bit curious about why rerere is needed for a garbage\ncollection.\n\n\n-- \nFrançois Pinard   http://pinard.progiciels-bpi.ca\n"},{"id":"118916","messageId":"ygetz0x35ja.fsf@phenix.progiciels-bpi.ca","threadId":"20252","inReplyTo":"ygeocr5blap.fsf@phenix.progiciels-bpi.ca","subject":"Re: Slight in error in git-rerere help page","fromName":"François Pinard","fromEmail":"pinard@iro.umontreal.ca","sentAt":"2009-07-28T02:28:09Z","receivedAt":"2009-07-28T02:28:09Z","isPatch":false,"sender":{"key":"pinard@iro.umontreal.ca","avatar":"https://gravatar.com/avatar/0386d0a988a95ad3de74a32872041ab246d4ecad441d961a837ed5af6ab81c79?d=mp&s=160"},"body":"pinard@iro.umontreal.ca (François Pinard) writes:\n\n> Hi, people.  This is for git version 1.6.4.rc3.12.gdf73a\n>\n> The output of \"git help rerere\" contains:\n>\n>    You need to set the configuration variable rerere.enabled to enable\n>    this command.\n>\n> It seems that that \"enable\" is not a proper value.  If I used it over a\n> small repository, I get:\n>\n>    22:17:33 0 pinard@phenix:etc $ git config rerere.enabled enable\n>    22:17:44 0 pinard@phenix:etc $ git gc\n>    Counting objects: 1072, done.\n>    Compressing objects: 100% (559/559), done.\n>    Writing objects: 100% (1072/1072), done.\n>    Total 1072 (delta 460), reused 1072 (delta 460)\n>    fatal: bad config value for 'rerere.enabled' in .git/config\n>    error: failed to run rerere\n>\n> Removing the rerere section repairs this last problem.\n>\n> P.S. - I'm also a bit curious about why rerere is needed for a garbage\n> collection.\n\nI now see my mistake, which is one of misreading English.  Sorry for my\nnoise.  Thanks!\n\n-- \nFrançois Pinard   http://pinard.progiciels-bpi.ca\n"},{"id":"118964","messageId":"1248792135-3361-1-git-send-email-git@drmicha.warpmail.net","threadId":"20252","inReplyTo":"ygetz0x35ja.fsf@phenix.progiciels-bpi.ca","subject":"[PATCH] git-rerere.txt: Clarify ambiguity of the config variable","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2009-07-28T14:42:15Z","receivedAt":"2009-07-28T14:42:15Z","isPatch":true,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"Use the less ambiguous\n\"set variable foo in order to enable bar\"\nrather than\n\"set variable foo to enable bar\" which may trick users into\nassuming that \"enable\" is a good value for \"foo\".\n\nSigned-off-by: Michael J Gruber <git@drmicha.warpmail.net>\n---\nI know there is no way to misunderstand this if one looks at the whole\nsentence, but still I deem it worthwhile to make it easier on the reader.\n\nPatch is against maint (git-rerere.txt does not have any more recent changes).\n\n Documentation/git-rerere.txt |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/git-rerere.txt b/Documentation/git-rerere.txt\nindex a53c3cd..7dd515b 100644\n--- a/Documentation/git-rerere.txt\n+++ b/Documentation/git-rerere.txt\n@@ -23,7 +23,7 @@ on the initial manual merge, and applying previously recorded\n hand resolutions to their corresponding automerge results.\n \n [NOTE]\n-You need to set the configuration variable rerere.enabled to\n+You need to set the configuration variable rerere.enabled in order to\n enable this command.\n \n \n-- \n1.6.4.rc3.201.gd9d59\n"}]}